Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1620

Fix Open URL... when no genome selected

        Details

        • Story Points:
          1
        • Epic Link:
        • Sprint:
          Spring 2019 Sprint 3, Spring 2019 Sprint 5, Spring 2019 Sprint 6, Summer 2019 Sprint 7, Summer 2019 Sprint 8

          Description

          Situation: A user wants to load data from a URL without first selecting a genome. If they click File > Open URL... they will receive an error message informing them to first select a genome.

          Task: Enable a user to select a file from a URL without having to first select a genome.

            Attachments

              Issue Links

              relates to

              Task - A task that needs to be done. IGBF-1590 Implement View in IGB button

              • Major - Major loss of function.
              • Closed

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-1509 Open File... should work if no genome available

              • Minor - Minor loss of function, or other problem where easy workaround is present.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Review code by Riddhi Patil - see linked issues.

                Show
                ann.loraine Ann Loraine added a comment - Review code by Riddhi Patil - see linked issues.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                [~aloraine]
                I have updated the code with respect to the requirements. You can find my branch here:

                https://bitbucket.org/sshanbh1/sameer-igb/commits/d39eb545ba0dbf286135c7465fd587f7e9882634?at=IGBF-1620

                The Build runs perfectly fine, I will be moving the Ticket on the Board.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - [~aloraine] I have updated the code with respect to the requirements. You can find my branch here: https://bitbucket.org/sshanbh1/sameer-igb/commits/d39eb545ba0dbf286135c7465fd587f7e9882634?at=IGBF-1620 The Build runs perfectly fine, I will be moving the Ticket on the Board.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                1st level review: Working correctly, I can load a file from URL without first selecting a genome.

                Show
                nfreese Nowlan Freese added a comment - 1st level review: Working correctly, I can load a file from URL without first selecting a genome.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Thank you for the update.

                Heres the pull request for the same:
                https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/696/igbf-1620-fix-open-url-when-no-genome/diff

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Thank you for the update. Heres the pull request for the same: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/696/igbf-1620-fix-open-url-when-no-genome/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged to master.

                Show
                ann.loraine Ann Loraine added a comment - Merged to master.
                Hide
                Permalink
                stiwari8 Srishti Tiwari (Inactive) added a comment -

                Working correctly in Windows.

                Show
                stiwari8 Srishti Tiwari (Inactive) added a comment - Working correctly in Windows.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Working correctly on Mac.

                Show
                nfreese Nowlan Freese added a comment - Working correctly on Mac.
                Hide
                Permalink
                stiwari8 Srishti Tiwari (Inactive) added a comment -

                Does not work on Linux.

                Show
                stiwari8 Srishti Tiwari (Inactive) added a comment - Does not work on Linux.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Srishti Tiwari Works perfectly fine on Ubuntu Machine.

                Could you please test again using the Latest Version of the App. You can use the Following Download Link:

                https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/IGB-master.sh

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Srishti Tiwari Works perfectly fine on Ubuntu Machine. Could you please test again using the Latest Version of the App. You can use the Following Download Link: https://bitbucket.org/lorainelab/integrated-genome-browser/downloads/IGB-master.sh
                Hide
                Permalink
                stiwari8 Srishti Tiwari (Inactive) added a comment -

                If we run IGB-master.sh it works fine, but IGB-master.jar generated for download is the old version. Raising different issue for the same.

                Show
                stiwari8 Srishti Tiwari (Inactive) added a comment - If we run IGB-master.sh it works fine, but IGB-master.jar generated for download is the old version. Raising different issue for the same.

                  People

                  • Assignee:
                    sameer Sameer Shanbhag (Inactive)
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: