The "shared-lib-wrapper" in unison with the project it uses the version from its Parent POM.xml

Workflow:
1. Parent POM files get the Artifacts from the Maven Servers
2. These Dependancies/Artifacts are then Bundled into Shared Wrapper Package
Note: shared-lib-wrapper.jar is bundled with libraries having the versions specified in the properties of the main POM.xml

Code :

<parent>
<groupId>org.lorainelab.igb</groupId>
<artifactId>igb-project</artifactId>
<version>9.1.0</version>
<relativePath>../../pom.xml</relativePath>
</parent>
<artifactId>shared-lib-wrapper</artifactId>
<packaging>bundle</packaging>

[From Shared-lib-wrapper | POM.xml]

Dependencies Packaged:

<dependency>
<groupId>com.affymetrix</groupId>
<artifactId>fusion</artifactId>
</dependency>

[From Shared-lib-wrapper | POM.xml]

The Dependancy Packaged is w.r.t shared-lib-wrapper and it uses the Parent Version by-default when a Version is not Specified

Issue:
There are some Artifacts in the POM file which gets its version explicitly from the Configurations mentioned in the Parent POM File which looks something like this:

<commonsCsvVersion>1.2</commonsCsvVersion>
<commonsIoVersion>2.4</commonsIoVersion>

[From main | POM.xml]

This can be used across the application and there are no refactoring needed ones edited in the main POM File, but it looks like the POM Dependency is not completely generated with parent level declaration. Some of the example which needs changes:

<dependency>
<groupId>furbelow</groupId>
<artifactId>furbelow</artifactId>
<version>1.0</version>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-lgpl</artifactId>
<version>1.7.9</version>
</dependency>

[From Shared-lib-wrapper | POM.xml]

In this case, the Version can be shifted to a centralized location i.e. in the Properties of the main POM.xml.

Similarly, we need to change all the POM Files with the updated properties for further update.

Note: We can create a ticket to update all the entries having "Hard-Coded" Versions with a Singleton Entry in the Main File.

Please add link to branch.

Hi Professor,

You can find the Pull Request by following the link below:

https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/690/igbf-1703-central-version-control/diff

Branch Commit :

https://bitbucket.org/sshanbh1/sameer-igb/commits/13d8f4244c2840c35e8cdcdd69076e4297ac4132?at=IGBF-1703-ChangeToCentralVersionControl

Please request one of the other developers to download the installer from your branch onto their machine and run it. Select Help > Console to check for any new exceptions. (Can compare to master branch installer from the team repository to check that they are new or not)

(Have them move the issue to "Reviewing")

Before merging to master, we want to make sure
1) Branch can build (it does indeed build
2) Version built from the branch is working as expected.

Main vulnerability here is that the OSGi wiring may have been inadvertently disrupted. If that has happened, there could be some error messages printed to the console upon startup.

Have them make a note here (add a comment) what they find. If it looks good, have them move it back to "Pull Request Submitted"

I checked it by running both versions of the app on my system, the console output seems to be the same (Just different timestamps). Waiting for someone to confirm the same.

That's probably sufficient testing – I will merge now!

Merged to master.