Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1720

Remove "cy" prefix from variables in project

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Many places in the code contain variables with "cy" prefix.
      Remove these.

      Example,

      • Change "cy_app" to just "app"

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1388 [ 17463 ]
            svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            Hide
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            PHASE 1 Branch: https://bitbucket.org/svallapu/appstore/branch/IGBF-1720

            I will be doing this ticket in two phases.

            Changes made:
            1.Changed 'cy-' to ''
            2. Changed 'cy_' to ''
            3. Changed '2x' to 'twox'
            4. Changed 'cy2x' to 'twox'

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - PHASE 1 Branch: https://bitbucket.org/svallapu/appstore/branch/IGBF-1720 I will be doing this ticket in two phases. Changes made: 1.Changed 'cy-' to '' 2. Changed 'cy_' to '' 3. Changed '2x' to 'twox' 4. Changed 'cy2x' to 'twox'
            Hide
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            Pull request submitted [~aloraine]

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Pull request submitted [~aloraine]
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Needs Testing [ 10002 ]
            ann.loraine Ann Loraine made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged to master.

            Show
            ann.loraine Ann Loraine added a comment - Merged to master.
            Hide
            ann.loraine Ann Loraine added a comment -

            Probably we will remove "twox" prefix - I think this may refer to Cytoscape version 2 apps only. These were pluggable apps implemented before the Cytoscape project moved to OSGi framework.

            Show
            ann.loraine Ann Loraine added a comment - Probably we will remove "twox" prefix - I think this may refer to Cytoscape version 2 apps only. These were pluggable apps implemented before the Cytoscape project moved to OSGi framework.
            Hide
            ann.loraine Ann Loraine added a comment -

            Deployed to testappstore.bioviz.org and restarted apache server.

            Show
            ann.loraine Ann Loraine added a comment - Deployed to testappstore.bioviz.org and restarted apache server.
            Hide
            ann.loraine Ann Loraine added a comment -

            Looks like there is a server error.

            Show
            ann.loraine Ann Loraine added a comment - Looks like there is a server error.
            ann.loraine Ann Loraine made changes -
            Status Needs Testing [ 10002 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            Hide
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - - edited

            Now, everything is working as expected.

            AppStore Refresh Process: [~aloraine]

            Steps:

            -->Because we changed variables names, we have to delete migration files.

            rm /var/www/vhosts/appstore/apps/migrations/0001_initial.py
            rm /var/www/vhosts/appstore/download/migrations/0001_initial.py
            rm /var/www/vhosts/appstore/submit_app/migrations/0001_initial.py

            -->Remove content in the database by removing the file

            rm dbsqlite3(make backup)

            --> start virtual environment

            source /var/www/vhosts/appstore/venv/appstore/bin/activate

            --> load tables and load data

            python manage.py makemigrations
            python manage.py migrate
            python manage.py loaddata appsDB.json
            python manage.py rebuild_index

            --> Give write permissions to newly created dbsqlite3 file

            sudo su
            chmod 664 /var/www/vhosts/appstore/db.sqlite3
            chown :www-data /var/www/vhosts/appstore/db.sqlite3
            chown :www-data /var/www/vhosts/appstore

            --> Give write permissions to newly created whoosh_index file

            sudo chown -R www-data:www-data whoosh_index

            --> Restart Apache

            sudo service apache2 restart

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - - edited Now, everything is working as expected. AppStore Refresh Process: [~aloraine] Steps: -->Because we changed variables names, we have to delete migration files. rm /var/www/vhosts/appstore/apps/migrations/0001_initial.py rm /var/www/vhosts/appstore/download/migrations/0001_initial.py rm /var/www/vhosts/appstore/submit_app/migrations/0001_initial.py -->Remove content in the database by removing the file rm dbsqlite3(make backup) --> start virtual environment source /var/www/vhosts/appstore/venv/appstore/bin/activate --> load tables and load data python manage.py makemigrations python manage.py migrate python manage.py loaddata appsDB.json python manage.py rebuild_index --> Give write permissions to newly created dbsqlite3 file sudo su chmod 664 /var/www/vhosts/appstore/db.sqlite3 chown :www-data /var/www/vhosts/appstore/db.sqlite3 chown :www-data /var/www/vhosts/appstore --> Give write permissions to newly created whoosh_index file sudo chown -R www-data:www-data whoosh_index --> Restart Apache sudo service apache2 restart
            Hide
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            Branch for Phase2 : https://bitbucket.org/svallapu/appstore/branch/IGBF-1720-Phase2

            Pull request submitted

            [~aloraine]

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Branch for Phase2 : https://bitbucket.org/svallapu/appstore/branch/IGBF-1720-Phase2 Pull request submitted [~aloraine]
            svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
            Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
            svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            Hide
            ann.loraine Ann Loraine added a comment -

            New pull request has some empty files added - names like "load" and "Give"

            Show
            ann.loraine Ann Loraine added a comment - New pull request has some empty files added - names like "load" and "Give"
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] In Progress [ 3 ]
            ann.loraine Ann Loraine made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
            Status In Progress [ 3 ] Pull Request Submitted [ 10101 ]
            Hide
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

            Removed empty files and resubmitted pull request. [~aloraine]

            Show
            svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - Removed empty files and resubmitted pull request. [~aloraine]
            svallapu Sai Charan Reddy Vallapureddy (Inactive) made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Phase2 merged to master.

            Show
            ann.loraine Ann Loraine added a comment - Phase2 merged to master.
            Hide
            ann.loraine Ann Loraine added a comment -

            Phase2 deployed on testappstore.bioviz.org.
            Links to all App logos except protannot are not working. Looks like a string got appended to the image file name in the links to the logos.
            For example, on the top page, this is now the link to "Merge Annotations" App:

            • /media/logo_2019-MergAnnot-V4_b8n0PIH.png
              The physical file is:
            • logo_2019-MergAnnot-V4.png
            Show
            ann.loraine Ann Loraine added a comment - Phase2 deployed on testappstore.bioviz.org. Links to all App logos except protannot are not working. Looks like a string got appended to the image file name in the links to the logos. For example, on the top page, this is now the link to "Merge Annotations" App: /media/logo_2019-MergAnnot-V4_b8n0PIH.png The physical file is: logo_2019-MergAnnot-V4.png
            ann.loraine Ann Loraine made changes -
            Assignee Sai Charan Reddy Vallapureddy [ svallapu ]
            ann.loraine Ann Loraine made changes -
            Status Needs Testing [ 10002 ] Open [ 1 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 7 [ 66 ] Summer 2019 Sprint 7, Summer 2019 Sprint 8 [ 66, 67 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment -

            Completed?

            Show
            ann.loraine Ann Loraine added a comment - Completed?
            ann.loraine Ann Loraine made changes -
            Resolution Done [ 10000 ]
            Status Open [ 1 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-1769 [ IGBF-1769 ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18442 ] Fall 2019 Workflow Update [ 20155 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 20155 ] Revised Fall 2019 Workflow Update [ 22291 ]

              People

              • Assignee:
                svallapu Sai Charan Reddy Vallapureddy (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: