Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1736

Don't show zero-count tags on top page

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Don't show zero-count tags on top page of App Store

        Attachments

          Activity

          Hide
          prutha Prutha Kulkarni (Inactive) added a comment -

          Code changes are available at:
          https://bitbucket.org/lorainelab/appstore/pull-requests/40/igbf-1736-dont-display-zero-count-tags-on/diff
          Prof. Loraine could you please merge the pull request to the master?

          Show
          prutha Prutha Kulkarni (Inactive) added a comment - Code changes are available at: https://bitbucket.org/lorainelab/appstore/pull-requests/40/igbf-1736-dont-display-zero-count-tags-on/diff Prof. Loraine could you please merge the pull request to the master?
          Hide
          prutha Prutha Kulkarni (Inactive) added a comment -

          link to the changed file in my app store fork is given below:
          https://bitbucket.org/pkulka10/prutha_appstore/src/IGBF-1736/apps/templates/nav_panel.html
          Could you please review the code again?

          Show
          prutha Prutha Kulkarni (Inactive) added a comment - link to the changed file in my app store fork is given below: https://bitbucket.org/pkulka10/prutha_appstore/src/IGBF-1736/apps/templates/nav_panel.html Could you please review the code again?
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Prutha Kulkarni The Code Seems to be fine.

          Working as expected, can be moved to Needs Testing.

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Prutha Kulkarni The Code Seems to be fine. Working as expected, can be moved to Needs Testing.
          Hide
          ann.loraine Ann Loraine added a comment -

          To do functional review, you can add Prutha's fork to your local as another remote repository. Then, you can get the changes from her remote, feature branch as a "tracking branch" and deploy them locally for testing. Take a few minutes to learn this new workflow if you're not already familiar with it. It's a bit tricky, however. When I do this, I sometimes accidentally merge the other developers branch into my local clone's master branch.

          Show
          ann.loraine Ann Loraine added a comment - To do functional review, you can add Prutha's fork to your local as another remote repository. Then, you can get the changes from her remote, feature branch as a "tracking branch" and deploy them locally for testing. Take a few minutes to learn this new workflow if you're not already familiar with it. It's a bit tricky, however. When I do this, I sometimes accidentally merge the other developers branch into my local clone's master branch.
          Hide
          ann.loraine Ann Loraine added a comment -

          For first level review, also please briefly say how you did the testing.

          Show
          ann.loraine Ann Loraine added a comment - For first level review, also please briefly say how you did the testing.
          Hide
          ann.loraine Ann Loraine added a comment -

          Please fix:
          Next step in the workflow after First Level Review is moving the ticket into "Ready for Pull Request".
          At that point, you re-assign to the original developer, who then submits a pull request.
          When the pull request is submitted, the person who submitted the pull request moves it to the next lane in the board.
          After the pull request gets merged, the person who merges the pull request moves it into the Needs Testing lane.

          Show
          ann.loraine Ann Loraine added a comment - Please fix: Next step in the workflow after First Level Review is moving the ticket into "Ready for Pull Request". At that point, you re-assign to the original developer, who then submits a pull request. When the pull request is submitted, the person who submitted the pull request moves it to the next lane in the board. After the pull request gets merged, the person who merges the pull request moves it into the Needs Testing lane.
          Hide
          prutha Prutha Kulkarni (Inactive) added a comment -

          Pull request submitted for the ticket.
          Also, the code changes are present at:
          https://bitbucket.org/lorainelab/appstore/pull-requests/41/igbf-1736-dont-display-zero-count-tags-on/diff

          Show
          prutha Prutha Kulkarni (Inactive) added a comment - Pull request submitted for the ticket. Also, the code changes are present at: https://bitbucket.org/lorainelab/appstore/pull-requests/41/igbf-1736-dont-display-zero-count-tags-on/diff
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged pull request and deployed on testappstore.bioviz.org.
          There is a bug: Categories are now all listed with one App only.
          Returning to Prutha to investigate.

          Show
          ann.loraine Ann Loraine added a comment - Merged pull request and deployed on testappstore.bioviz.org. There is a bug: Categories are now all listed with one App only. Returning to Prutha to investigate.
          Hide
          ann.loraine Ann Loraine added a comment -

          I investigated further. I think this is a correct – none of the categories is currently assigned to more than 1 App.
          The site is behaving as expected and so I am moving this to Closed.

          Show
          ann.loraine Ann Loraine added a comment - I investigated further. I think this is a correct – none of the categories is currently assigned to more than 1 App. The site is behaving as expected and so I am moving this to Closed.

            People

            • Assignee:
              prutha Prutha Kulkarni (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: