Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1798

Check: Does source code get packaged with genoviz sdk bundle?

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Unpack genoviz sdk jar file to see if source code is included.
      If yes, make sure Eclipse, NetBeans, IntelliJ (commonly-used IDEs used by Java programmers) can display the source code after importing the jar file.

      Tip for assessing usability of the library in an IDE:

      If you're not a typical user of the IDEs, find someone who is, and ask them to load the library into a project while you watch. Encourage them go through their normal process so that you can understand a typical workflow in the IDE's user community. They don't need to explain anything to you - it's optional. Try to stay quie – many things in programming are done silently, without talking.

      Make a note of what you find out regarding the library and its usability in projects.

        Attachments

          Issue Links

            Activity

            ann.loraine Ann Loraine created issue -
            ann.loraine Ann Loraine made changes -
            Field Original Value New Value
            Epic Link IGBF-1531 [ 17617 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Sprint Summer 2019 Sprint 9 [ 68 ] Summer 2019 Sprint 8 [ 67 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            noor91zahara Noor Zahara (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - https://bitbucket.org/nzahara/genoviz-sdk-local/branch/IGBF-1798#diff Code Changes can be found in the above link
            Hide
            ann.loraine Ann Loraine added a comment -

            Please download released Genoviz SDK artifact from https://nexus.bioviz.org and unpack it.
            Is the source code in the current jar?
            Attach a screen shot showing the source code if yes.

            Show
            ann.loraine Ann Loraine added a comment - Please download released Genoviz SDK artifact from https://nexus.bioviz.org and unpack it. Is the source code in the current jar? Attach a screen shot showing the source code if yes.
            ann.loraine Ann Loraine made changes -
            Status In Progress [ 3 ] Open [ 1 ]
            ann.loraine Ann Loraine made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Mistakenly moved from In Progress to Open. Moved it back.

            Show
            ann.loraine Ann Loraine added a comment - Mistakenly moved from In Progress to Open. Moved it back.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            I tried unpacking genoviz 1.1.8 jar downloaded using https://nexus.bioviz.org/#browse/browse:maven-releases:com%2Faffymetrix%2Fgenoviz%2F1.1.8%2Fgenoviz-1.1.8.jar and could find just the .class files. Source code was not included.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - I tried unpacking genoviz 1.1.8 jar downloaded using https://nexus.bioviz.org/#browse/browse:maven-releases:com%2Faffymetrix%2Fgenoviz%2F1.1.8%2Fgenoviz-1.1.8.jar and could find just the .class files. Source code was not included.
            noor91zahara Noor Zahara (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] Ready for Pull Request [ 10304 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Needs 1st Level Review [ 10005 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            To enable review & testing:

            • Set up bitbucket pipeline on your fork to build genoviz jars - so that reviewer can download and unpack them
            Show
            ann.loraine Ann Loraine added a comment - To enable review & testing: Set up bitbucket pipeline on your fork to build genoviz jars - so that reviewer can download and unpack them
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-1800 [ IGBF-1800 ]
            ann.loraine Ann Loraine made changes -
            Link This issue relates to IGBF-1216 [ IGBF-1216 ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] Open [ 1 ]
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment - - edited

            [~aloraine]
            I have set up pipeline on my fork.

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited [~aloraine] I have set up pipeline on my fork.
            noor91zahara Noor Zahara (Inactive) made changes -
            Status Open [ 1 ] Needs 1st Level Review [ 10005 ]
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Great!

            Can someone on CyVerse team review to give a fresh perspective?

            As always, reviewer should self-assign and move to next column to let us know the ticket is under review.

            Chaitanya Kintali Srishti Tiwari Pawan Bole Karthik Raveendran

            Show
            ann.loraine Ann Loraine added a comment - - edited Great! Can someone on CyVerse team review to give a fresh perspective? As always, reviewer should self-assign and move to next column to let us know the ticket is under review. Chaitanya Kintali Srishti Tiwari Pawan Bole Karthik Raveendran
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Assignee Noor Zahara [ noor91zahara ] Chaitanya Kintali [ chaitanya ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] Testing In Progress [ 10003 ]
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -

            [~aloraine] Noor Zahara

            I have downloaded and extracted the jar and was able too see the source code ( .java files)
            I have imported the jar files from netbeans and could see the source code.
            Is there any thing other place/ component i need to test for this ticket. Please let me know

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - [~aloraine] Noor Zahara I have downloaded and extracted the jar and was able too see the source code ( .java files) I have imported the jar files from netbeans and could see the source code. Is there any thing other place/ component i need to test for this ticket. Please let me know
            Hide
            ann.loraine Ann Loraine added a comment -

            Normally it's important for someone other than the developer to do these steps – it helps catch unforeseen problems!

            Attention future testers who pick this up:

            • Please repeat above steps described in previous comment by NZ. Do same for Eclipse, Netbeans, and IntelliJ (most popular Java IDEs) to ensure we have packaged the Genoviz SDK correctly for use by developers
            Show
            ann.loraine Ann Loraine added a comment - Normally it's important for someone other than the developer to do these steps – it helps catch unforeseen problems! Attention future testers who pick this up: Please repeat above steps described in previous comment by NZ. Do same for Eclipse, Netbeans, and IntelliJ (most popular Java IDEs) to ensure we have packaged the Genoviz SDK correctly for use by developers
            ann.loraine Ann Loraine made changes -
            Status Testing In Progress [ 10003 ] Ready for Pull Request [ 10304 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Noor - please add link to Genoviz SDK bitbucket repository for testers.
            Testers: Use the "downloads" link to get the master branch jar after NZ's pull request is merged.

            Show
            ann.loraine Ann Loraine added a comment - Noor - please add link to Genoviz SDK bitbucket repository for testers. Testers: Use the "downloads" link to get the master branch jar after NZ's pull request is merged.
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - Repo Link : https://bitbucket.org/nzahara/genoviz-sdk-local/src/master/ [~aloraine] Pull Request : https://bitbucket.org/lorainelab/genoviz-sdk/pull-requests/13/igbf-1798/diff
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Assignee Chaitanya Kintali [ chaitanya ] Ann Loraine [ aloraine ]
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -

            [~aloraine]

            My bad. I was not aware that the changes have not been merged yet. I was testing the pipeline build files of the branch IGBF-1798. Can you please review the pull request and merge so that i can get the files and test directly from the master branch.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - [~aloraine] My bad. I was not aware that the changes have not been merged yet. I was testing the pipeline build files of the branch IGBF-1798 . Can you please review the pull request and merge so that i can get the files and test directly from the master branch.
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Needs Testing [ 10002 ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Assignee Ann Loraine [ aloraine ] Chaitanya Kintali [ chaitanya ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Status Needs Testing [ 10002 ] Testing In Progress [ 10003 ]
            Hide
            chaitanya Chaitanya Kintali (Inactive) added a comment -

            Steps to test:
            ----------------------------
            1) download the .jar file from the master branch pipeline build.
            2) unpacked it and checked the source files. I am able to see the java files and can see the implementation of the inner methods.
            3) Imported the .jar file in Netbeans, IntelliJ, and Eclipse and checked, i can see the .java files imported. Please find the screenshots as an attachment.

            Show
            chaitanya Chaitanya Kintali (Inactive) added a comment - Steps to test: ---------------------------- 1) download the .jar file from the master branch pipeline build. 2) unpacked it and checked the source files. I am able to see the java files and can see the implementation of the inner methods. 3) Imported the .jar file in Netbeans, IntelliJ, and Eclipse and checked, i can see the .java files imported. Please find the screenshots as an attachment.
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Attachment IntelliJ_unpack.PNG [ 14339 ]
            Attachment Netbeans_unpack.PNG [ 14340 ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Testing In Progress [ 10003 ] Closed [ 6 ]
            ann.loraine Ann Loraine made changes -
            Status Closed [ 6 ] Closed [ 6 ]
            chaitanya Chaitanya Kintali (Inactive) made changes -
            Assignee Chaitanya Kintali [ chaitanya ] Noor Zahara [ noor91zahara ]
            ann.loraine Ann Loraine made changes -
            Workflow Loraine Lab Workflow [ 18520 ] Fall 2019 Workflow Update [ 20214 ]
            ann.loraine Ann Loraine made changes -
            Workflow Fall 2019 Workflow Update [ 20214 ] Revised Fall 2019 Workflow Update [ 22351 ]
            noor91zahara Noor Zahara (Inactive) made changes -
            Link This issue is blocked by IGBF-2235 [ IGBF-2235 ]

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: