Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1897

Fix Appstore confirmation email content related issues

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          1
        • Sprint:
          Summer 2019 Sprint 10, Summer 2019 Sprint 11

          Description

          1. The Email subject is generic: "IGB App Store - Submission Done!". We could make it more informative by adding the name of the submitted app in the email, something like this: "IGB App Store - <App Presentation Name> Submission Done!"

          2. After uploading a newer version of the previously uploaded app, the email received after the app submission says it needs approval (which is not the case). We will need to add a check to see whether it is a new app or an updated app, and will need to change the content of the email accordingly.

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-1896 Upload the apps with symbolic name to the s3 bucket

              • Major - Major loss of function.
              • Closed

              Task - A task that needs to be done. IGBF-1860 Test App Store workflow

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment - - edited

                As discussed with the professor, we will still need an approval for updated apps so the email content is not being changed for now.
                In future, we might have to add a page containing details of the jars users have uploaded so that they can delete the jars that they don't need or have uploaded by mistake.

                When multiple versions of the same is being submitted, jar name is changed under pending apps and due to which repostory.xml file will not get generated.

                Fix : Get the jar name from the DB while generating the xml file.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - - edited As discussed with the professor, we will still need an approval for updated apps so the email content is not being changed for now. In future, we might have to add a page containing details of the jars users have uploaded so that they can delete the jars that they don't need or have uploaded by mistake. When multiple versions of the same is being submitted, jar name is changed under pending apps and due to which repostory.xml file will not get generated. Fix : Get the jar name from the DB while generating the xml file.
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Sameer Shanbhag / [~aloraine]

                Kindly review the code
                https://bitbucket.org/nzahara/appstore-local/commits/b4843744a63e4aa7b27bab8acdd136c3b9d20baf#chg-submit_app/models.py

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Sameer Shanbhag / [~aloraine] Kindly review the code https://bitbucket.org/nzahara/appstore-local/commits/b4843744a63e4aa7b27bab8acdd136c3b9d20baf#chg-submit_app/models.py
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Noor Zahara

                Can you add a check where a new version is being submitted such that it gives the user a Different Email?

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Noor Zahara Can you add a check where a new version is being submitted such that it gives the user a Different Email?
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Sameer Shanbhag - I have made the changes.

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Sameer Shanbhag - I have made the changes.
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                The code looks fine. Working as expected can be Moved to Ready for PR

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - The code looks fine. Working as expected can be Moved to Ready for PR
                Hide
                Permalink
                noor91zahara Noor Zahara (Inactive) added a comment -

                Pull request submitted
                https://bitbucket.org/lorainelab/appstore/pull-requests/75/igbf-1897/diff

                Show
                noor91zahara Noor Zahara (Inactive) added a comment - Pull request submitted https://bitbucket.org/lorainelab/appstore/pull-requests/75/igbf-1897/diff
                Hide
                Permalink
                sameer Sameer Shanbhag (Inactive) added a comment -

                Requested changes are pushed to Noor Zahara's Branch, Changes can be found here:

                https://bitbucket.org/lorainelab/appstore/pull-requests/75/igbf-1897/diff

                Please review and let me know if there are any more changes needed.

                Show
                sameer Sameer Shanbhag (Inactive) added a comment - Requested changes are pushed to Noor Zahara 's Branch, Changes can be found here: https://bitbucket.org/lorainelab/appstore/pull-requests/75/igbf-1897/diff Please review and let me know if there are any more changes needed.
                Hide
                Permalink
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

                It is working as expected. Moving it to done.

                Show
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - It is working as expected. Moving it to done.

                  People

                  • Assignee:
                    noor91zahara Noor Zahara (Inactive)
                    Reporter:
                    stiwari8 Srishti Tiwari (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: