Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Sprint:Summer 2019 Sprint 10, Summer 2019 Sprint 11
Description
1. The Email subject is generic: "IGB App Store - Submission Done!". We could make it more informative by adding the name of the submitted app in the email, something like this: "IGB App Store - <App Presentation Name> Submission Done!"
2. After uploading a newer version of the previously uploaded app, the email received after the app submission says it needs approval (which is not the case). We will need to add a check to see whether it is a new app or an updated app, and will need to change the content of the email accordingly.
Attachments
Issue Links
Activity
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Sprint | Summer 2019 Sprint 10 [ 69 ] | Summer 2019 Sprint 10, Summer 2019 Sprint 11 [ 69, 70 ] |
| Rank | Ranked higher |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Sameer Shanbhag / [~aloraine]
Kindly review the code
https://bitbucket.org/nzahara/appstore-local/commits/b4843744a63e4aa7b27bab8acdd136c3b9d20baf#chg-submit_app/models.py
Can you add a check where a new version is being submitted such that it gives the user a Different Email?
| Status | Needs 1st Level Review [ 10005 ] | In Progress [ 3 ] |
Sameer Shanbhag - I have made the changes.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
The code looks fine. Working as expected can be Moved to Ready for PR
| Status | Needs 1st Level Review [ 10005 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Pull request submitted
https://bitbucket.org/lorainelab/appstore/pull-requests/75/igbf-1897/diff
Requested changes are pushed to Noor Zahara's Branch, Changes can be found here:
https://bitbucket.org/lorainelab/appstore/pull-requests/75/igbf-1897/diff
Please review and let me know if there are any more changes needed.
| Status | Pull Request Submitted [ 10101 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | Needs Testing [ 10002 ] |
It is working as expected. Moving it to done.
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Status | Needs Testing [ 10002 ] | Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] | Noor Zahara [ noor91zahara ] |
| Workflow | Loraine Lab Workflow [ 18620 ] | Fall 2019 Workflow Update [ 20282 ] |
| Workflow | Fall 2019 Workflow Update [ 20282 ] | Revised Fall 2019 Workflow Update [ 22430 ] |
As discussed with the professor, we will still need an approval for updated apps so the email content is not being changed for now.
In future, we might have to add a page containing details of the jars users have uploaded so that they can delete the jars that they don't need or have uploaded by mistake.
When multiple versions of the same is being submitted, jar name is changed under pending apps and due to which repostory.xml file will not get generated.
Fix : Get the jar name from the DB while generating the xml file.