Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1902

Add Edit button to Preferences > App Repositories

    Details

    • Story Points:
      2.5
    • Sprint:
      Summer 2019 Sprint 11, Summer 2019 Sprint 12, Fall 2019 Sprint 1, Fall 2019 Sprint 2, Fall 2019 Sprint 3

      Description

      Sometimes users enter the URL of an App Repository incorrectly. Currently, if they want to edit it, they can't – instead, they have to remove it and then re-enter it.

      Let's enable users to simply click in a cell and edit a value. Note that another option might to also add an "Edit" button that would maybe open a new pop-up identical to what is seen when a user clicks "Add" but with the current values filled in.

        Attachments

          Issue Links

            Activity

            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            I see that Professor Loraine has commented asking about GUI builder. It seems that for adding Edit button, we may have to use a GUI builder. I realized this while working on https://jira.transvar.org/browse/IGBF-2012 - Improve Edit App repository function. The code changes done by Noor Zahara almost are the same with additional code for https://jira.transvar.org/browse/IGBF-2012.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - I see that Professor Loraine has commented asking about GUI builder. It seems that for adding Edit button, we may have to use a GUI builder. I realized this while working on https://jira.transvar.org/browse/IGBF-2012 - Improve Edit App repository function. The code changes done by Noor Zahara almost are the same with additional code for https://jira.transvar.org/browse/IGBF-2012 .
            Hide
            ann.loraine Ann Loraine added a comment -

            Prutha Kulkarni No need to answer - I see you meant "Web browser"

            We don't need to support backslash "\" characters. Since all other functionality is working as per testing, I am moving this to "Closed".

            Show
            ann.loraine Ann Loraine added a comment - Prutha Kulkarni No need to answer - I see you meant "Web browser" We don't need to support backslash "\" characters. Since all other functionality is working as per testing, I am moving this to "Closed".
            Hide
            ann.loraine Ann Loraine added a comment -

            Prutha Kulkarni Thank you for documenting this edge case! A question: by "browser" do you mean IGB or a Web browser?

            Show
            ann.loraine Ann Loraine added a comment - Prutha Kulkarni Thank you for documenting this edge case! A question: by "browser" do you mean IGB or a Web browser?
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment - - edited

            Noor Zahara, I have tested the edit button functionality on IGB for the cases mentioned below:
            1) Editing http to https
            2) Adding a url and then removing trailing path separators
            3) Editing existing urls to incorrect paths
            4) Editing correct local folder paths to incorrect ones
            5) Removing an entry
            6) Editing the name field for any entry using Edit button
            7) Renaming any entry with the same name as that of any other entry in the table.
            Everything is working fine.
            I have one doubt. When I replaced all of the forward slashes in the URL with backward slashes then it is showing me "invalid url" message even when the location can be easily accessed with the backward slashes using the browser.
            I am not sure if that should work with the backward slashes or it should prompt a "invalid url" message.
            URL used:
            https:\\bitbucket.org\skulka2710\get-average-score\downloads\
            [~aloraine] - could you please let me know if that should be handled in the code?
            If there is no need to handle this case then I will move it forward to DONE.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - - edited Noor Zahara , I have tested the edit button functionality on IGB for the cases mentioned below: 1) Editing http to https 2) Adding a url and then removing trailing path separators 3) Editing existing urls to incorrect paths 4) Editing correct local folder paths to incorrect ones 5) Removing an entry 6) Editing the name field for any entry using Edit button 7) Renaming any entry with the same name as that of any other entry in the table. Everything is working fine. I have one doubt. When I replaced all of the forward slashes in the URL with backward slashes then it is showing me "invalid url" message even when the location can be easily accessed with the backward slashes using the browser. I am not sure if that should work with the backward slashes or it should prompt a "invalid url" message. URL used: https:\\bitbucket.org\skulka2710\get-average-score\downloads\ [~aloraine] - could you please let me know if that should be handled in the code? If there is no need to handle this case then I will move it forward to DONE.
            Hide
            ann.loraine Ann Loraine added a comment -

            Sorry Prutha Kulkarni and Noor Zahara I did not get back to you in a timely fashion regarding latest comment.
            Let's proceed with current fix as it has passed code and functional review.
            Moving to "ready for pull request".

            Show
            ann.loraine Ann Loraine added a comment - Sorry Prutha Kulkarni and Noor Zahara I did not get back to you in a timely fashion regarding latest comment. Let's proceed with current fix as it has passed code and functional review. Moving to "ready for pull request".

              People

              • Assignee:
                noor91zahara Noor Zahara (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: