Code change are as below

https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1902#diff

The "Edit" functionality is working fine. But the "Remove" functionality is not working as expected. Kindly look into it. Moving the ticket to To-Do and assigning back to Noor.

Shamika Gajanan Kulkarni I have fixed that.

Both the functionalities are working perfectly fine as expected. Also, for "Edit" functionality, if the new value is not a URL, the changes are not updated. Kindly go ahead and submit a pull request for the same.

I observed the following two points:
1) When I am trying to edit the existing repository URL, it still displays the app in spite of the URL being incorrect. It gives an error in the console saying "repository.xml cannot be found". My concern is if it cannot find the repository.xml file, the app does not display, thereby indicating something is improper, which may hint the user that URL is incorrect. But, right now, it displays the app even though it cannot find the file.
2) Also, if I remove one repository URL, the name for next URL gets automatically edited and takes the value of the Name of repository which has been deleted.

Kindly check these two observations and let me know if I have misunderstood something.
Moving in To-do as of now.

I reverted the pull request.
Thank you Shamika Gajanan Kulkarni and Noor Zahara for your work on this!
However I think this feature is too risky - and costly - to implement.

Attached is the screen shot of the Edit button pop up display.

Shamika Gajanan Kulkarni [~aloraine] - Kindly test the new fix made for the bug raised and let me know if you find any issues.

https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1902-2#diff

All the scenarios are working fine now, except for one:
1) if I remove one repository URL, the name for next URL gets automatically edited and takes the value of the Name of repository which has been deleted.
Me and Noor suspect this issue has been existing. I am attaching a new ticket for the same.
Rest all bugs are fixed. Thank you for looking into this. Kindly submit a pull request for the same.

Please rebase on master and move to first level review.

I have merged the latest changes with this branch

The following test cases were examined:
1) Editing http to https
2) Adding a url and then removing trailing path separators
3) Editing existing urls to incorrect paths
4) Editing correct local folder paths to incorrect ones
5) Removing an entry
6) Editing the name field for any entry using Edit button
All the above test cases are working fine. If I happen to miss something out, kindly check for those test cases and update the ticket accordingly.

I have tested above scenario as well as the scenario in which Shamika Gajanan Kulkarni was facing some issues like when we try to edit 3rd row repository's name then even after changing it, it was retaining old row data. Everything's working as expected.
Just a suggestion, For some of the URLs, it was taking some time to verify if it's available or not( might be the case with my machine only and not sure about other machines) and the message "invalid URL" was appearing after some time. User might get a feeling that the system is in hanged state and might try to hit the button many times as there is not any kind of feedback provided on the screen like a loading gif or a text indicating URL verification is in process. Is it possible to show a feedback on the screen. It's just a suggestion. Noor Zahara, you decide if its doable or not. Let me know about it or else I'll move the ticket to ready for pull request.
Thanks.

I guess it should not take time to reflect the output. It is seen immediately, it might be a case of slow internet.

The message is shown only if there is any error. So it should be fine.

Thanks for this!!!
Regarding the time issue:
This happens (??) because IGB does not realize the server is no good until some time has passed - it is waiting until it gets a reply but eventually gives up if the reply does not come.
I like your idea of giving the user some kind of visual feedback to let them know their request has been registered and IGB is working on it. If we do that, the wait time, which is unavoidable, will be less stressful.

Prutha Kulkarni Can you show me the flow today at your desk?

Sure Prof. [~aloraine]. Let me know when you're free.
Noor Zahara, I will check if it was due to some network problem.
Thanks.

The branch contains a new file: EditBundleRepositoryFrame.java

It contains this text:

/**
+ * This method is called from within the constructor to initialize the form.
+ * WARNING: Do NOT modify this code. The content of this method is always
+ * regenerated by the Form Editor.
+ */
+ @SuppressWarnings("unchecked")
+ // <editor-fold defaultstate="collapsed" desc="Generated Code">
+ private void initComponents() {

This looks a file that was created using the NetBeans GUI Builder. Is that how it was made?

Note that the tabbed panels and other GUI components in IGB were made using the GUI Builder. To edit the GUI parts, you need to use the GUI builder. If instead you make changes by hand, you could break our ability to use GUI builder in future. However, I'm not sure if this matters any more because I'm not sure if GUI builder is still available in the latest versions of Netbeans or not.

Please investigate. Also, please make a note of where the file came from. For example, if was copied from somewhere else in the code base, you should make a note of it at the top of the file.

The file was not made using the GUI builder. Just the initComponents() function was created by the GUI Builder .

This file is created similar to AddBundleRepositoryFrame.java.

I have mentioned the same in the file.

OK I see it now! Thanks!

It says:

"+/*
+ * To change this license header, choose License Headers in Project Properties.
+ * To change this template file, choose Tools | Templates
+ * and open the template in the editor.
+ */
"
Can you add more info to make it more clear that you mean Netbeans, and which version?

I have added the netbeans IDE version that I have used.

Prutha Kulkarni can you do an additional code review-type test? (Just to be sure the next person who works on this will know what to do

Following Noor's instructions in the file, please open her branch and try to make a very minor edit – maybe just change the wording a bit. Then check that you can build and run the application.

(Idea here is for someone totally new to try making a minor change just to be sure they would be able to do it. Shamika Gajanan Kulkarni could also do it – whatever is most convenient for you is fine!)

Sure Prof. [~aloraine]. I'll provide an update on this asap.

[~aloraine], I have cloned Noor's fork on my system and checked out her branch to make a few changes.
I was able to build the igb successfully. Should I submit it to Ready for Pull Request or we are gonna make some more changes related to the visual feedback about which we had a discussion in the morning?
Thanks.

Sorry Prutha Kulkarni and Noor Zahara I did not get back to you in a timely fashion regarding latest comment.
Let's proceed with current fix as it has passed code and functional review.
Moving to "ready for pull request".

Noor Zahara, I have tested the edit button functionality on IGB for the cases mentioned below:
1) Editing http to https
2) Adding a url and then removing trailing path separators
3) Editing existing urls to incorrect paths
4) Editing correct local folder paths to incorrect ones
5) Removing an entry
6) Editing the name field for any entry using Edit button
7) Renaming any entry with the same name as that of any other entry in the table.
Everything is working fine.
I have one doubt. When I replaced all of the forward slashes in the URL with backward slashes then it is showing me "invalid url" message even when the location can be easily accessed with the backward slashes using the browser.
I am not sure if that should work with the backward slashes or it should prompt a "invalid url" message.
URL used:
https:\\bitbucket.org\skulka2710\get-average-score\downloads\
[~aloraine] - could you please let me know if that should be handled in the code?
If there is no need to handle this case then I will move it forward to DONE.

Prutha Kulkarni Thank you for documenting this edge case! A question: by "browser" do you mean IGB or a Web browser?

Prutha Kulkarni No need to answer - I see you meant "Web browser"

We don't need to support backslash "\" characters. Since all other functionality is working as per testing, I am moving this to "Closed".

I see that Professor Loraine has commented asking about GUI builder. It seems that for adding Edit button, we may have to use a GUI builder. I realized this while working on https://jira.transvar.org/browse/IGBF-2012 - Improve Edit App repository function. The code changes done by Noor Zahara almost are the same with additional code for https://jira.transvar.org/browse/IGBF-2012.