Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1939

Show favicon.ico even when a Quickload site is local

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      IGB can display a favicon.ico file in place of a folder icon in the Available Data section of the Data Access tab for Quickload sites.

      However, this is currently only working when the Quickload site is being served remotely. If the site is local - on the user's local computer - the favicon.ico is not shown.

      (See attached.)

      Let's fix this so that if a Quickload site contains a favicon file at the top level of a Quickload site, it will be shown even when the site is a local folder.

        Attachments

          Activity

          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Code changes : https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1939#diff

          Steps to Test -

          1. Download a sample genome data having a favicon.ico file from igb quickload .
          2. Add it is a new local quickload site
          3. Favicon.ico should be visible once loaded instead of a local folder icon under Available Data Column.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Code changes : https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-1939#diff Steps to Test - 1. Download a sample genome data having a favicon.ico file from igb quickload . 2. Add it is a new local quickload site 3. Favicon.ico should be visible once loaded instead of a local folder icon under Available Data Column.
          Hide
          ann.loraine Ann Loraine added a comment -

          Also, please confirm remote quickload favicon.ico images are still shown.

          Show
          ann.loraine Ann Loraine added a comment - Also, please confirm remote quickload favicon.ico images are still shown.
          Hide
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

          The code changes are fine. The Favicon.ico is visible and the remote quickload images are also shown. Kindly submit a pull request for the same.

          Show
          shamika Shamika Gajanan Kulkarni (Inactive) added a comment - The code changes are fine. The Favicon.ico is visible and the remote quickload images are also shown. Kindly submit a pull request for the same.
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          Working as expected.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - Working as expected.

            People

            • Assignee:
              noor91zahara Noor Zahara (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: