1. If a user with administrative privileges uses the "Pending Apps" menu on the front page to "decline" an app, does the jar file gets deleted? Also, should it be deleted?
=> Yes, When the app is declined from the "Front (UI) Pending Apps Menu" the Jar gets deleted from the S3 Bucket.

2. Maybe we should not try to support the use case of an admin user using the Admin panel to delete a pending App. The "Admin" panel is designed to provide an interface to the database only. Asking it to also "know" about uploaded files may be asking too much.
=> By Default, Admin can delete an App or App Pending or any other Database entry from the Django Admin Panel (Feature provided by Django)
When the Admin tries to delete the App from Admin Panel (by Mistake or by Purpose), Currently the Jar is not getting removed from the S3 Bucket, Just increasing the manual effort by the S3 Admin to Purge the unnecessary Files
So to avoid that, with this update, when an Admin Deletes the App from the Admin Panel, The Jar File will be deleted automatically (Done using "post_delete" signal operator by Django), which means the Admin will not be having any extra effort what-so-ever to delete the jar file

Question for Sameer Shanbhag:

• If a user with administrative privileges uses the "Pending Apps" menu on the front page to "decline" an app, does the jar file get deleted? Also, should it be deleted?

What do you think about the following?:

• Maybe we should not try to support the use case of an admin user using the Admin panel to delete a pending App. The "Admin" panel is designed to provide an interface to the database only. Asking it to also "know" about uploaded files may be asking too much.

Testing can be done on:

https://dev-appstore-1.bioviz.org

Steps:
1. Submit an App
2. Login to Django admin
3. Navigate to App Pending
4. Find the app you uploaded
5. Check if the Release file is also present in the bucket under "pending_releases" folder
6. Delete the App From Django Admin Panel
7. Check if the Jar was deleted from the "pending_releases" folder in S3

Django Admin Login:
User: testuser
Password: 9sC5W]q[R(=5{M5R

Note:
Delete App from Admin Panel only and not from the UI

Development Update:

Changes have been Made to Support Deletion of App Pending Jar when Admin Deletes the App Pending Object from Admin Panel
Changes can be found here:
https://bitbucket.org/lorainelab/appstore/pull-requests/99/igbf-1966-add-support-to-delete-pending/diff

Testing Status:
Errors:
1. App-Pending Jar not getting deleted from S3 when Admin user deletes the application from Admin Panel
Woking:
1. When you delete a release as a user the Release File gets deleted
2. When you Reject a Pending app, the JAr gets deleted from the Bucket's Pendingapp folder
3. When you Delete an App from the Admin Panel, App object with the Release file gets deleted.

Pull Request Submitted:

https://bitbucket.org/lorainelab/appstore/pull-requests/96/igbf-1966/diff

Code is fine except for un-needed print statement - see comment.
Please remove, rebase on master, and submit PR.

Testers doing functional review, please check:

• that a pending App release jar file can be deleted

Also, tester will need to get admin user credentials from Sameer Shanbhag

Changes can be found: https://bitbucket.org/sshanbh1/sameer-appstorefork/commits/5920020911b6c3aef943183aeed2d9a3a7b5e592

1. When you delete a release as a user the Release File gets deleted
2. When you Reject a Pending app, the JAr gets deleted from the Bucket's Pendingapp folder
3. When you Delete an App from the Admin Panel, App object with the Release file gets deleted.

Testing can be done on my EC2 Instance:
https://dev-appstore-1.bioviz.org/

We need to explicitly delete the file, documentation can be found here:
https://docs.djangoproject.com/en/1.8/ref/models/fields/#django.db.models.fields.files.FieldFile.delete

I will figure out a way to enable developers to view the contents of their S3 bucket via the AWS console.

You can use the AWS command-line tools to programmatically view the contents of your S3 bucket using the same access credentials your appstore instance is using.

However, it will be easier to debug if you can view same using the AWS console.

Stay tuned...

I tested this using dev-appstore-2.

I uploaded an App file and then logged in as an "admin" user. I then deleted the corresponding entry in the "Pending Apps" section.

I then checked the S3 bucket.

The App jar file was still there.

The pending app jars are getting deleted from S3 when an admin user deletes it.