Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1966

Remove App jar file from S3 when Admin user deletes a pending App

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      Check that App .jar files are getting deleted from S3 bucket when an Admin user deletes a pending app.

        Attachments

          Activity

          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Testing Status:
          Errors:
          1. App-Pending Jar not getting deleted from S3 when Admin user deletes the application from Admin Panel
          Woking:
          1. When you delete a release as a user the Release File gets deleted
          2. When you Reject a Pending app, the JAr gets deleted from the Bucket's Pendingapp folder
          3. When you Delete an App from the Admin Panel, App object with the Release file gets deleted.

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Testing Status: Errors: 1. App-Pending Jar not getting deleted from S3 when Admin user deletes the application from Admin Panel Woking: 1. When you delete a release as a user the Release File gets deleted 2. When you Reject a Pending app, the JAr gets deleted from the Bucket's Pendingapp folder 3. When you Delete an App from the Admin Panel, App object with the Release file gets deleted.
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment - - edited

          Development Update:

          Changes have been Made to Support Deletion of App Pending Jar when Admin Deletes the App Pending Object from Admin Panel
          Changes can be found here:
          https://bitbucket.org/lorainelab/appstore/pull-requests/99/igbf-1966-add-support-to-delete-pending/diff

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - - edited Development Update: Changes have been Made to Support Deletion of App Pending Jar when Admin Deletes the App Pending Object from Admin Panel Changes can be found here: https://bitbucket.org/lorainelab/appstore/pull-requests/99/igbf-1966-add-support-to-delete-pending/diff
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment -

          Testing can be done on:

          https://dev-appstore-1.bioviz.org

          Steps:
          1. Submit an App
          2. Login to Django admin
          3. Navigate to App Pending
          4. Find the app you uploaded
          5. Check if the Release file is also present in the bucket under "pending_releases" folder
          6. Delete the App From Django Admin Panel
          7. Check if the Jar was deleted from the "pending_releases" folder in S3

          Django Admin Login:
          User: testuser
          Password: 9sC5W]q[R(=5{M5R

          Note:
          Delete App from Admin Panel only and not from the UI

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - Testing can be done on: https://dev-appstore-1.bioviz.org Steps: 1. Submit an App 2. Login to Django admin 3. Navigate to App Pending 4. Find the app you uploaded 5. Check if the Release file is also present in the bucket under "pending_releases" folder 6. Delete the App From Django Admin Panel 7. Check if the Jar was deleted from the "pending_releases" folder in S3 Django Admin Login: User: testuser Password: 9sC5W]q[R(=5{M5R Note: Delete App from Admin Panel only and not from the UI
          Hide
          ann.loraine Ann Loraine added a comment - - edited

          Question for Sameer Shanbhag:

          • If a user with administrative privileges uses the "Pending Apps" menu on the front page to "decline" an app, does the jar file get deleted? Also, should it be deleted?

          What do you think about the following?:

          • Maybe we should not try to support the use case of an admin user using the Admin panel to delete a pending App. The "Admin" panel is designed to provide an interface to the database only. Asking it to also "know" about uploaded files may be asking too much.
          Show
          ann.loraine Ann Loraine added a comment - - edited Question for Sameer Shanbhag : If a user with administrative privileges uses the "Pending Apps" menu on the front page to "decline" an app, does the jar file get deleted? Also, should it be deleted? What do you think about the following?: Maybe we should not try to support the use case of an admin user using the Admin panel to delete a pending App. The "Admin" panel is designed to provide an interface to the database only. Asking it to also "know" about uploaded files may be asking too much.
          Hide
          sameer Sameer Shanbhag (Inactive) added a comment - - edited

          1. If a user with administrative privileges uses the "Pending Apps" menu on the front page to "decline" an app, does the jar file gets deleted? Also, should it be deleted?
          => Yes, When the app is declined from the "Front (UI) Pending Apps Menu" the Jar gets deleted from the S3 Bucket.

          2. Maybe we should not try to support the use case of an admin user using the Admin panel to delete a pending App. The "Admin" panel is designed to provide an interface to the database only. Asking it to also "know" about uploaded files may be asking too much.
          => By Default, Admin can delete an App or App Pending or any other Database entry from the Django Admin Panel (Feature provided by Django)
          When the Admin tries to delete the App from Admin Panel (by Mistake or by Purpose), Currently the Jar is not getting removed from the S3 Bucket, Just increasing the manual effort by the S3 Admin to Purge the unnecessary Files
          So to avoid that, with this update, when an Admin Deletes the App from the Admin Panel, The Jar File will be deleted automatically (Done using "post_delete" signal operator by Django), which means the Admin will not be having any extra effort what-so-ever to delete the jar file

          Show
          sameer Sameer Shanbhag (Inactive) added a comment - - edited 1. If a user with administrative privileges uses the "Pending Apps" menu on the front page to "decline" an app, does the jar file gets deleted? Also, should it be deleted? => Yes, When the app is declined from the "Front (UI) Pending Apps Menu" the Jar gets deleted from the S3 Bucket. 2. Maybe we should not try to support the use case of an admin user using the Admin panel to delete a pending App. The "Admin" panel is designed to provide an interface to the database only. Asking it to also "know" about uploaded files may be asking too much. => By Default, Admin can delete an App or App Pending or any other Database entry from the Django Admin Panel (Feature provided by Django) When the Admin tries to delete the App from Admin Panel (by Mistake or by Purpose), Currently the Jar is not getting removed from the S3 Bucket, Just increasing the manual effort by the S3 Admin to Purge the unnecessary Files So to avoid that, with this update, when an Admin Deletes the App from the Admin Panel, The Jar File will be deleted automatically (Done using "post_delete" signal operator by Django), which means the Admin will not be having any extra effort what-so-ever to delete the jar file

            People

            • Assignee:
              sameer Sameer Shanbhag (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: