Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct
Description
Refactor the app store code base to rename the symbolicname variable to bundle_symbolic_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Summary | Rename symbolicname variable to bundle_symbolic_name | Rename symbolicname variable to Bundle_SymbolicName |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged to master branch in team repository. Please test after refactoring issues are merged.
Please commence testing.
| Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ] |
| Rank | Ranked higher |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Sprint | Fall 2019 Sprint 2, Fall 2019 Sprint 3 [ 73, 74 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 2019 Sprint 4 [ 73, 74, 75 ] |
| Rank | Ranked higher |
Will test as part of general smoke testing. Moving to closed.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Workflow | Fall 2019 Workflow Update [ 20756 ] | Revised Fall 2019 Workflow Update [ 22503 ] |
Question:
Question for Riddhi Jagdish Patil:
Are you changing it to Bundle_SymbolicName or bundle_symbolic_name?
Bundle_SymbolicName has atypical (for python) capitalization. It looks like camel case, but isn't. However, it is more similar to Bundle-SymbolicName, the attribute getting parsed in the bundle's MANIFEST.MF files.
It looks weird, but looking weird might help developers understand how the App Store is actually working.
I'm not sure what is the correct approach here. Either way, do please update the ticket title if you decided to go with bundle_symbolic_name instead of Bundle_SymbolicName.