Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-1999

Rename symbolicname variable to Bundle_SymbolicName

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Refactor the app store code base to rename the symbolicname variable to bundle_symbolic_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment - - edited

              Question:

              Question for Riddhi Jagdish Patil:

              Are you changing it to Bundle_SymbolicName or bundle_symbolic_name?

              Bundle_SymbolicName has atypical (for python) capitalization. It looks like camel case, but isn't. However, it is more similar to Bundle-SymbolicName, the attribute getting parsed in the bundle's MANIFEST.MF files.

              It looks weird, but looking weird might help developers understand how the App Store is actually working.

              I'm not sure what is the correct approach here. Either way, do please update the ticket title if you decided to go with bundle_symbolic_name instead of Bundle_SymbolicName.

              Show
              ann.loraine Ann Loraine added a comment - - edited Question: Question for Riddhi Jagdish Patil : Are you changing it to Bundle_SymbolicName or bundle_symbolic_name? Bundle_SymbolicName has atypical (for python) capitalization. It looks like camel case, but isn't. However, it is more similar to Bundle-SymbolicName, the attribute getting parsed in the bundle's MANIFEST.MF files. It looks weird, but looking weird might help developers understand how the App Store is actually working. I'm not sure what is the correct approach here. Either way, do please update the ticket title if you decided to go with bundle_symbolic_name instead of Bundle_SymbolicName.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged to master branch in team repository. Please test after refactoring issues are merged.

              Show
              ann.loraine Ann Loraine added a comment - Merged to master branch in team repository. Please test after refactoring issues are merged.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please commence testing.

              Show
              ann.loraine Ann Loraine added a comment - Please commence testing.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Will test as part of general smoke testing. Moving to closed.

              Show
              ann.loraine Ann Loraine added a comment - Will test as part of general smoke testing. Moving to closed.

                People

                • Assignee:
                  rpatil14 Riddhi Jagdish Patil (Inactive)
                  Reporter:
                  rpatil14 Riddhi Jagdish Patil (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: