Details
-
Type: Improvement
-
Status: Closed (View Workflow)
-
Priority: Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct
Description
Refactor the app store code base to rename the symbolicname variable to bundle_symbolic_name to make it more meaningful and to let the developers know that the symbolic name is Bundle-SymbolicName of MANIFEST.MF file
Attachments
Activity
Riddhi Jagdish Patil (Inactive)
created issue -
Riddhi Jagdish Patil (Inactive)
made changes -
Field | Original Value | New Value |
---|---|---|
Epic Link |
|
Riddhi Jagdish Patil (Inactive)
made changes -
Status | Open [ 1 ] | To-Do [ 10305 ] |
Ann Loraine
made changes -
Summary | Rename symbolicname variable to bundle_symbolic_name | Rename symbolicname variable to Bundle_SymbolicName |
Riddhi Jagdish Patil (Inactive)
made changes -
Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Ann Loraine
made changes -
Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Ann Loraine
made changes -
Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Ann Loraine
made changes -
Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
Ann Loraine
made changes -
Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Ann Loraine
made changes -
Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
Ann Loraine
made changes -
Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Ann Loraine
made changes -
Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ] |
Ann Loraine
made changes -
Rank | Ranked higher |
Ann Loraine
made changes -
Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Shamika Gajanan Kulkarni (Inactive)
made changes -
Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Shamika Gajanan Kulkarni (Inactive)
made changes -
Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Shamika Gajanan Kulkarni (Inactive)
made changes -
Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Shamika Gajanan Kulkarni (Inactive)
made changes -
Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
Ann Loraine
made changes -
Sprint | Fall 2019 Sprint 2, Fall 2019 Sprint 3 [ 73, 74 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 2019 Sprint 4 [ 73, 74, 75 ] |
Ann Loraine
made changes -
Rank | Ranked higher |
Ann Loraine
made changes -
Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Ann Loraine
made changes -
Resolution | Done [ 10000 ] | |
Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Ann Loraine
made changes -
Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
Ann Loraine
made changes -
Workflow | Fall 2019 Workflow Update [ 20756 ] | Revised Fall 2019 Workflow Update [ 22503 ] |
Question:
Question for Riddhi Jagdish Patil:
Are you changing it to Bundle_SymbolicName or bundle_symbolic_name?
Bundle_SymbolicName has atypical (for python) capitalization. It looks like camel case, but isn't. However, it is more similar to Bundle-SymbolicName, the attribute getting parsed in the bundle's MANIFEST.MF files.
It looks weird, but looking weird might help developers understand how the App Store is actually working.
I'm not sure what is the correct approach here. Either way, do please update the ticket title if you decided to go with bundle_symbolic_name instead of Bundle_SymbolicName.