Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2001

Rename the edit app page variables with meaningful names

        Details

        • Type: Improvement
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
        • Story Points:
          1
        • Epic Link:
        • Sprint:
          Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct

          Description

          Rename icon to logo
          Rename license_text to license_URL
          Rename website to website_URL
          Rename tutorial to tutorial_URL
          Rename coderepo to code_repository_URL
          Rename contact to contact_email
          Rename repository to repository_XML

          See:

          apps/models.py

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              15 older comments
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2001-2#diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2001-2#diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please submit PR. We will deploy onto dev-apptore-2 for testing. Noor Zahara

              Show
              ann.loraine Ann Loraine added a comment - Please submit PR. We will deploy onto dev-apptore-2 for testing. Noor Zahara
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/137/igbf-2001-delete-logo-image-from-s3-before/diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - PR Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/137/igbf-2001-delete-logo-image-from-s3-before/diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged and deployed to dev-appstore-2-bioviz.org.

              Please review changes and let us know if any further fixes need to be made.
              Riddhi Jagdish Patil

              Show
              ann.loraine Ann Loraine added a comment - Merged and deployed to dev-appstore-2-bioviz.org. Please review changes and let us know if any further fixes need to be made. Riddhi Jagdish Patil
              Hide
              Permalink
              rpatil14 Riddhi Jagdish Patil (Inactive) added a comment -

              Tested successfully below scenarios:
              1) Click on any released app from app store home page -> Editor Actions -> Edit this page -> Hover on the logo space to view the tooltip
              2) Click on any released app from app store home page -> Editor Actions -> Edit this page -> Add any url as malformed -> Save. Error is thrown with invalid URL
              3) Upload logo with say .png format, then replace the logo with say .jpg format. The logo gets updated on the App page and the old logo is deleted from the S3 bucket even though the extension of the two files is different. Also, replace logo with different logo of same extension works as expected and deletes the old logo from S3 bucket.
              cc. [~aloraine], [~nzahara]

              Show
              rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Tested successfully below scenarios: 1) Click on any released app from app store home page -> Editor Actions -> Edit this page -> Hover on the logo space to view the tooltip 2) Click on any released app from app store home page -> Editor Actions -> Edit this page -> Add any url as malformed -> Save. Error is thrown with invalid URL 3) Upload logo with say .png format, then replace the logo with say .jpg format. The logo gets updated on the App page and the old logo is deleted from the S3 bucket even though the extension of the two files is different. Also, replace logo with different logo of same extension works as expected and deletes the old logo from S3 bucket. cc. [~aloraine] , [~nzahara]

                People

                • Assignee:
                  noor91zahara Noor Zahara (Inactive)
                  Reporter:
                  rpatil14 Riddhi Jagdish Patil (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: