Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2002

Rename app describing variables with meaningful name

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:

      Description

      • Refactor the app store code base to rename the details variable to bundle_description to make it more meaningful and to let the developers know that the details is Bundle-Description of MANIFEST.MF file
      • Rename description with short_title since it does not contain detailed description of the app. The detailed description of app will be in bundle_description section.

        Attachments

          Activity

          Hide
          aloraine Ann Loraine added a comment -

          All other refactoring branches are merged to master. When you are ready to get back to this Riddhi Jagdish Patil, please rebase on or merge from lorainelab/appstore master.

          Show
          aloraine Ann Loraine added a comment - All other refactoring branches are merged to master. When you are ready to get back to this Riddhi Jagdish Patil , please rebase on or merge from lorainelab/appstore master.
          Hide
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited

          Issue : Rename app describing variables details to Bundle_Description and description to short_title to make it more meaningful

          Description :
          Refactor the app store code base to rename the details variable to Bundle_Description to make it more meaningful and to let the developers know that the details is Bundle-Description of MANIFEST.MF file
          Rename description with short_title since it does not contain detailed description of the app. The detailed description of app will be in Bundle_Description section.

          Code changes :
          https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2002-app-description#diff

          Note : Fixed version name change to Bundle_Version at one location in views.py of submit_app

          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - - edited Issue : Rename app describing variables details to Bundle_Description and description to short_title to make it more meaningful Description : Refactor the app store code base to rename the details variable to Bundle_Description to make it more meaningful and to let the developers know that the details is Bundle-Description of MANIFEST.MF file Rename description with short_title since it does not contain detailed description of the app. The detailed description of app will be in Bundle_Description section. Code changes : https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2002-app-description#diff Note : Fixed version name change to Bundle_Version at one location in views.py of submit_app
          Hide
          aloraine Ann Loraine added a comment -

          Code looks fine. I did not test the functionality. However, changes look to be low-risk. I think it is fine to merge as-is.

          Show
          aloraine Ann Loraine added a comment - Code looks fine. I did not test the functionality. However, changes look to be low-risk. I think it is fine to merge as-is.
          Show
          rpatil14 Riddhi Jagdish Patil (Inactive) added a comment - Pull request submitted https://bitbucket.org/lorainelab/appstore/pull-requests/109/igbf-2002-rename-app-describing-variables/diff
          Hide
          aloraine Ann Loraine added a comment -

          Merged but not yet deployed for testing.

          Show
          aloraine Ann Loraine added a comment - Merged but not yet deployed for testing.
          Hide
          aloraine Ann Loraine added a comment -
          Show
          aloraine Ann Loraine added a comment - Deployed to https://dev-appstore-2.bioviz.org
          Hide
          noor91zahara Noor Zahara added a comment -

          Works as expected.

          Bug related to repository_xml in submit_app/views is been fixed in IGBF-2050

          Show
          noor91zahara Noor Zahara added a comment - Works as expected. Bug related to repository_xml in submit_app/views is been fixed in IGBF-2050

            People

            • Assignee:
              rpatil14 Riddhi Jagdish Patil (Inactive)
              Reporter:
              rpatil14 Riddhi Jagdish Patil (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: