Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 4 : 30 Sep to 11 Oct
Description
- Refactor the app store code base to rename the details variable to bundle_description to make it more meaningful and to let the developers know that the details is Bundle-Description of MANIFEST.MF file
- Rename description with short_title since it does not contain detailed description of the app. The detailed description of app will be in bundle_description section.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Issue : Rename app describing variables details to Bundle_Description and description to short_title to make it more meaningful
Description :
Refactor the app store code base to rename the details variable to Bundle_Description to make it more meaningful and to let the developers know that the details is Bundle-Description of MANIFEST.MF file
Rename description with short_title since it does not contain detailed description of the app. The detailed description of app will be in Bundle_Description section.
Code changes :
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2002-app-description#diff
Note : Fixed version name change to Bundle_Version at one location in views.py of submit_app
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Ann Loraine [ aloraine ] |
Code looks fine. I did not test the functionality. However, changes look to be low-risk. I think it is fine to merge as-is.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Ann Loraine [ aloraine ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged but not yet deployed for testing.
| Sprint | Fall 2019 Sprint 2 [ 73 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 4 [ 73, 74 ] |
| Rank | Ranked higher |
| Sprint | Fall 2019 Sprint 2, Fall 2019 Sprint 3 [ 73, 74 ] | Fall 2019 Sprint 2, Fall 2019 Sprint 3, Fall 2019 Sprint 4 [ 73, 74, 75 ] |
| Rank | Ranked higher |
Deployed to https://dev-appstore-2.bioviz.org
Works as expected.
Bug related to repository_xml in submit_app/views is been fixed in IGBF-2050
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Noor Zahara [ noor91zahara ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Workflow | Fall 2019 Workflow Update [ 20759 ] | Revised Fall 2019 Workflow Update [ 22506 ] |
All other refactoring branches are merged to master. When you are ready to get back to this Riddhi Jagdish Patil, please rebase on or merge from lorainelab/appstore master.