Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov
Description
When developers upload an App, App Store must perform first-level automated review of the App to make sure it follows basic specifications. For example:
- Jar file must contain OBR index file called "repository.xml" at the top level of the jar
- Jar file MANIFEST must contain OSGi headers of Bundle-SymbolicName, Bundle-Version, and Bundle-Name (note that Bundle-Description is optional)
- An uploaded jar file can have the same Bundle-SymbolicName and same Bundle-Version as a currently "pending" App, but not a released App
- An uploaded jar file can have the same Bundle-SymbolicName as a released App but its Bundle-Version should be different
All the various combinations of what a developer can do are kind of complicated, and our current submit app feedback page does not do a great job of explaining what's happening when a developer submits an App jar. For example, we are telling the developer whether the uploaded jar file is a "new app," but there are several ways that an App can be new!
Let's change the feedback page as follows:
Instead of displaying the line: "Is the is a new App" and then showing either "Yes" or "No", let's instead display a different line: "App Summary" and provide some text explaining what we think the developer is doing. If the developer reads this text, they will be able to decide whether to proceed with the next step of either canceling the submission or proceeding with submission.
For the new design, please see this PowerPoint:
https://www.dropbox.com/s/xe1v2jo17fg23th/SubmitApp-JarUpload.pptx?dl=0
(This is the same PPT as for IGBF-1995, but with new slides added.)
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
| Resolution | Unresolved [ 10101 ] | |
| Sprint | Fall 2019 Sprint 3 [ 74 ] | Fall 2019 Sprint 4 [ 75 ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Description |
When developers upload an App, App Store must perform first-level automated review of the App to make sure it follows basic specifications:
* Jar file must contain OBR index file called "repository.xml" at the top level of the jar * Jar file MANIFEST must contain OSGi headers of Bundle-SymbolicName, Bundle-Version, and Bundle-Name (note that Bundle-Description is optional) * An uploaded jar file can have the same Bundle-SymbolicName and same Bundle-Version as a currently "pending" App, but not a released App * An uploaded jar file can have the same Bundle-SymbolicName as a released App but its Bundle-Version should be different All the various combinations of what a developer can do are kind of complicated, and our current submit app feedback page does not do a great job of explaining what's happening when a developer submits an App jar. For example, we are telling the developer whether the uploaded jar file is a "new app," but there are several ways that an App can be new! Let's change the feedback page as follows: Instead of displaying the line: "Is the is a new App" and then showing either "Yes" or "No", let's instead display a different line: "App Summary" and give a simple sentence explaining what the developer is doing. If the developer reads this text, they will be able to decide whether to proceed with the next step of either canceling the submission or proceeding with submission. For the new design, please see this PowerPoint: (to be added) |
When developers upload an App, App Store must perform first-level automated review of the App to make sure it follows basic specifications. For example:
* Jar file must contain OBR index file called "repository.xml" at the top level of the jar * Jar file MANIFEST must contain OSGi headers of Bundle-SymbolicName, Bundle-Version, and Bundle-Name (note that Bundle-Description is optional) * An uploaded jar file can have the same Bundle-SymbolicName and same Bundle-Version as a currently "pending" App, but not a released App * An uploaded jar file can have the same Bundle-SymbolicName as a released App but its Bundle-Version should be different All the various combinations of what a developer can do are kind of complicated, and our current submit app feedback page does not do a great job of explaining what's happening when a developer submits an App jar. For example, we are telling the developer whether the uploaded jar file is a "new app," but there are several ways that an App can be new! Let's change the feedback page as follows: Instead of displaying the line: "Is the is a new App" and then showing either "Yes" or "No", let's instead display a different line: "App Summary" and provide some text explaining what the developer is doing. If the developer reads this text, they will be able to decide whether to proceed with the next step of either canceling the submission or proceeding with submission. For the new design, please see this PowerPoint: https://www.dropbox.com/s/xe1v2jo17fg23th/SubmitApp-JarUpload.pptx?dl=0 (This is the same PPT as for |
| Description |
When developers upload an App, App Store must perform first-level automated review of the App to make sure it follows basic specifications. For example:
* Jar file must contain OBR index file called "repository.xml" at the top level of the jar * Jar file MANIFEST must contain OSGi headers of Bundle-SymbolicName, Bundle-Version, and Bundle-Name (note that Bundle-Description is optional) * An uploaded jar file can have the same Bundle-SymbolicName and same Bundle-Version as a currently "pending" App, but not a released App * An uploaded jar file can have the same Bundle-SymbolicName as a released App but its Bundle-Version should be different All the various combinations of what a developer can do are kind of complicated, and our current submit app feedback page does not do a great job of explaining what's happening when a developer submits an App jar. For example, we are telling the developer whether the uploaded jar file is a "new app," but there are several ways that an App can be new! Let's change the feedback page as follows: Instead of displaying the line: "Is the is a new App" and then showing either "Yes" or "No", let's instead display a different line: "App Summary" and provide some text explaining what the developer is doing. If the developer reads this text, they will be able to decide whether to proceed with the next step of either canceling the submission or proceeding with submission. For the new design, please see this PowerPoint: https://www.dropbox.com/s/xe1v2jo17fg23th/SubmitApp-JarUpload.pptx?dl=0 (This is the same PPT as for |
When developers upload an App, App Store must perform first-level automated review of the App to make sure it follows basic specifications. For example:
* Jar file must contain OBR index file called "repository.xml" at the top level of the jar * Jar file MANIFEST must contain OSGi headers of Bundle-SymbolicName, Bundle-Version, and Bundle-Name (note that Bundle-Description is optional) * An uploaded jar file can have the same Bundle-SymbolicName and same Bundle-Version as a currently "pending" App, but not a released App * An uploaded jar file can have the same Bundle-SymbolicName as a released App but its Bundle-Version should be different All the various combinations of what a developer can do are kind of complicated, and our current submit app feedback page does not do a great job of explaining what's happening when a developer submits an App jar. For example, we are telling the developer whether the uploaded jar file is a "new app," but there are several ways that an App can be new! Let's change the feedback page as follows: Instead of displaying the line: "Is the is a new App" and then showing either "Yes" or "No", let's instead display a different line: "App Summary" and provide some text explaining what we think the developer is doing. If the developer reads this text, they will be able to decide whether to proceed with the next step of either canceling the submission or proceeding with submission. For the new design, please see this PowerPoint: https://www.dropbox.com/s/xe1v2jo17fg23th/SubmitApp-JarUpload.pptx?dl=0 (This is the same PPT as for |
| Resolution | Unresolved [ 10101 ] | |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Comment | [ testing ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
Fixing related issues before starting on this ticket.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Sprint | Fall 4 : 30 Sep to 11 Oct [ 75 ] | Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct [ 75, 76 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Workflow | Fall 2019 Workflow Update [ 20783 ] | Revised Fall 2019 Workflow Update [ 21194 ] |
| Attachment | something_wrong_page.png [ 14452 ] |
Hi Professor,
What all information do we need to display on "Something went wrong" page?
The design pptx has "Is this a new App?" which we are no longer showing on the summary page, BundleName, Bundle-SymbolicName, Bundle-Version.
The fields that we need to show are,
You submitted, BundleName, Bundle-SymbolicName, Bundle-Version and Summary. Please refer attached screenshot and suggest changes if needed.
We will have to update the pptx for this page accordingly.
cc. [~aloraine]
Yes, I will fix it now.
Done. Also, a quick note: The screen capture looks very nice. The horizontal rule lines and indentation make the page very easy to read.
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Issue:
Improve submit app confirmation page to better inform user what is happening
Solution:
To display the summary of the app submitted by the user, check if the Bundle_Name and Bundle_Version of the app submitted by the user matches already released app and/or is already present in the PendingApp state. Based on the presence of app in either Apps or AppPending table, display the app summary to the user.
Files changed:
static/submit_app/css/app_summary.css
static/submit_app/js/app_summary.js
submit_app/templates/confirm.html
submit_app/templates/error.html
submit_app/views.py
Code changes are present in branch https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2026#diff
For example Apps, visit:
https://bitbucket.org/account/user/lorainelab/projects/IAQ
Testing steps:
Scenario 1:
Submit an app using either "Choose File" option or "Enter URL" option
Expected output - The summary page should display "all-new app" message
Scenario 2:
Submit an already released app with same Bundle_Name and Bundle_Version
Expected output - Error page should display "already-released app" message
Scenario 3:
Submit an app with same Bundle_Name but different Bundle_Version for already released app
Excepted output - The summary page should display "new version of a released App" message
Scenario 4:
Submit an app and do not release it. Submit the same app with same Bundle_Name and Bundle_Version.
Excepted output - The summary page should display "jar replacement" message
Scenario 5:
Submit an app and release it. Submit an app with same Bundle_Name but different Bundle_version
Excepted output - The summary page should display "not yet released app" message
Testing results:
Code changes are deployed to https://dev-appstore-6.bioviz.org.Admin username and password for devappstore6 is same as devappstore2
known issue: IGBF-2081
cc. [~aloraine]
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Ann Loraine [ aloraine ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Pull request submitted:
https://bitbucket.org/lorainelab/appstore/pull-requests/143/igbf-2026/diff
cc. [~aloraine]
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed on https://dev-appstore-2.bioviz.org and ready for testing.
| Sprint | Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct [ 75, 76 ] | Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov [ 75, 76, 77 ] |
| Rank | Ranked higher |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Tested the different scenarios as mentioned above. My observations are as follows:
The scenarios 1,2 and 3 are working perfectly fine. For scenarios 4 and 5, the message being displayed is "all-new app" message. The scenarios are as follows.
Scenario 4:
Submit an app and do not release it. Submit the same app with same Bundle_Name and Bundle_Version.
Excepted output - The summary page should display "jar replacement" message
Scenario 5:
Submit an app and release it. Submit an app with same Bundle_Name but different Bundle_version
Excepted output - The summary page should display "not yet released app" message
Moving the ticket to To-Do. Kindly check the issue.
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] | Shamika Gajanan Kulkarni [ shamika ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
Scenario 5 was working as expected. Fixed scenario 4
Fixed bug in below branch:
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2026-BugFix#diff
cc. [~aloraine], Shamika Gajanan Kulkarni
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Sameer Shanbhag [ sameer ] |
| Assignee | Sameer Shanbhag [ sameer ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Working as expected.
| Assignee | Noor Zahara [ noor91zahara ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Writing user story and creating initial design.