Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov
Description
Steps to reproduce the issue:
1) Submit any app by clicking Submit your App button on homepage.
2) Upload app using either URL or jar and click Next
3) Verify all the information and submit the app
4) Try re-submitting same app using above steps without releasing the app
5) Go to the pending apps and try to accept the submitted app.
The app gets accepted but the loading spinner keeps on spinning.
Check the admin page for that released app. The release file name and release file information is missing.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Summary | Accept of re-submitted pending apps stores incomplete app information | Accept of re-submitted pending apps saves incomplete app information |
| Summary | Accept of re-submitted pending apps saves incomplete app information | Fix: Accept of re-submitted pending apps saves incomplete app information |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Open [ 1 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Noor Zahara [ noor91zahara ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Story Points | 1 |
| Assignee | Sameer Shanbhag [ sameer ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Looks good. Can be Deployed.
Can you please raise the Pull Request.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Sameer Shanbhag [ sameer ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
Merged.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
File is getting updated in the release folder. But, the date of the file is not changing in the appstore UI.
My suggestion is to change the date and time in the appstore UI. (It helps admin or users to check the latest version without looking in the file system)
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Sai Charan Reddy Vallapureddy [ svallapu ] |
| Sprint | Fall 4 : 30 Sep to 11 Oct [ 75 ] | Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct [ 75, 76 ] |
| Rank | Ranked higher |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Submitted pull request for wrong branch. Submitting pull request for correct branch below
Pull request submitted
https://bitbucket.org/lorainelab/appstore/pull-requests/136/igbf-2044/diff
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged but not yet deployed on dev-appstore-2.bioviz.org
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
Tested
Issue Found -
1. Release file name not getting updated upon accepting the pending app.
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Release file name not getting updated upon accepting the pending app issue will be fixed as a part of the ticket IGBF-2072
Keeping this ticket in "Needs testing step". Can be tested once IGBF-2072 is merged to master.
cc. [~aloraine], Noor Zahara
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Workflow | Fall 2019 Workflow Update [ 20801 ] | Revised Fall 2019 Workflow Update [ 21151 ] |
Deployed on https://dev-appstore-2.bioviz.org and ready for testing.
| Sprint | Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct [ 75, 76 ] | Fall 4 : 30 Sep to 11 Oct, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov [ 75, 76, 77 ] |
| Rank | Ranked higher |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
Testing result-
Same App submitted multiple times is getting accepted with all the details being updated.
App released time shown in release history is incorrect.
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Noor Zahara [ noor91zahara ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Fixed release time in app release history:
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF-2044-BugFix#diff
cc. Noor Zahara
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Have not done functional review of new branch but feel it will be fine to merge this into master as-is.
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Riddhi Jagdish Patil [ rpatil14 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
It is working as expected.
TimeZone considered is UTC.
| Assignee | Noor Zahara [ noor91zahara ] | Riddhi Jagdish Patil [ rpatil14 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Issue:
Multiple submission of same app with same version without releasing should create single entry in pending app and released on accept
Files changed:
https://bitbucket.org/rpatil14/appstore_riddhi/branch/IGBF_2044#diff
submit_app/views.py
Testing steps:
1) Submit any app by clicking Submit your App button on homepage
2) Upload app using either URL or jar and click Next
3) Verify all the information and submit the app
4) Part I: Build a new jar for the same app, same version, but slightly different functionality so that you can tell the difference between them once installed into IGB. Try submitting this new jar (same Bundle-SymbolicName, same Bundle-Version) using above steps without releasing the previous submitted app
5) Login as Admin
6) Go to the pending apps and accept the submitted app. (There should be only one with this Bundle-SymbolicName and Bundle-Version.)
7) The app will be accepted and released. Check that it is the correct one by installing it into IGB and running it.
Testing result:
Code changes deployed to -https://dev-appstore-6.bioviz.org
S3 jar upload URL - https://s3.console.aws.amazon.com/s3/buckets/devappstore6-media-0000/media/super-simple-igb-app/releases/0.0.3/?region=us-east-1
cc. [~aloraine]