Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:
-
Story Points:1.5
-
Epic Link:
-
Sprint:Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov
Description
On changing the AppDescription.md file for different versions of a single app, the repository.xml gets updated. However, the description displayed in App Manager does not reflect these changes for each versions. Kindly refer to the issue linked to this ticket and review the comments and screenshots for more clarification.
Attachments
Issue Links
- relates to
-
REL-29 App Manager should show & install correct App versions from App Store
-
- Fix Requested
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
Could you point out the bug ? I do not see it. Noor Zahara
The check in the below function (i.e. isUpdateable) is the place where I think the logic should be changed. As per me this check needs to be removed.
public Bundle getLatestBundle(Bundle bundle) {
if (isUpdateable(bundle)) {....}}
And also isUpdateable returns true only if the app with same bundle symbolic name and version is installed. This also needs to be checked.
| Sprint | Fall 6 : 28 Oct to 8 Nov [ 77 ] | Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov [ 77, 78 ] |
| Rank | Ranked higher |
| Assignee | Noor Zahara [ noor91zahara ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
It is working as expected with the new appstore changes. I am not sure what was causing this issue earlier.
Shamika Gajanan Kulkarni - Could you test and confirm the same.
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Noor Zahara [ noor91zahara ] | Shamika Gajanan Kulkarni [ shamika ] |
Noor Zahara The issue is not seen anymore. I checked again. Thanks for letting me know. Any ideas on what might have caused it earlier?
Prof. [~aloraine] Can we close the ticket?
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
Yes, please close.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Observations made :
As per the below functions in BundleInfoManager.java, the app is updated only if the version is same. So might have to change the logic here.
public boolean isUpdateable(Bundle bundle) {
{ return repoBundle.getVersion().compareTo(installedBundle.getVersion()) == 1; }if (Arrays.asList(bundleContext.getBundles()).stream()
.anyMatch(installedBundle -> installedBundle.getSymbolicName().equals(bundle.getSymbolicName()))) {
Bundle installedBundle = Arrays.asList(bundleContext.getBundles()).stream()
.filter(b -> b.getSymbolicName().equals(bundle.getSymbolicName())).findFirst().get();
return repositoryManagedBundles.stream()
.filter(repoBundle -> repoBundle.getSymbolicName().equals(bundle.getSymbolicName()))
.anyMatch(repoBundle ->
);
{ return false; }} else
}
public Bundle getLatestBundle(Bundle bundle) {
{ return o1.getVersion().compareTo(o2.getVersion()); }if (isUpdateable(bundle)) {
List<Bundle> updateableVersions = repositoryManagedBundles.stream()
.filter(b -> b.getSymbolicName().equals(bundle.getSymbolicName()))
.collect(Collectors.toList());
Collections.sort(updateableVersions, (Bundle o1, Bundle o2) ->
);
{ return updateableVersions.get(updateableVersions.size() - 1); }if (!updateableVersions.isEmpty())
}
return bundle;
}
[~aloraine]