Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2099

Fix: "works_with" field not getting set (always 9.1)

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec

      Description

      When a user uploads a new App, it gets placed in the "pending apps" table in the database, which has a field "works_with".

      This field is meant to contain a string indicating which version or version range of the IGB platform the App requires.

      Currently, this value is being set to a default value of 9.1.0, the upcoming release of IGB.

      Instead, this value should be set using the IGB platform version indicated in the App's repository.xml and MANIFEST.MF files. (App repository.xml and App MANIFEST.MF should contain the same information regarding imported dependencies.)

      Potentially useful suggestions and comments:

      • Seems like the repository.xml file would be much easier to parse because the data are more structured. Since we now require the repository.xml file to be included in the uploaded jar file, let's parse repository.xml to get the platform versions. Why not?
      • For now, let's use the version syntax word-for-word as provided by the repository.xml file, e.g., [10.0.0,11.0.0) or whatever. We will report that to the user as-is. It's not very user-friendly, but I have a feeling biologists and users will "get" what it means. And later on we can come up with a more user-friendly format. For now, we just need to report the platform version to the user – and to us, for testing.
      • We can use the repository.xml "require" tag with "name" equal to "package" to identify IGB platform dependencies.

      Probably most packages that an IGB App can legally import from the platform has package structure of org.lorainelab.igb.*.

      So we could maybe write a regex that would extract the version strings for every imported org.lorainelab.igb package used by an App.

      We should look at all of them, and require that all such packages use the same version strings.

        Attachments

          Issue Links

            Activity

            Hide
            aloraine Ann Loraine added a comment -

            Change request:

            Please change error_message (line 105) to:

            "Please note: We read your App's repository.xml file but could not determine the IGB version it requires. Not to worry! You can enter this information manually after the App is released."

            Show
            aloraine Ann Loraine added a comment - Change request: Please change error_message (line 105) to: "Please note: We read your App's repository.xml file but could not determine the IGB version it requires. Not to worry! You can enter this information manually after the App is released."
            Hide
            noor91zahara Noor Zahara added a comment -

            I have changed the error message to "Please note: We read your App's repository.xml file but could not determine the IGB version it requires. Not to worry! You can enter this information manually after the App is released."

            Show
            noor91zahara Noor Zahara added a comment - I have changed the error message to "Please note: We read your App's repository.xml file but could not determine the IGB version it requires. Not to worry! You can enter this information manually after the App is released."
            Show
            noor91zahara Noor Zahara added a comment - https://bitbucket.org/lorainelab/appstore/pull-requests/171/igbf-2099-1/diff - PR raised
            Hide
            aloraine Ann Loraine added a comment -

            Merged and deployed to https://dev-appstore-2.bioviz.org.

            Show
            aloraine Ann Loraine added a comment - Merged and deployed to https://dev-appstore-2.bioviz.org .
            Hide
            prutha Prutha Kulkarni (Inactive) added a comment -

            Tested on dev-appstore-2. The works with field along with whichever IGB version it is compatible with is shown properly on the app page.
            Moving it to DONE.

            Show
            prutha Prutha Kulkarni (Inactive) added a comment - Tested on dev-appstore-2. The works with field along with whichever IGB version it is compatible with is shown properly on the app page. Moving it to DONE.

              People

              • Assignee:
                noor91zahara Noor Zahara
                Reporter:
                aloraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: