Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2104

Implement Load Genome Requirement

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          1
        • Epic Link:
        • Sprint:
          Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec

          Description

          Situation: Loading a BAI by itself requires the chromosomes and their lengths. This information is being provided by IGB as long as a genome has been loaded. Versions of IGB previous to 9.1 required users to load a genome before loading data. As of 9.1 we now allow users to load data when no genome is selected. However, this will not work for BAI file, as the genome information is required.

          Task: Implement the popup seen in IGB pre 9.1 warning the user that they must select a genome before loading a BAI file. Make sure that the warning only pops up for BAI files.

            Attachments

              Issue Links

              relates to

              Story - Created by JIRA Software - do not edit or delete. Issue type for a user story. IGBF-1920 Visualizing the index

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                5 older comments
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Code is working correctly for File > Open File, dragging and dropping, and loading via URL.

                Ready for pull request.

                Show
                nfreese Nowlan Freese added a comment - Code is working correctly for File > Open File, dragging and dropping, and loading via URL. Ready for pull request.
                Hide
                Permalink
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

                [~aloraine]Nowlan Freese

                Pull request submitted

                Show
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - [~aloraine] Nowlan Freese Pull request submitted
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                Sai Charan Reddy Vallapureddy please check my one comment on the - see your branch/commit in bitbucket. I had a quick request for clarification regarding and apache commons import.

                Comment is copied below:

                "Can you please double-check that the bundle containing package org.apache.commons.io.FilenameUtils is properly imported? I’m wondering if might not be because I did not see an “apache” bundle explicitly included in the dependencies in the POM.xml file. However, in the maven bundle plugin configuration, the import packages directive is “*;resolution:=optional”

                I’m not completely sure about this, but I think what’s happening is that we are telling the bnd tool that all packages are imported and even if they are not available in the run-time, the bundle should still resolve. Which means there could potentially be a run-time error?

                Could yo double-check the bundle’s MANIFEST.MF file to make sure the needed apache commons packages is listed? Also, make sure it is properly listed in the bundle’s POM as a provided dependency?"

                cc: Nowlan Freese

                Show
                ann.loraine Ann Loraine added a comment - - edited Sai Charan Reddy Vallapureddy please check my one comment on the - see your branch/commit in bitbucket. I had a quick request for clarification regarding and apache commons import. Comment is copied below: "Can you please double-check that the bundle containing package org.apache.commons.io.FilenameUtils is properly imported? I’m wondering if might not be because I did not see an “apache” bundle explicitly included in the dependencies in the POM.xml file. However, in the maven bundle plugin configuration, the import packages directive is “*;resolution:=optional” I’m not completely sure about this, but I think what’s happening is that we are telling the bnd tool that all packages are imported and even if they are not available in the run-time, the bundle should still resolve. Which means there could potentially be a run-time error? Could yo double-check the bundle’s MANIFEST.MF file to make sure the needed apache commons packages is listed? Also, make sure it is properly listed in the bundle’s POM as a provided dependency?" cc: Nowlan Freese
                Hide
                Permalink
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment -

                IGBF-2189 ticket is created for this issue.

                Show
                svallapu Sai Charan Reddy Vallapureddy (Inactive) added a comment - IGBF-2189 ticket is created for this issue.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Load genome requirement working correctly for URL, file, and drag and drop.

                Closing issue.

                Show
                nfreese Nowlan Freese added a comment - Load genome requirement working correctly for URL, file, and drag and drop. Closing issue.

                  People

                  • Assignee:
                    svallapu Sai Charan Reddy Vallapureddy (Inactive)
                    Reporter:
                    nfreese Nowlan Freese
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: