[IGBF-2114] Enable move tool (hand) to select items - JIRA UNCC

Details

Type: New Feature
Status: Closed (View Workflow)
Priority: Major
Resolution: Done
Affects Version/s: None
Fix Version/s: 9.1.8 Major Release
Labels:
- Advanced

Story Points:
5
Epic Link:
Improve IGB for users
Sprint:
Winter 6 Mar 8 - Mar 19, Spring 1 2021 Mar 22 - Apr 2, Spring 2 2021 Apr 5 - Apr 16

Description

When users click the hand button ("move tool"), the cursor changes appearance and users can now click-drag the display to pan left or right.

When in "move mode", users can't select items in the display.

Let's change this to allow click-to-select.

Note that we can't allow click-drag to select because click-drag is already being used for the panning (move) interaction.

Please note the selection rules within IGB. When nothing is selected, click the "i" in the top right of the window.

Attachments

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 01/Apr/21 10:00 AM - edited

Grab tool logic change objectives:

on mouseUp, if the cursor has moved since mouseDown (drag event), if the underlying area is a glyph, deselect all previous selections and select the glyph; if the underlying area is not a glyph, maintain any selections.
on mouseUp, if the cursor has not moved since mouseDown (click event), if the underlying area is a glyph, (if the glyph is selected, deselect it, otherwise, deselect all glyphs and select the glyph underlying the click)

Holding the alt key changes which of the tools (select vs hand), is active, by changing the classes (SeqMapViewRubberBand vs SmartDragScrollMonitor) that are used, so modifying the methods used by the SmartDragScrollMonitor class should be sufficient to create the desired changes.

Holding the shift key should allow for selection of multiple glyphs.

Relevant files:

Class responsible for UI element configuration

$repo/core/igb/src/main/java/com/affymetrix/igb/view/SeqMapView.java

Class responsible for listening to click events

$repo/core/igb/src/main/java/com/affymetrix/igb/view/SeqMapViewMouseListener.java

Class responsible for forwarding drag event to genoviz SDK

$repo/core/igb/src/main/java/com/affymetrix/igb/view/SmartDragScrollMonitor.java

Show

Philip Badzuh (Inactive) added a comment - 01/Apr/21 10:00 AM - edited Grab tool logic change objectives: on mouseUp, if the cursor has moved since mouseDown (drag event), if the underlying area is a glyph, deselect all previous selections and select the glyph; if the underlying area is not a glyph, maintain any selections. on mouseUp, if the cursor has not moved since mouseDown (click event), if the underlying area is a glyph, (if the glyph is selected, deselect it, otherwise, deselect all glyphs and select the glyph underlying the click) Holding the alt key changes which of the tools (select vs hand), is active, by changing the classes (SeqMapViewRubberBand vs SmartDragScrollMonitor) that are used, so modifying the methods used by the SmartDragScrollMonitor class should be sufficient to create the desired changes. Holding the shift key should allow for selection of multiple glyphs. Relevant files: Class responsible for UI element configuration $repo/core/igb/src/main/java/com/affymetrix/igb/view/SeqMapView.java Class responsible for listening to click events $repo/core/igb/src/main/java/com/affymetrix/igb/view/SeqMapViewMouseListener.java Class responsible for forwarding drag event to genoviz SDK $repo/core/igb/src/main/java/com/affymetrix/igb/view/SmartDragScrollMonitor.java

8 older comments

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 14/Apr/21 10:11 AM

Please see my PR here.

Show

Philip Badzuh (Inactive) added a comment - 14/Apr/21 10:11 AM Please see my PR here .

Hide

Permalink

Ann Loraine added a comment - 14/Apr/21 8:27 PM - edited

The branch is many commits behind the main branch, so am a bit worried about merging without integration testing first.
Am making a new branch off the latest tip and cherry-picking the two commits onto that.

The new branch is ~~IGBF-2114~~-NewMove at https://bitbucket.org/aloraine/integrated-genome-browser.

commits with hashes are:

660f6983f (HEAD -> IGBF-2114, philip/IGBF-2114) IGBF-2114: Keep glyphs selected on drag canvas mouseUp
a20beb77a IGBF-2114: Allow selection of glyphs during MapScrollMode drag events

Request for Philip Badzuh: Could you test the installers from my fork to check that the changes you have made are functioning properly?

My fork's downloads section:
https://bitbucket.org/aloraine/integrated-genome-browser/downloads/

Show

Ann Loraine added a comment - 14/Apr/21 8:27 PM - edited The branch is many commits behind the main branch, so am a bit worried about merging without integration testing first. Am making a new branch off the latest tip and cherry-picking the two commits onto that. The new branch is IGBF-2114 -NewMove at https://bitbucket.org/aloraine/integrated-genome-browser . commits with hashes are: 660f6983f (HEAD -> IGBF-2114, philip/IGBF-2114) IGBF-2114: Keep glyphs selected on drag canvas mouseUp a20beb77a IGBF-2114: Allow selection of glyphs during MapScrollMode drag events Request for Philip Badzuh : Could you test the installers from my fork to check that the changes you have made are functioning properly? My fork's downloads section: https://bitbucket.org/aloraine/integrated-genome-browser/downloads/

Hide

Permalink

Philip Badzuh (Inactive) added a comment - 14/Apr/21 10:13 PM

Sorry about that. I have rebased the topic branch onto master containing all of the missing commits from the upstream remote. I have tested locally and not found any functionality conflicts. Please see the new PR here.

Show

Philip Badzuh (Inactive) added a comment - 14/Apr/21 10:13 PM Sorry about that. I have rebased the topic branch onto master containing all of the missing commits from the upstream remote. I have tested locally and not found any functionality conflicts. Please see the new PR here .

Hide

Permalink

Ann Loraine added a comment - 14/Apr/21 10:49 PM

Merged and installers are build. Ready for testing.

Show

Ann Loraine added a comment - 14/Apr/21 10:49 PM Merged and installers are build. Ready for testing.

Hide

Permalink

Logan Weidenhammer (Inactive) added a comment - 15/Apr/21 11:56 AM

Tested on Windows 10.
Drag tool can be used to select glyphs.
Holding the alt key changes which tool is active.
Holding the shift key allows for the selection of multiple glyphs.

Looks good, moving to Done.

Show

Logan Weidenhammer (Inactive) added a comment - 15/Apr/21 11:56 AM Tested on Windows 10. Drag tool can be used to select glyphs. Holding the alt key changes which tool is active. Holding the shift key allows for the selection of multiple glyphs. Looks good, moving to Done.

People

Assignee:

Philip Badzuh (Inactive)

Reporter:

Ann Loraine

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

07/Nov/19 5:11 PM

Updated:

30/Apr/21 3:42 PM

Resolved:

15/Apr/21 11:57 AM