Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2137

Review and purge unused variables and code from app_page.html and app_page_edit.html

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          app_page.html and app_page_edit.html contains unused variables and sections.

          Examples:

          • release.notes
          • release.dependents.count

          These fields no longer exist in their corresponding tables, but Django can still run because the template tags include "if [variable_name]"?

          Now, however, these "if" statements always evaluate to false. So we can safely remove them.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              ann.loraine Ann Loraine created issue -
              ann.loraine Ann Loraine made changes -
              Field Original Value New Value
              Epic Link IGBF-1388 [ 17463 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Story Points 1 0.5
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              rpatil14 Riddhi Jagdish Patil (Inactive) made changes -
              Assignee Riddhi Jagdish Patil [ rpatil14 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Riddhi Jagdish Patil [ rpatil14 ] Noor Zahara [ noor91zahara ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2137#diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2137#diff
              noor91zahara Noor Zahara (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment - - edited

              There are many instances of "latest" in the code, suggesting the business logic for display apps is using date not version. This should be fixed. Because this is a different issue, have created a new ticket for that - https://jira.transvar.org/browse/IGBF-2145

              I am not able to do functional review because it is not deployed on a test site. Moving this to "Ready for Pull Request" anyway.

              Show
              ann.loraine Ann Loraine added a comment - - edited There are many instances of "latest" in the code, suggesting the business logic for display apps is using date not version. This should be fixed. Because this is a different issue, have created a new ticket for that - https://jira.transvar.org/browse/IGBF-2145 I am not able to do functional review because it is not deployed on a test site. Moving this to "Ready for Pull Request" anyway.
              ann.loraine Ann Loraine made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              ann.loraine Ann Loraine made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              ann.loraine Ann Loraine made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              ann.loraine Ann Loraine made changes -
              Assignee Noor Zahara [ noor91zahara ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
              ann.loraine Ann Loraine made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              ann.loraine Ann Loraine made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              ann.loraine Ann Loraine made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              ann.loraine Ann Loraine made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Pull Request Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/160/igbf-2137-purge-unwanted-code-from-app-and/diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Pull Request Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/160/igbf-2137-purge-unwanted-code-from-app-and/diff
              noor91zahara Noor Zahara (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged not deployed on dev-appstore-2

              Show
              ann.loraine Ann Loraine added a comment - Merged not deployed on dev-appstore-2
              prutha Prutha Kulkarni (Inactive) made changes -
              Assignee Prutha Kulkarni [ prutha ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              Hide
              Permalink
              prutha Prutha Kulkarni (Inactive) added a comment -

              Tested the code changes on dev-appstore-2. Functionality of the app page and edit mode app page is working fine even after the removal of unnecessary variables.
              Moving this to DONE.

              Show
              prutha Prutha Kulkarni (Inactive) added a comment - Tested the code changes on dev-appstore-2. Functionality of the app page and edit mode app page is working fine even after the removal of unnecessary variables. Moving this to DONE.
              prutha Prutha Kulkarni (Inactive) made changes -
              Assignee Prutha Kulkarni [ prutha ] Noor Zahara [ noor91zahara ]
              prutha Prutha Kulkarni (Inactive) made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                People

                • Assignee:
                  noor91zahara Noor Zahara (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: