Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2137

Review and purge unused variables and code from app_page.html and app_page_edit.html

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      app_page.html and app_page_edit.html contains unused variables and sections.

      Examples:

      • release.notes
      • release.dependents.count

      These fields no longer exist in their corresponding tables, but Django can still run because the template tags include "if [variable_name]"?

      Now, however, these "if" statements always evaluate to false. So we can safely remove them.

        Attachments

          Activity

          Show
          noor91zahara Noor Zahara added a comment - Code changes - https://bitbucket.org/nzahara/appstore-local/branch/IGBF-2137#diff
          Hide
          aloraine Ann Loraine added a comment - - edited

          There are many instances of "latest" in the code, suggesting the business logic for display apps is using date not version. This should be fixed. Because this is a different issue, have created a new ticket for that - https://jira.transvar.org/browse/IGBF-2145

          I am not able to do functional review because it is not deployed on a test site. Moving this to "Ready for Pull Request" anyway.

          Show
          aloraine Ann Loraine added a comment - - edited There are many instances of "latest" in the code, suggesting the business logic for display apps is using date not version. This should be fixed. Because this is a different issue, have created a new ticket for that - https://jira.transvar.org/browse/IGBF-2145 I am not able to do functional review because it is not deployed on a test site. Moving this to "Ready for Pull Request" anyway.
          Show
          noor91zahara Noor Zahara added a comment - Pull Request Submitted - https://bitbucket.org/lorainelab/appstore/pull-requests/160/igbf-2137-purge-unwanted-code-from-app-and/diff
          Hide
          aloraine Ann Loraine added a comment -

          Merged not deployed on dev-appstore-2

          Show
          aloraine Ann Loraine added a comment - Merged not deployed on dev-appstore-2
          Hide
          prutha Prutha Kulkarni (Inactive) added a comment -

          Tested the code changes on dev-appstore-2. Functionality of the app page and edit mode app page is working fine even after the removal of unnecessary variables.
          Moving this to DONE.

          Show
          prutha Prutha Kulkarni (Inactive) added a comment - Tested the code changes on dev-appstore-2. Functionality of the app page and edit mode app page is working fine even after the removal of unnecessary variables. Moving this to DONE.

            People

            • Assignee:
              noor91zahara Noor Zahara
              Reporter:
              aloraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: