Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2141

Capture IP address of App submitter when they upload an App (in release and submit_app)

        Details

        • Type: New Feature
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Keep track of IP addresses of computers that upload App jar files to the App Store.

            Attachments

              Activity

              Descending order - Click to sort in ascending order
              noor91zahara Noor Zahara (Inactive) made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ] Sameer Shanbhag [ sameer ]
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Working as expected.

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Working as expected.
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Can this be deployed on devappstore 2 for testing ?

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Can this be deployed on devappstore 2 for testing ?
              noor91zahara Noor Zahara (Inactive) made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ]
              ann.loraine Ann Loraine made changes -
              Assignee Sameer Shanbhag [ sameer ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status To-Do [ 10305 ] Pull Request Submitted [ 10101 ]
              Hide
              Permalink
              sameer Sameer Shanbhag (Inactive) added a comment - - edited

              The Default IP address acts as a placeholder so that the value will never be null. But we can set null=True instead and the placeholder will no longer be required.
              I have updated the code and the Pull Request.

              https://bitbucket.org/lorainelab/appstore/pull-requests/164/igbf-2141/diff

              Show
              sameer Sameer Shanbhag (Inactive) added a comment - - edited The Default IP address acts as a placeholder so that the value will never be null. But we can set null=True instead and the placeholder will no longer be required. I have updated the code and the Pull Request. https://bitbucket.org/lorainelab/appstore/pull-requests/164/igbf-2141/diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              If you decide to keep the default IP address, please add a comment explaining why it is there.

              Show
              ann.loraine Ann Loraine added a comment - If you decide to keep the default IP address, please add a comment explaining why it is there.
              ann.loraine Ann Loraine made changes -
              Assignee Sameer Shanbhag [ sameer ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please see comment at https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff

              Not sure why default IP address is needed. This seems dangerous because it could mask bugs or maliciousness.

              Show
              ann.loraine Ann Loraine added a comment - Please see comment at https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff Not sure why default IP address is needed. This seems dangerous because it could mask bugs or maliciousness.
              sameer Sameer Shanbhag (Inactive) made changes -
              Assignee Sameer Shanbhag [ sameer ]
              Hide
              Permalink
              sameer Sameer Shanbhag (Inactive) added a comment -

              Pull Request Submitted:

              https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff

              Show
              sameer Sameer Shanbhag (Inactive) added a comment - Pull Request Submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff
              sameer Sameer Shanbhag (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              sameer Sameer Shanbhag (Inactive) made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              sameer Sameer Shanbhag (Inactive) made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              sameer Sameer Shanbhag (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              sameer Sameer Shanbhag (Inactive) made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              sameer Sameer Shanbhag (Inactive) made changes -
              Assignee Sameer Shanbhag [ sameer ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked lower
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Field Original Value New Value
              Epic Link IGBF-1388 [ 17463 ]
              ann.loraine Ann Loraine created issue -

                People

                • Assignee:
                  sameer Sameer Shanbhag (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: