Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2141

Capture IP address of App submitter when they upload an App (in release and submit_app)

        Details

        • Type: New Feature
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Keep track of IP addresses of computers that upload App jar files to the App Store.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              sameer Sameer Shanbhag (Inactive) added a comment -

              Pull Request Submitted:

              https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff

              Show
              sameer Sameer Shanbhag (Inactive) added a comment - Pull Request Submitted: https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please see comment at https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff

              Not sure why default IP address is needed. This seems dangerous because it could mask bugs or maliciousness.

              Show
              ann.loraine Ann Loraine added a comment - Please see comment at https://bitbucket.org/lorainelab/appstore/pull-requests/162/igbf-2141-ip-address-addition-to-pending/diff Not sure why default IP address is needed. This seems dangerous because it could mask bugs or maliciousness.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              If you decide to keep the default IP address, please add a comment explaining why it is there.

              Show
              ann.loraine Ann Loraine added a comment - If you decide to keep the default IP address, please add a comment explaining why it is there.
              Hide
              Permalink
              sameer Sameer Shanbhag (Inactive) added a comment - - edited

              The Default IP address acts as a placeholder so that the value will never be null. But we can set null=True instead and the placeholder will no longer be required.
              I have updated the code and the Pull Request.

              https://bitbucket.org/lorainelab/appstore/pull-requests/164/igbf-2141/diff

              Show
              sameer Sameer Shanbhag (Inactive) added a comment - - edited The Default IP address acts as a placeholder so that the value will never be null. But we can set null=True instead and the placeholder will no longer be required. I have updated the code and the Pull Request. https://bitbucket.org/lorainelab/appstore/pull-requests/164/igbf-2141/diff
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Can this be deployed on devappstore 2 for testing ?

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Can this be deployed on devappstore 2 for testing ?
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Working as expected.

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Working as expected.

                People

                • Assignee:
                  sameer Sameer Shanbhag (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: