Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2143

Fix exporting whole frame svg on windows

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 10.2.0
    • Labels:
      None

      Description

      When trying to export an image from IGB 9.1.0 on windows, specifying 'whole frame' and saving as svg, clicking save does not close the export window, and an image file is created, but it is missing all elements except the menu bar and part of the bottom bar. I have attached the svg and a screenshot of it for easy viewing.

      I tried reseting preferences and deleting the IGB folder, but the issue persists. I tested v9.0.2 on a naive system and still experience the issue.

        Attachments

          Issue Links

            Activity

            Hide
            nfreese Nowlan Freese added a comment -

            Tested main branch installer on Windows and Mac.

            Was able to export whole frame svg on Windows. The svg file opened successfully in Inkscape and was able to be modified. No errors in log. Just to double check, I also checked on Mac and everything is working correctly.

            Closing ticket.

            Show
            nfreese Nowlan Freese added a comment - Tested main branch installer on Windows and Mac. Was able to export whole frame svg on Windows. The svg file opened successfully in Inkscape and was able to be modified. No errors in log. Just to double check, I also checked on Mac and everything is working correctly. Closing ticket.
            Hide
            ann.loraine Ann Loraine added a comment -

            Update:

            • New installers are built and deployed to early access section of bioviz.org.
            • Ready for testing.

            Suggestion for how to advertise / write about the new feature.

            • Create 2 svg image(s) of the same exact scene using released IGB version 10.1.0 and the new version (tip of main branch). Open them in an SVG file editor, like Adobe Illustrator, and compare.
            • Suggestion for images to compare: (1) Default home screen, (2) default view of Dec 2013 human genome assembly. (When you click the Mona Lisa image in the home screen, this Dec 2013 human genome assembly will automatically load.)

            Other images could also be useful. I recommend trying to make images that let you observe the improvements that the new code introduces.

            Show
            ann.loraine Ann Loraine added a comment - Update: New installers are built and deployed to early access section of bioviz.org. Ready for testing. Suggestion for how to advertise / write about the new feature. Create 2 svg image(s) of the same exact scene using released IGB version 10.1.0 and the new version (tip of main branch). Open them in an SVG file editor, like Adobe Illustrator, and compare. Suggestion for images to compare: (1) Default home screen, (2) default view of Dec 2013 human genome assembly. (When you click the Mona Lisa image in the home screen, this Dec 2013 human genome assembly will automatically load.) Other images could also be useful. I recommend trying to make images that let you observe the improvements that the new code introduces.
            Hide
            ann.loraine Ann Loraine added a comment -

            PR is merged.

            Show
            ann.loraine Ann Loraine added a comment - PR is merged.
            Hide
            pbhatia1 Pranav Bhatia (Inactive) added a comment -

            Pull request submitted.

            Show
            pbhatia1 Pranav Bhatia (Inactive) added a comment - Pull request submitted.
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on Windows using Pranav's IGBF-2143-2 branch and comparing the results to his release-10.1.0-2143 (release-10.1.0-2143 has whole frame export for svg enabled on Windows, but is otherwise just IGB 10.1.0 release).

            Was able to export whole frame svg on Windows. The svg file opened successfully in Inkscape and was able to be modified.

            Ready for pull request.

            Show
            nfreese Nowlan Freese added a comment - Tested on Windows using Pranav's IGBF-2143 -2 branch and comparing the results to his release-10.1.0-2143 (release-10.1.0-2143 has whole frame export for svg enabled on Windows, but is otherwise just IGB 10.1.0 release). Was able to export whole frame svg on Windows. The svg file opened successfully in Inkscape and was able to be modified. Ready for pull request.

              People

              • Assignee:
                pbhatia1 Pranav Bhatia (Inactive)
                Reporter:
                pbadzuh Philip Badzuh (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: