Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2187

Fix sorting by download count on all apps page

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          2
        • Epic Link:
        • Sprint:
          Fall 8 : 25 Nov to 6 Dec, Fall 9 : 9 Dec to 20 Dec, Spring 1 : 25 Dec to 17 Jan

          Description

          When on the 'All Apps' page, sorting by Downloads does not work. Sorting by Downloads works fine on specific category/tag pages.

          Debug and fix sort_app_buttons.js to allow for proper sorting.

            Attachments

            1. sort1.JPG
              108 kB
              Shamika Gajanan Kulkarni
            2. sort2.JPG
              103 kB
              Shamika Gajanan Kulkarni

              Issue Links

              relates to

              Task - A task that needs to be done. REL-33 Verify Appstore links and buttons

              • Major - Major loss of function.
              • Review Requested

                Activity

                Descending order - Click to sort in ascending order
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged but not yet deployed to https://dev-appstore-2.bioviz.org.

                Show
                ann.loraine Ann Loraine added a comment - Merged but not yet deployed to https://dev-appstore-2.bioviz.org .
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see PR here:
                https://bitbucket.org/lorainelab/appstore/pull-requests/199/igbf-2187-add-secondary-alphabetical/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see PR here: https://bitbucket.org/lorainelab/appstore/pull-requests/199/igbf-2187-add-secondary-alphabetical/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Deployed to https://dev-appstore-2.bioviz.org and ready for final testing.

                Show
                ann.loraine Ann Loraine added a comment - Deployed to https://dev-appstore-2.bioviz.org and ready for final testing.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Ready for PR.

                Show
                ann.loraine Ann Loraine added a comment - Ready for PR.
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                I have added secondary alphabetical sorting here:
                https://bitbucket.org/pbadzuh/appstore_pbdev/commits/090d21ac025ed8cb858362e2e3dee3fe8a68428b?at=IGBF-2187

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - I have added secondary alphabetical sorting here: https://bitbucket.org/pbadzuh/appstore_pbdev/commits/090d21ac025ed8cb858362e2e3dee3fe8a68428b?at=IGBF-2187
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                I am cool with a random sort. I would say: it is the developer's choice on this one.

                cc: Philip Badzuh and Shamika Gajanan Kulkarni

                Show
                ann.loraine Ann Loraine added a comment - I am cool with a random sort. I would say: it is the developer's choice on this one. cc: Philip Badzuh and Shamika Gajanan Kulkarni
                Hide
                Permalink
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited

                Tested the ticket. For multiple apps that have the highest and equal number of downloads, they are shuffled randomly after each sort. The sorting as per count is working perfectly fine.
                Question: Do we need to sort the apps with same download count alphabetically or should we let it be as it is?

                Kindly refer the screenshot for the same.
                The apps 23nMe SNP Converter, App for testing App Workflow and Find Annotations each have download count as 2, higher than the other apps.

                Prof. [~aloraine], Philip Badzuh

                Show
                shamika Shamika Gajanan Kulkarni (Inactive) added a comment - - edited Tested the ticket. For multiple apps that have the highest and equal number of downloads, they are shuffled randomly after each sort. The sorting as per count is working perfectly fine. Question: Do we need to sort the apps with same download count alphabetically or should we let it be as it is? Kindly refer the screenshot for the same. The apps 23nMe SNP Converter, App for testing App Workflow and Find Annotations each have download count as 2, higher than the other apps. Prof. [~aloraine] , Philip Badzuh
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged but not yet deployed on dev-appstore-2.

                Show
                ann.loraine Ann Loraine added a comment - Merged but not yet deployed on dev-appstore-2.
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see PR here:
                https://bitbucket.org/lorainelab/appstore/pull-requests/193/igbf-2187-fix-sorting-by-download-count-on/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see PR here: https://bitbucket.org/lorainelab/appstore/pull-requests/193/igbf-2187-fix-sorting-by-download-count-on/diff
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                I fixed the issue with a simple change that can be seen below. I think the whitespace additions/deletions are an atom issue, as I didn't make them directly. Please review: https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2187#diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - I fixed the issue with a simple change that can be seen below. I think the whitespace additions/deletions are an atom issue, as I didn't make them directly. Please review: https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2187#diff

                  People

                  • Assignee:
                    pbadzuh Philip Badzuh (Inactive)
                    Reporter:
                    pbadzuh Philip Badzuh (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: