Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2201

Fix app rating system

        Details

        • Type: Bug
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          • Pooja Nikhare noticed that users are notified with a banner message which thanks them for rating an app when they are signed out, but that the same does not occur when they are signed in.

          Investigate and fix to:

          • only allow signed in users to rate apps
          • prompt users to sign in if they attempt to rate an app when signed out

            Attachments

              Issue Links

              relates to

              Improvement - An improvement or enhancement to an existing feature or task. IGBF-2184 Remove code that hides messages after a timeout

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please review the changes on my branch:
                https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2201#diff

                The existing design had already been set to only allow authenticated users to rate apps, however, users that were signed out could interact with the rating stars and would receive a notification confirming their nonactual rating.

                Branch changes:

                • fixes a bug that was preventing a user from rating an app when signed in
                • modifies the message a user receives after attempting to rate an app when signed out
                • makes stars unclickable for signed out users
                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please review the changes on my branch: https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2201#diff The existing design had already been set to only allow authenticated users to rate apps, however, users that were signed out could interact with the rating stars and would receive a notification confirming their nonactual rating. Branch changes: fixes a bug that was preventing a user from rating an app when signed in modifies the message a user receives after attempting to rate an app when signed out makes stars unclickable for signed out users
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Code looks good. Please proceed with PR.

                Thank you Philip Badzuh.

                Show
                ann.loraine Ann Loraine added a comment - Code looks good. Please proceed with PR. Thank you Philip Badzuh .
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see PR here:
                https://bitbucket.org/lorainelab/appstore/pull-requests/198/igbf-2201-fix-app-rating-system/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see PR here: https://bitbucket.org/lorainelab/appstore/pull-requests/198/igbf-2201-fix-app-rating-system/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged, not yet deployed on https://dev-appstore-2.bioviz.org.

                Show
                ann.loraine Ann Loraine added a comment - Merged, not yet deployed on https://dev-appstore-2.bioviz.org .
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Deployed to https://dev-appstore-2.bioviz.org and ready for final testing.

                Show
                ann.loraine Ann Loraine added a comment - Deployed to https://dev-appstore-2.bioviz.org and ready for final testing.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Pooja Nikhare please review and test when you get back.

                Show
                ann.loraine Ann Loraine added a comment - Pooja Nikhare please review and test when you get back.
                Hide
                Permalink
                pooja.nikhare Pooja Nikhare (Inactive) added a comment -

                Tested on https://dev-appstore-2.bioviz.org .
                Observed following :

                • When an unsigned User gives rating . Message shown is " Please sign in to rate an App".
                • When signed in User gives rating. Message shown is "Rating Updated ! Thank you for the input."
                  Code works fine. Moving the ticket to completed.
                Show
                pooja.nikhare Pooja Nikhare (Inactive) added a comment - Tested on https://dev-appstore-2.bioviz.org . Observed following : When an unsigned User gives rating . Message shown is " Please sign in to rate an App". When signed in User gives rating. Message shown is "Rating Updated ! Thank you for the input." Code works fine. Moving the ticket to completed.

                  People

                  • Assignee:
                    pooja.nikhare Pooja Nikhare (Inactive)
                    Reporter:
                    pbadzuh Philip Badzuh (Inactive)
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: