Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:2
-
Epic Link:
-
Sprint:Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan
Description
- Pooja Nikhare noticed that users are notified with a banner message which thanks them for rating an app when they are signed out, but that the same does not occur when they are signed in.
Investigate and fix to:
- only allow signed in users to rate apps
- prompt users to sign in if they attempt to rate an app when signed out
Attachments
Issue Links
- relates to
-
IGBF-2184 Remove code that hides messages after a timeout
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1388 [ 17463 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
Code looks good. Please proceed with PR.
Thank you Philip Badzuh.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
Merged, not yet deployed on https://dev-appstore-2.bioviz.org.
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed to https://dev-appstore-2.bioviz.org and ready for final testing.
| Sprint | Fall 9 : 9 Dec to 20 Dec [ 80 ] | Fall 9 : 9 Dec to 20 Dec, Spring 1 : 6 Jan to 17 Jan [ 80, 84 ] |
| Rank | Ranked higher |
| Sprint | Fall 9 : 9 Dec to 20 Dec, Spring 1 : 25 Dec to 17 Jan [ 80, 84 ] | Fall 9 : 9 Dec to 20 Dec, Spring 2 : 20 Jan to 31 Jan [ 80, 85 ] |
| Rank | Ranked lower |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
Pooja Nikhare please review and test when you get back.
Tested on https://dev-appstore-2.bioviz.org .
Observed following :
- When an unsigned User gives rating . Message shown is " Please sign in to rate an App".
- When signed in User gives rating. Message shown is "Rating Updated ! Thank you for the input."
Code works fine. Moving the ticket to completed.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Please review the changes on my branch:
https://bitbucket.org/pbadzuh/appstore_pbdev/branch/IGBF-2201#diff
The existing design had already been set to only allow authenticated users to rate apps, however, users that were signed out could interact with the rating stars and would receive a notification confirming their nonactual rating.
Branch changes: