Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2250

Add new module to IGB project POMs as dependency in the correct places

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Critical
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          There is now a new plugin module for the project.

          For the next step, we need to add it to the various POMs in the project:

          • parent aggregator POM (as a module)

          We will also likely need to add it to sub-project POMs - you will need to do some research to check that this is right!:

          • main - to ensure it gets packaged with IGB builds for testing
          • shared-lib-wrapper - to ensure it gets copied to the bundles location so that you can test while developing IGB

          To test:

          • Build the project on your local computer
          • Unpack igb_exe.jar - check that the genotyping bundle is included
          • Look in "bundles" in the project directory; check that the genotyping bundle is in bundles/dynamic

          Check for genotyping bundle while running IGB:

          • Run IGB using igb_exe.jar
          • Open the felix console
          • Check that the genotyping bundle is there

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              stiwari8 Srishti Tiwari (Inactive) added a comment -

              Ready for first-level review:

              https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/6468f37

              Verified bundles directory "bundles/dynamic", igb_exe.jar and Felix console and found that the genotyping bundle is included.

              Show
              stiwari8 Srishti Tiwari (Inactive) added a comment - Ready for first-level review: https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/6468f37 Verified bundles directory "bundles/dynamic", igb_exe.jar and Felix console and found that the genotyping bundle is included.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              I did not do functional review as the changes looked correct.
              Please submit PR.

              Show
              ann.loraine Ann Loraine added a comment - I did not do functional review as the changes looked correct. Please submit PR.
              Hide
              Permalink
              stiwari8 Srishti Tiwari (Inactive) added a comment -

              PR Submitted:

              https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/771/igbf-2250-add-new-module-to-igb-project/diff

              Show
              stiwari8 Srishti Tiwari (Inactive) added a comment - PR Submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/771/igbf-2250-add-new-module-to-igb-project/diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged and ready for testing.

              Show
              ann.loraine Ann Loraine added a comment - Merged and ready for testing.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Srishti Tiwari - can you check into why the build has failed on master branch?

              Show
              ann.loraine Ann Loraine added a comment - Srishti Tiwari - can you check into why the build has failed on master branch?
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Srishti Tiwari - never mind — it is a problem with https://nexus.bioviz.org

              Show
              ann.loraine Ann Loraine added a comment - Srishti Tiwari - never mind — it is a problem with https://nexus.bioviz.org
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Rebooted apache on nexus.bioviz.org.

              Show
              ann.loraine Ann Loraine added a comment - Rebooted apache on nexus.bioviz.org.
              Hide
              Permalink
              stiwari8 Srishti Tiwari (Inactive) added a comment -

              Hi Professor,
              Is there anything more that needs to be done on this ticket?

              Show
              stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Professor, Is there anything more that needs to be done on this ticket?
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Srishti Tiwari It now working fine. The problem was due to nexus.bioviz.org being down.

              Show
              ann.loraine Ann Loraine added a comment - Srishti Tiwari It now working fine. The problem was due to nexus.bioviz.org being down.

                People

                • Assignee:
                  stiwari8 Srishti Tiwari (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: