Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2250

Add new module to IGB project POMs as dependency in the correct places

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Critical
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      There is now a new plugin module for the project.

      For the next step, we need to add it to the various POMs in the project:

      • parent aggregator POM (as a module)

      We will also likely need to add it to sub-project POMs - you will need to do some research to check that this is right!:

      • main - to ensure it gets packaged with IGB builds for testing
      • shared-lib-wrapper - to ensure it gets copied to the bundles location so that you can test while developing IGB

      To test:

      • Build the project on your local computer
      • Unpack igb_exe.jar - check that the genotyping bundle is included
      • Look in "bundles" in the project directory; check that the genotyping bundle is in bundles/dynamic

      Check for genotyping bundle while running IGB:

      • Run IGB using igb_exe.jar
      • Open the felix console
      • Check that the genotyping bundle is there

        Attachments

          Activity

          ann.loraine Ann Loraine created issue -
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Epic Link IGBF-2246 [ 18393 ]
          ann.loraine Ann Loraine made changes -
          Priority Major [ 3 ] Blocker [ 1 ]
          ann.loraine Ann Loraine made changes -
          Priority Blocker [ 1 ] Critical [ 2 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          stiwari8 Srishti Tiwari (Inactive) made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          Hide
          stiwari8 Srishti Tiwari (Inactive) added a comment -

          Ready for first-level review:

          https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/6468f37

          Verified bundles directory "bundles/dynamic", igb_exe.jar and Felix console and found that the genotyping bundle is included.

          Show
          stiwari8 Srishti Tiwari (Inactive) added a comment - Ready for first-level review: https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/6468f37 Verified bundles directory "bundles/dynamic", igb_exe.jar and Felix console and found that the genotyping bundle is included.
          stiwari8 Srishti Tiwari (Inactive) made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          stiwari8 Srishti Tiwari (Inactive) made changes -
          Assignee Srishti Tiwari [ stiwari8 ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ]
          Hide
          ann.loraine Ann Loraine added a comment -

          I did not do functional review as the changes looked correct.
          Please submit PR.

          Show
          ann.loraine Ann Loraine added a comment - I did not do functional review as the changes looked correct. Please submit PR.
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ] Srishti Tiwari [ stiwari8 ]
          Show
          stiwari8 Srishti Tiwari (Inactive) added a comment - PR Submitted: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/771/igbf-2250-add-new-module-to-igb-project/diff
          stiwari8 Srishti Tiwari (Inactive) made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          stiwari8 Srishti Tiwari (Inactive) made changes -
          Assignee Srishti Tiwari [ stiwari8 ] Ann Loraine [ aloraine ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged and ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - Merged and ready for testing.
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
          ann.loraine Ann Loraine made changes -
          Assignee Ann Loraine [ aloraine ] Srishti Tiwari [ stiwari8 ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Srishti Tiwari - can you check into why the build has failed on master branch?

          Show
          ann.loraine Ann Loraine added a comment - Srishti Tiwari - can you check into why the build has failed on master branch?
          Hide
          ann.loraine Ann Loraine added a comment -

          Srishti Tiwari - never mind — it is a problem with https://nexus.bioviz.org

          Show
          ann.loraine Ann Loraine added a comment - Srishti Tiwari - never mind — it is a problem with https://nexus.bioviz.org
          Hide
          ann.loraine Ann Loraine added a comment -

          Rebooted apache on nexus.bioviz.org.

          Show
          ann.loraine Ann Loraine added a comment - Rebooted apache on nexus.bioviz.org.
          ann.loraine Ann Loraine made changes -
          Sprint Spring 3 : 3 Feb to 14 Feb [ 86 ] Spring 3 : 3 Feb to 14 Feb, Spring 3 : 17 Feb to 21 Feb [ 86, 87 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          Hide
          stiwari8 Srishti Tiwari (Inactive) added a comment -

          Hi Professor,
          Is there anything more that needs to be done on this ticket?

          Show
          stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Professor, Is there anything more that needs to be done on this ticket?
          Hide
          ann.loraine Ann Loraine added a comment -

          Srishti Tiwari It now working fine. The problem was due to nexus.bioviz.org being down.

          Show
          ann.loraine Ann Loraine added a comment - Srishti Tiwari It now working fine. The problem was due to nexus.bioviz.org being down.
          ann.loraine Ann Loraine made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          ann.loraine Ann Loraine made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          ann.loraine Ann Loraine made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          ann.loraine Ann Loraine made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          ann.loraine Ann Loraine made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          ann.loraine Ann Loraine made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          ann.loraine Ann Loraine made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

            People

            • Assignee:
              stiwari8 Srishti Tiwari (Inactive)
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: