Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2270

Fix: ERROR message about too many sequences

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      When a user opens the Xenopus tropicalis genome, several popups appear that say:

      "The file contains data for too many seuence; some may not be shown."

      Do not show this message.

        Attachments

          Activity

          ann.loraine Ann Loraine created issue -
          ann.loraine Ann Loraine made changes -
          Field Original Value New Value
          Epic Link IGBF-1765 [ 17855 ]
          ann.loraine Ann Loraine made changes -
          Rank Ranked higher
          ann.loraine Ann Loraine made changes -
          Sprint Spring 3 : 17 Feb to 21 Feb [ 87 ]
          nfreese Nowlan Freese made changes -
          Assignee Nowlan Freese [ nfreese ]
          nfreese Nowlan Freese made changes -
          Status To-Do [ 10305 ] In Progress [ 3 ]
          nfreese Nowlan Freese made changes -
          Summary Fix: ERROR message about two many sequences Fix: ERROR message about too many sequences
          Hide
          nfreese Nowlan Freese added a comment -

          Branch with changes: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-2270-manySeqMessage

          To test:
          In IGB, open Xenopus tropicalis Nov 2009. The console should log the warning:
          "The file contains data for too many sequences; some may not be shown. If this is a problem, please compress and index the file using tabix."
          No popups regarding the warning should occur.

          I changed the handling of the issue so that instead of presenting the user with a popup it is logged to the console.

          There seems to be several things going on with this issue.
          1) The X tropicalis Nov 2009 refgene file (X_tropicalis_Nov_2009_refGene.bed.gz) is gzipped, but does not have a tabix index.
          2) This issue is related to https://jira.transvar.org/browse/IGBF-33. However, IGBF-33 did not fully address the original issue, which was meant to be addressed by additional refactoring that never occurred (https://jira.transvar.org/browse/DB-166).

          Show
          nfreese Nowlan Freese added a comment - Branch with changes: https://bitbucket.org/nfreese/nowlanfork-igb/branch/IGBF-2270-manySeqMessage To test: In IGB, open Xenopus tropicalis Nov 2009. The console should log the warning: "The file contains data for too many sequences; some may not be shown. If this is a problem, please compress and index the file using tabix." No popups regarding the warning should occur. I changed the handling of the issue so that instead of presenting the user with a popup it is logged to the console. There seems to be several things going on with this issue. 1) The X tropicalis Nov 2009 refgene file (X_tropicalis_Nov_2009_refGene.bed.gz) is gzipped, but does not have a tabix index. 2) This issue is related to https://jira.transvar.org/browse/IGBF-33 . However, IGBF-33 did not fully address the original issue, which was meant to be addressed by additional refactoring that never occurred ( https://jira.transvar.org/browse/DB-166 ).
          nfreese Nowlan Freese made changes -
          Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
          nfreese Nowlan Freese made changes -
          Assignee Nowlan Freese [ nfreese ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Thank you!

          Show
          ann.loraine Ann Loraine added a comment - Thank you!
          Hide
          prutha Prutha Kulkarni (Inactive) added a comment - - edited

          I just reviewed the changes that are made for the same in order to remove the error panel that was showing message: "The file contains data for too many sequences; some may not be shown. If this is a problem, please compress and index the file using tabix.". A logger is added instead of the error panel which is showing the same message in the console.
          I have also tested it with IGB and it looks fine. Attaching screenshot for the reference.
          Please submit a PR for the same.

          Show
          prutha Prutha Kulkarni (Inactive) added a comment - - edited I just reviewed the changes that are made for the same in order to remove the error panel that was showing message: "The file contains data for too many sequences; some may not be shown. If this is a problem, please compress and index the file using tabix.". A logger is added instead of the error panel which is showing the same message in the console. I have also tested it with IGB and it looks fine. Attaching screenshot for the reference. Please submit a PR for the same.
          prutha Prutha Kulkarni (Inactive) made changes -
          Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
          prutha Prutha Kulkarni (Inactive) made changes -
          Assignee Prutha Kulkarni [ prutha ]
          prutha Prutha Kulkarni (Inactive) made changes -
          prutha Prutha Kulkarni (Inactive) made changes -
          Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
          prutha Prutha Kulkarni (Inactive) made changes -
          Assignee Prutha Kulkarni [ prutha ] Nowlan Freese [ nfreese ]
          Show
          nfreese Nowlan Freese added a comment - PR submitted https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/772/igbf-2270-replace-call-to-errorpanel-with/diff
          nfreese Nowlan Freese made changes -
          Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
          nfreese Nowlan Freese made changes -
          Assignee Nowlan Freese [ nfreese ] Ann Loraine [ aloraine ]
          Hide
          ann.loraine Ann Loraine added a comment -

          Merged and ready for testing.

          Show
          ann.loraine Ann Loraine added a comment - Merged and ready for testing.
          ann.loraine Ann Loraine made changes -
          Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
          ann.loraine Ann Loraine made changes -
          Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
          nfreese Nowlan Freese made changes -
          Sprint Spring 3 : 17 Feb to 28 Feb [ 87 ] Spring 3 : 17 Feb to 28 Feb, Spring 4 : 2 Mar to 13 Mar [ 87, 89 ]
          nfreese Nowlan Freese made changes -
          Rank Ranked higher
          noor91zahara Noor Zahara (Inactive) made changes -
          Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Ann Loraine [ aloraine ] Noor Zahara [ noor91zahara ]
          Hide
          noor91zahara Noor Zahara (Inactive) added a comment -

          It works as expected. No pop-up is shown with the error but is logged on the consoled.

          Show
          noor91zahara Noor Zahara (Inactive) added a comment - It works as expected. No pop-up is shown with the error but is logged on the consoled.
          noor91zahara Noor Zahara (Inactive) made changes -
          Assignee Noor Zahara [ noor91zahara ] Nowlan Freese [ nfreese ]
          noor91zahara Noor Zahara (Inactive) made changes -
          Resolution Done [ 10000 ]
          Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

            People

            • Assignee:
              nfreese Nowlan Freese
              Reporter:
              ann.loraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: