Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2291

Upgrade JDK version to 1.8.0.241 for loraine lab java repositories

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1.5
    • Sprint:
      Spring 5 : 16 Mar to 27 Mar, Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul

      Description

      Upgrade JDK version to 1.8.0.241 for all the loraine lab java repositories that are using bitbucket pipelines.

      Change the image tag name in bitbucket pipeline and install 4j files.

        Attachments

          Issue Links

            Activity

            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            [~aloraine] -

            Could you help me figure out the repositories which needs an upgrade?

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - [~aloraine] - Could you help me figure out the repositories which needs an upgrade?
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Sure. Here are some options:

            • If you log in to bitbucket and visit https://bitbucket.org/lorainelab/ you *may* see a green check (or exclamation point) in the "Builds" column. But you might not – I am not sure if your user would be able to view build status. Anyway, any repo with a check mark is getting built using the Docker image and needs to be updated.
            • Any repository with a "bitbucket_pipelines.yml" file. Unfortunately there does not seem to be a way to search for repositories with that file using the bitbucket interface.
            • Go to: https://bitbucket.org/lorainelab/profile/projects. Every repository in the "IGB Apps" project should have a bitbucket_pipelines.yml" file which needs to be updated to use the new Docker image.
            • Also go to: https://bitbucket.org/account/user/lorainelab/projects/IGB. Projects that need to be updated include: GenoViz SDK, GenoViz SDK Demos, IGB for Testing App Workflow, Integrated Genome Browser.

            Also, I see you have updated "JRE Bundles Install4j" Downloads section. Thanks!

            Show
            ann.loraine Ann Loraine added a comment - - edited Sure. Here are some options: If you log in to bitbucket and visit https://bitbucket.org/lorainelab/ you * may * see a green check (or exclamation point) in the "Builds" column. But you might not – I am not sure if your user would be able to view build status. Anyway, any repo with a check mark is getting built using the Docker image and needs to be updated. Any repository with a "bitbucket_pipelines.yml" file. Unfortunately there does not seem to be a way to search for repositories with that file using the bitbucket interface. Go to: https://bitbucket.org/lorainelab/profile/projects . Every repository in the "IGB Apps" project should have a bitbucket_pipelines.yml" file which needs to be updated to use the new Docker image. Also go to: https://bitbucket.org/account/user/lorainelab/projects/IGB . Projects that need to be updated include: GenoViz SDK, GenoViz SDK Demos, IGB for Testing App Workflow, Integrated Genome Browser. Also, I see you have updated "JRE Bundles Install4j" Downloads section. Thanks!
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - - edited Code changes to the repositories - https://bitbucket.org/noorzahara/2bit-reader-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/genoviz-sdk-demos-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/igb-for-testing-app-workflow-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/app-for-testing-app-workflow-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/get-average-score-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/23andme-snp-converter-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/bundlemarkdownencoder-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/command-socket-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/experimental-apps-for-igb-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/geometric-mean-operator-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/merge-annotation-operator-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/protannot-local/branch/IGBF-2291#diff https://bitbucket.org/noorzahara/super-simple-igb-app-local/branch/IGBF-2291#diff https://bitbucket.org/nzahara/genoviz-sdk-local/branch/IGBF-2291#diff Testing steps - Follow the readme in each repositories.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            I have reviewed each of the above links. I was not able to test the 'App for testing App workflow' since the downloads link did not contain repository.xml file. Noor Zahara can you please look into it and rebuild your branch? Rest all are working fine.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - I have reviewed each of the above links. I was not able to test the 'App for testing App workflow' since the downloads link did not contain repository.xml file. Noor Zahara can you please look into it and rebuild your branch? Rest all are working fine.
            Hide
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment -

            I have tested the 'App for testing App workflow' using Appstore. It is working fine. Noor Zahara please submit a PR for the same.

            Show
            shamika Shamika Gajanan Kulkarni (Inactive) added a comment - I have tested the 'App for testing App workflow' using Appstore. It is working fine. Noor Zahara please submit a PR for the same.
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -
            Show
            noor91zahara Noor Zahara (Inactive) added a comment - PR Created https://bitbucket.org/lorainelab/2bit-reader/pull-requests/4/igbf-2291/diff https://bitbucket.org/lorainelab/genoviz-sdk-demos/pull-requests/3/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/igb-for-testing-app-workflow/pull-requests/1/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/app-for-testing-app-workflow/pull-requests/1/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/get-average-score/pull-requests/7/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/23andme-snp-converter/pull-requests/9/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/bundlemarkdownencoder/pull-requests/2/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/command-socket/pull-requests/15/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/experimental-apps-for-igb/pull-requests/11/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/geometric-mean-operator/pull-requests/10/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/protannot/pull-requests/13/igbf-2291-upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/super-simple-igb-app/pull-requests/10/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/genoviz-sdk/pull-requests/19/upgrade-jdk-version-to-180241/diff https://bitbucket.org/lorainelab/merge-annotation-operator/pull-requests/12/upgrade-jdk-version-to-180241/diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Please check Command Socket PR for comment.
            cc: Noor Zahara

            Show
            ann.loraine Ann Loraine added a comment - Please check Command Socket PR for comment. cc: Noor Zahara
            Hide
            noor91zahara Noor Zahara (Inactive) added a comment -

            I have removed the git.properties file

            Show
            noor91zahara Noor Zahara (Inactive) added a comment - I have removed the git.properties file
            Hide
            ann.loraine Ann Loraine added a comment -

            Command socket merged.
            Moving to "Ready for Testing" as all PRs are now merged to their respective master branches.

            Show
            ann.loraine Ann Loraine added a comment - Command socket merged. Moving to "Ready for Testing" as all PRs are now merged to their respective master branches.
            Hide
            pbadzuh Philip Badzuh (Inactive) added a comment - - edited

            All projects were successfully built, except for 'igb-for-testing-app-workflow', which fails at genometry tests, with the following exception:

            [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project genometry: There are test failures.

            All project except the above that failed to build can be successfully installed using IGB app manager. Tested on macOS

            Update: The error seems to the same one that was fixed in IGBF-2357. However, the repo below is behind the main IGB repo containing the merged fix.

            https://bitbucket.org/lorainelab/igb-for-testing-app-workflow/src/Mock-rel-9.1.0/

            Show
            pbadzuh Philip Badzuh (Inactive) added a comment - - edited All projects were successfully built, except for 'igb-for-testing-app-workflow', which fails at genometry tests, with the following exception: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19:test (default-test) on project genometry: There are test failures. All project except the above that failed to build can be successfully installed using IGB app manager. Tested on macOS Update: The error seems to the same one that was fixed in IGBF-2357 . However, the repo below is behind the main IGB repo containing the merged fix. https://bitbucket.org/lorainelab/igb-for-testing-app-workflow/src/Mock-rel-9.1.0/
            Hide
            ann.loraine Ann Loraine added a comment -

            To fix, Loraine needs to pull changes from main repo into this fork.

            Show
            ann.loraine Ann Loraine added a comment - To fix, Loraine needs to pull changes from main repo into this fork.
            Hide
            ann.loraine Ann Loraine added a comment -

            Pull changes and now the fork builds. Moving to closed.

            Show
            ann.loraine Ann Loraine added a comment - Pull changes and now the fork builds. Moving to closed.

              People

              • Assignee:
                ann.loraine Ann Loraine
                Reporter:
                noor91zahara Noor Zahara (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: