[IGBF-2312] Add test cases to validate parseLineToDataModel in TwentyThreeAndMeSymLoader.java - JIRA UNCC

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Done
Affects Version/s: None
Fix Version/s: None
Labels:
None

Story Points:
0.5
Epic Link:
Show personal genotype
Sprint:
Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun

Description

Srishti Tiwari has been working the new 23 and Me personal genome visualization app.

She is using a branch on her fork but will be submitting a PR very soon to merge the latest changes into the team repository. Until then, this branch has the latest code:
https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2253

For this task, add unit tests that test the method "parseLineToDataModel" in TwentyThreeAndMeSymLoader.java

Talk with Srishti Tiwari about the expected output.

To start, you write test cases for

Proper behavior when encountering incorrect data
Proper behavior when encountered correct data
Sanity checking - validating business logic (hardest to do)

Attachments

Activity

Ascending order - Click to sort in descending order

Ann Loraine created issue - 01/Apr/20 11:25 AM

Ann Loraine made changes - 01/Apr/20 11:25 AM

Field	Original Value	New Value
Epic Link		~~IGBF-2246~~ [ 18393 ]

Ann Loraine made changes - 01/Apr/20 11:25 AM

Rank

Ranked higher

Ann Loraine made changes - 01/Apr/20 11:26 AM

Summary

Add test cases to

Add test cases to validate parseLineToDataModel in

Ann Loraine made changes - 01/Apr/20 11:26 AM

Summary

Add test cases to validate parseLineToDataModel in

Add test cases to validate parseLineToDataModel in TwentyThreeAndMeSymLoader.java

Noor Zahara (Inactive) made changes - 01/Apr/20 11:57 AM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Hide

Permalink

Ann Loraine added a comment - 01/Apr/20 12:00 PM

Test cases from NCBI Primer App that can provide some guidance:

See commits titled "~~IGBF-2258~~" on this branch https://bitbucket.org/pnikhare/experimental-apps-for-igb/branch/IGBF-2287

Show

Ann Loraine added a comment - 01/Apr/20 12:00 PM Test cases from NCBI Primer App that can provide some guidance: See commits titled " IGBF-2258 " on this branch https://bitbucket.org/pnikhare/experimental-apps-for-igb/branch/IGBF-2287

Hide

Permalink

Ann Loraine added a comment - 03/Apr/20 2:04 PM

Please rebase onto latest master.
Then please add links to your branch with new test cases.

cc: Noor Zahara

Show

Ann Loraine added a comment - 03/Apr/20 2:04 PM Please rebase onto latest master. Then please add links to your branch with new test cases. cc: Noor Zahara

Hide

Permalink

Noor Zahara (Inactive) added a comment - 08/Apr/20 9:57 AM

Code change - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2312#diff

Show

Noor Zahara (Inactive) added a comment - 08/Apr/20 9:57 AM Code change - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2312#diff

Noor Zahara (Inactive) made changes - 08/Apr/20 9:57 AM

Status

In Progress [ 3 ]

Needs 1st Level Review [ 10005 ]

Noor Zahara (Inactive) made changes - 08/Apr/20 9:57 AM

Assignee

Noor Zahara [ noor91zahara ]

Hide

Permalink

Ann Loraine added a comment - 13/Apr/20 7:36 PM

Hello Srishti Tiwari:

Please review the first draft testing code developed by Noor Zahara.

Mainly please check that the tests she has written can pass.

We will add and modify it in the next round of work.

Thank you!

Show

Ann Loraine added a comment - 13/Apr/20 7:36 PM Hello Srishti Tiwari : Please review the first draft testing code developed by Noor Zahara . Mainly please check that the tests she has written can pass. We will add and modify it in the next round of work. Thank you!

Ann Loraine made changes - 13/Apr/20 7:36 PM

Assignee

Srishti Tiwari [ stiwari8 ]

Ann Loraine made changes - 13/Apr/20 7:47 PM

Sprint

Spring 6 : 30 Mar to Apr 10 [ 91 ]

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr [ 91, 92 ]

Ann Loraine made changes - 13/Apr/20 7:48 PM

Rank

Ranked higher

Srishti Tiwari (Inactive) made changes - 15/Apr/20 2:23 PM

Status

Needs 1st Level Review [ 10005 ]

First Level Review in Progress [ 10301 ]

Hide

Permalink

Srishti Tiwari (Inactive) added a comment - 16/Apr/20 9:59 AM

Hi Noor,

Could you please rebuild the branch ~~IGBF-2312~~ on bitbucket?
I cloned your repository and built it successfully today.

Thanks!

Show

Srishti Tiwari (Inactive) added a comment - 16/Apr/20 9:59 AM Hi Noor, Could you please rebuild the branch IGBF-2312 on bitbucket? I cloned your repository and built it successfully today. Thanks!

Srishti Tiwari (Inactive) made changes - 16/Apr/20 10:00 AM

Assignee

Srishti Tiwari [ stiwari8 ]

Noor Zahara [ noor91zahara ]

Nowlan Freese made changes - 16/Apr/20 1:53 PM

Assignee

Noor Zahara [ noor91zahara ]

Nowlan Freese [ nfreese ]

Nowlan Freese made changes - 16/Apr/20 2:11 PM

Assignee

Nowlan Freese [ nfreese ]

Nowlan Freese made changes - 16/Apr/20 2:12 PM

Assignee

Srishti Tiwari [ stiwari8 ]

Hide

Permalink

Noor Zahara (Inactive) added a comment - 16/Apr/20 4:50 PM - edited

I have re-ran the pipeline. You can check now.

Show

Noor Zahara (Inactive) added a comment - 16/Apr/20 4:50 PM - edited I have re-ran the pipeline. You can check now.

Noor Zahara (Inactive) made changes - 16/Apr/20 4:50 PM

Status

First Level Review in Progress [ 10301 ]

Needs 1st Level Review [ 10005 ]

Srishti Tiwari (Inactive) made changes - 17/Apr/20 8:59 AM

Status

Needs 1st Level Review [ 10005 ]

First Level Review in Progress [ 10301 ]

Srishti Tiwari (Inactive) made changes - 17/Apr/20 8:59 AM

Status

First Level Review in Progress [ 10301 ]

Ready for Pull Request [ 10304 ]

Hide

Permalink

Srishti Tiwari (Inactive) added a comment - 17/Apr/20 9:00 AM

I tested on my end and it is working fine now. It is ready for pull request.

Show

Srishti Tiwari (Inactive) added a comment - 17/Apr/20 9:00 AM I tested on my end and it is working fine now. It is ready for pull request.

Srishti Tiwari (Inactive) made changes - 17/Apr/20 9:00 AM

Assignee

Srishti Tiwari [ stiwari8 ]

Noor Zahara [ noor91zahara ]

Hide

Permalink

Noor Zahara (Inactive) added a comment - 17/Apr/20 11:45 AM

PR- https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/788/igbf-2312-test-cases-for/diff

Show

Noor Zahara (Inactive) added a comment - 17/Apr/20 11:45 AM PR- https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/788/igbf-2312-test-cases-for/diff

Noor Zahara (Inactive) made changes - 17/Apr/20 11:45 AM

Status

Ready for Pull Request [ 10304 ]

Pull Request Submitted [ 10101 ]

Noor Zahara (Inactive) made changes - 17/Apr/20 11:45 AM

Assignee

Noor Zahara [ noor91zahara ]

Hide

Permalink

Ann Loraine added a comment - 17/Apr/20 12:01 PM

Great first draft! Lots of tests!
Please see comments in the PR for change requests.

Show

Ann Loraine added a comment - 17/Apr/20 12:01 PM Great first draft! Lots of tests! Please see comments in the PR for change requests.

Ann Loraine made changes - 17/Apr/20 12:01 PM

Status

Pull Request Submitted [ 10101 ]

Reviewing Pull Request [ 10303 ]

Ann Loraine made changes - 17/Apr/20 12:01 PM

Status

Reviewing Pull Request [ 10303 ]

To-Do [ 10305 ]

Noor Zahara (Inactive) made changes - 17/Apr/20 3:23 PM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Noor Zahara (Inactive) made changes - 17/Apr/20 3:23 PM

Assignee

Noor Zahara [ noor91zahara ]

Hide

Permalink

Noor Zahara (Inactive) added a comment - 17/Apr/20 3:23 PM

I have changed the code as per comments.

Show

Noor Zahara (Inactive) added a comment - 17/Apr/20 3:23 PM I have changed the code as per comments.

Noor Zahara (Inactive) made changes - 17/Apr/20 3:23 PM

Status

In Progress [ 3 ]

Needs 1st Level Review [ 10005 ]

Noor Zahara (Inactive) made changes - 17/Apr/20 3:23 PM

Status

Needs 1st Level Review [ 10005 ]

First Level Review in Progress [ 10301 ]

Noor Zahara (Inactive) made changes - 17/Apr/20 3:23 PM

Status

First Level Review in Progress [ 10301 ]

Ready for Pull Request [ 10304 ]

Noor Zahara (Inactive) made changes - 17/Apr/20 3:23 PM

Assignee

Noor Zahara [ noor91zahara ]

Hide

Permalink

Ann Loraine added a comment - 17/Apr/20 3:36 PM

Please take a look at latest comments.

Show

Ann Loraine added a comment - 17/Apr/20 3:36 PM Please take a look at latest comments.

Ann Loraine made changes - 17/Apr/20 3:37 PM

Status

Ready for Pull Request [ 10304 ]

Pull Request Submitted [ 10101 ]

Ann Loraine made changes - 17/Apr/20 3:37 PM

Status

Pull Request Submitted [ 10101 ]

Reviewing Pull Request [ 10303 ]

Ann Loraine made changes - 17/Apr/20 3:38 PM

Status

Reviewing Pull Request [ 10303 ]

To-Do [ 10305 ]

Hide

Permalink

Ann Loraine added a comment - 17/Apr/20 3:38 PM

Please take another look at the PR comments.

Show

Ann Loraine added a comment - 17/Apr/20 3:38 PM Please take another look at the PR comments.

Ann Loraine made changes - 17/Apr/20 3:38 PM

Assignee

Noor Zahara [ noor91zahara ]

Hide

Permalink

Noor Zahara (Inactive) added a comment - 22/Apr/20 10:04 AM

I have made the changes and also squashed the commits.

Show

Noor Zahara (Inactive) added a comment - 22/Apr/20 10:04 AM I have made the changes and also squashed the commits.

Ann Loraine made changes - 24/Apr/20 10:11 PM

Sprint

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr [ 91, 92 ]

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May [ 91, 92, 93 ]

Ann Loraine made changes - 24/Apr/20 10:12 PM

Rank

Ranked higher

Noor Zahara (Inactive) made changes - 29/Apr/20 10:05 AM

Status

To-Do [ 10305 ]

In Progress [ 3 ]

Noor Zahara (Inactive) made changes - 29/Apr/20 10:05 AM

Status

In Progress [ 3 ]

Needs 1st Level Review [ 10005 ]

Noor Zahara (Inactive) made changes - 29/Apr/20 10:05 AM

Assignee

Noor Zahara [ noor91zahara ]

Ann Loraine made changes - 01/May/20 9:49 AM

Status

Needs 1st Level Review [ 10005 ]

First Level Review in Progress [ 10301 ]

Ann Loraine made changes - 01/May/20 9:49 AM

Status

First Level Review in Progress [ 10301 ]

Ready for Pull Request [ 10304 ]

Hide

Permalink

Ann Loraine added a comment - 01/May/20 9:50 AM

Please submit PR.

Show

Ann Loraine added a comment - 01/May/20 9:50 AM Please submit PR.

Ann Loraine made changes - 01/May/20 9:50 AM

Assignee

Srishti Tiwari [ stiwari8 ]

Ann Loraine made changes - 01/May/20 9:50 AM

Assignee

Srishti Tiwari [ stiwari8 ]

Noor Zahara [ noor91zahara ]

Ann Loraine made changes - 01/May/20 9:50 AM

Status

Ready for Pull Request [ 10304 ]

Pull Request Submitted [ 10101 ]

Ann Loraine made changes - 01/May/20 9:51 AM

Status

Pull Request Submitted [ 10101 ]

Reviewing Pull Request [ 10303 ]

Ann Loraine made changes - 01/May/20 9:51 AM

Status

Reviewing Pull Request [ 10303 ]

Merged Needs Testing [ 10002 ]

Ann Loraine made changes - 01/May/20 9:51 AM

Assignee

Noor Zahara [ noor91zahara ]

Hide

Permalink

Ann Loraine added a comment - 01/May/20 9:51 AM

Merged and ready for testing.

Show

Ann Loraine added a comment - 01/May/20 9:51 AM Merged and ready for testing.

Ann Loraine made changes - 10/May/20 8:01 PM

Sprint

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May [ 91, 92, 93 ]

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 91, 92, 93, 94 ]

Ann Loraine made changes - 10/May/20 8:01 PM

Rank

Ranked higher

Ann Loraine made changes - 24/May/20 8:27 PM

Sprint

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 91, 92, 93, 94 ]

Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 91, 92, 93, 94, 95 ]

Ann Loraine made changes - 24/May/20 8:27 PM

Rank

Ranked higher

Ann Loraine made changes - 05/Jun/20 8:28 AM

Status

Merged Needs Testing [ 10002 ]

Post-merge Testing In Progress [ 10003 ]

Ann Loraine made changes - 05/Jun/20 8:28 AM

Resolution		Done [ 10000 ]
Status	Post-merge Testing In Progress [ 10003 ]	Closed [ 6 ]

Hide

Permalink

Ann Loraine added a comment - 05/Jun/20 8:29 AM - edited

Note: Not yet fully tested. Testing and validation will be first part of next development push.

Show

Ann Loraine added a comment - 05/Jun/20 8:29 AM - edited Note: Not yet fully tested. Testing and validation will be first part of next development push.

People

Assignee:

Unassigned

Reporter:

Ann Loraine

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

01/Apr/20 11:25 AM

Updated:

05/Jun/20 8:30 AM

Resolved:

05/Jun/20 8:28 AM