Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2312

Add test cases to validate parseLineToDataModel in TwentyThreeAndMeSymLoader.java

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          0.5
        • Epic Link:
        • Sprint:
          Spring 6 : 30 Mar to Apr 10, Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun

          Description

          Srishti Tiwari has been working the new 23 and Me personal genome visualization app.

          She is using a branch on her fork but will be submitting a PR very soon to merge the latest changes into the team repository. Until then, this branch has the latest code:
          https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2253

          For this task, add unit tests that test the method "parseLineToDataModel" in TwentyThreeAndMeSymLoader.java

          Talk with Srishti Tiwari about the expected output.

          To start, you write test cases for

          • Proper behavior when encountering incorrect data
          • Proper behavior when encountered correct data
          • Sanity checking - validating business logic (hardest to do)

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Test cases from NCBI Primer App that can provide some guidance:

              Show
              ann.loraine Ann Loraine added a comment - Test cases from NCBI Primer App that can provide some guidance: See commits titled " IGBF-2258 " on this branch https://bitbucket.org/pnikhare/experimental-apps-for-igb/branch/IGBF-2287
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please rebase onto latest master.
              Then please add links to your branch with new test cases.

              cc: Noor Zahara

              Show
              ann.loraine Ann Loraine added a comment - Please rebase onto latest master. Then please add links to your branch with new test cases. cc: Noor Zahara
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Code change - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2312#diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Code change - https://bitbucket.org/noorzahara/integrated-genome-browser-local1/branch/IGBF-2312#diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Hello Srishti Tiwari:

              Please review the first draft testing code developed by Noor Zahara.

              Mainly please check that the tests she has written can pass.

              We will add and modify it in the next round of work.

              Thank you!

              Show
              ann.loraine Ann Loraine added a comment - Hello Srishti Tiwari : Please review the first draft testing code developed by Noor Zahara . Mainly please check that the tests she has written can pass. We will add and modify it in the next round of work. Thank you!
              Hide
              Permalink
              stiwari8 Srishti Tiwari (Inactive) added a comment -

              Hi Noor,

              Could you please rebuild the branch IGBF-2312 on bitbucket?
              I cloned your repository and built it successfully today.

              Thanks!

              Show
              stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Noor, Could you please rebuild the branch IGBF-2312 on bitbucket? I cloned your repository and built it successfully today. Thanks!
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment - - edited

              I have re-ran the pipeline. You can check now.

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - - edited I have re-ran the pipeline. You can check now.
              Hide
              Permalink
              stiwari8 Srishti Tiwari (Inactive) added a comment -

              I tested on my end and it is working fine now. It is ready for pull request.

              Show
              stiwari8 Srishti Tiwari (Inactive) added a comment - I tested on my end and it is working fine now. It is ready for pull request.
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              PR- https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/788/igbf-2312-test-cases-for/diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - PR- https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/788/igbf-2312-test-cases-for/diff
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Great first draft! Lots of tests!
              Please see comments in the PR for change requests.

              Show
              ann.loraine Ann Loraine added a comment - Great first draft! Lots of tests! Please see comments in the PR for change requests.
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              I have changed the code as per comments.

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - I have changed the code as per comments.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please take a look at latest comments.

              Show
              ann.loraine Ann Loraine added a comment - Please take a look at latest comments.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please take another look at the PR comments.

              Show
              ann.loraine Ann Loraine added a comment - Please take another look at the PR comments.
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              I have made the changes and also squashed the commits.

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - I have made the changes and also squashed the commits.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Please submit PR.

              Show
              ann.loraine Ann Loraine added a comment - Please submit PR.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged and ready for testing.

              Show
              ann.loraine Ann Loraine added a comment - Merged and ready for testing.
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment - - edited

              Note: Not yet fully tested. Testing and validation will be first part of next development push.

              Show
              ann.loraine Ann Loraine added a comment - - edited Note: Not yet fully tested. Testing and validation will be first part of next development push.

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: