Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2319

Improve Primer Options tab - minor changes

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
        • Story Points:
          2
        • Epic Link:
        • Sprint:
          Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun, Fall 5, Fall 6

          Description

          NCBI Primer App is a tool that helps users design PCR primers to amplify DNA.

          The UI works fine but some of the UI elements are poorly worded or consume too much space.

          To improve it, make the following changes to the NCBI Primer Options tab UI:

          • Move components closer to their labels
          • Change wording: "Number of Primers to return" to: "Return primers:"
          • Change wording:"Custom forward primer" to "Forward Primer" (same for Reverse primer)
          • Change wording: "PCR product size" to "Product size"
          • Remove label "Specificity check" (the checkbox text explains what this is about – the label is not really needed)
          • Change "Enable search ...to the intended PCR template" to: "Design primer pairs specific to the selected target"
          • Reduce the size of the "Database" dropdown

          See: https://bitbucket.org/lorainelab/ncbi-primer/src/master/
          Also see: https://drive.google.com/file/d/1hmdG4pKfSBFZ412Ew-ikHJoDvNptJ0RX/view?usp=sharing

            Attachments

              Issue Links

              is blocked by

              Task - A task that needs to be done. IGBF-2317 Move NCBI Primer App to its own repository

              • Major - Major loss of function.
              • Closed
              relates to

              Task - A task that needs to be done. IGBF-3483 Investigate testcase failure

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -
                • Trying to add a jScrollPane Component to the UI which adds a horizontal scrollbar as doing the above-mentioned resizing also isn't allowing all the content to be inside the default layout and the user might not recognize that there is content beyond that.
                • Also, there is a test case failure when forking the master branch from the repository, created a new issue for investigating that testcase failure.
                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - Trying to add a jScrollPane Component to the UI which adds a horizontal scrollbar as doing the above-mentioned resizing also isn't allowing all the content to be inside the default layout and the user might not recognize that there is content beyond that. Also, there is a test case failure when forking the master branch from the repository, created a new issue for investigating that testcase failure.
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -

                Changes are done, scrollbars are also added to the component to make it accessible. Below is the fork where the updated code is: https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-2319

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - Changes are done, scrollbars are also added to the component to make it accessible. Below is the fork where the updated code is: https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-2319
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Testing on Mac:

                • I can see the horizontal/vertical scroll bars - great job!
                  • The horizontal scroll bar doesn't appear unless there is enough vertical space. Not sure if that is fixable.
                • The text in the Intron inclusion section (in the Exon/intron selection box) is jumbled (see comparison image attached to this ticket).
                • Change "Return Primes" to "Return primers:" and move the 10 box closer (see attached image).
                • Move the "Reset Default" button out of the "Post processing options" box. The Reset Default button resets all of the Primer Options settings.
                • The version of the app is still listed as 0.0.1. Most likely should be changed to 0.0.2.
                Show
                nfreese Nowlan Freese added a comment - Testing on Mac: I can see the horizontal/vertical scroll bars - great job! The horizontal scroll bar doesn't appear unless there is enough vertical space. Not sure if that is fixable. The text in the Intron inclusion section (in the Exon/intron selection box) is jumbled (see comparison image attached to this ticket). Change "Return Primes" to "Return primers:" and move the 10 box closer (see attached image). Move the "Reset Default" button out of the "Post processing options" box. The Reset Default button resets all of the Primer Options settings. The version of the app is still listed as 0.0.1. Most likely should be changed to 0.0.2.
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -

                I have made the changes according to the review and for the horizontal scroll bar to be visible, I have reduced the vertical size(height) of the jScrollPane which makes the horizontal scrollbar visible but not all the time. Please review and let me know if there are any other changes required. https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-2319

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - I have made the changes according to the review and for the horizontal scroll bar to be visible, I have reduced the vertical size(height) of the jScrollPane which makes the horizontal scrollbar visible but not all the time. Please review and let me know if there are any other changes required. https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-2319
                Hide
                Permalink
                nfreese Nowlan Freese added a comment - - edited

                Testing on Mac:

                • Change "Return Primes" to "Return primers:"
                • There doesn't seem to be a way to stretch the Primer Options window vertically. I can stretch it horizontally and see more of the window, but when I stretch it vertically the height of the window remains the same.
                Show
                nfreese Nowlan Freese added a comment - - edited Testing on Mac: Change "Return Primes" to "Return primers:" There doesn't seem to be a way to stretch the Primer Options window vertically. I can stretch it horizontally and see more of the window, but when I stretch it vertically the height of the window remains the same.
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment - - edited

                I have made the changes accordingly, I removed the old one and added a new jScrollPane, now it is working as expected I guess previously I might have changed any defaults by mistake. Please review and let me know if it need any further changes: https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-2319

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - - edited I have made the changes accordingly, I removed the old one and added a new jScrollPane, now it is working as expected I guess previously I might have changed any defaults by mistake. Please review and let me know if it need any further changes: https://bitbucket.org/jaya-sravani/ncbi-primer/branch/IGBF-2319
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Everything is working great.

                Ready for pull request.

                Show
                nfreese Nowlan Freese added a comment - Everything is working great. Ready for pull request.
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -

                Will raise a PR once this issue https://jira.bioviz.org/browse/IGBF-3483 PR is merged as it will raise conflicts.

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - Will raise a PR once this issue https://jira.bioviz.org/browse/IGBF-3483 PR is merged as it will raise conflicts.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Attn Jaya Sravani Sirigineedi: Please submit PR as the test case improvement is now merged to the master branch.

                Show
                ann.loraine Ann Loraine added a comment - Attn Jaya Sravani Sirigineedi : Please submit PR as the test case improvement is now merged to the master branch.
                Hide
                Permalink
                jsirigin Jaya Sravani Sirigineedi added a comment -

                PR has been raised: https://bitbucket.org/lorainelab/ncbi-primer/pull-requests/5

                Show
                jsirigin Jaya Sravani Sirigineedi added a comment - PR has been raised: https://bitbucket.org/lorainelab/ncbi-primer/pull-requests/5
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment - - edited

                The PR is merged and new artifact is built on the team repository.

                See: https://bitbucket.org/lorainelab/ncbi-primer/downloads/ for the new jar file newly available.

                Ready for testing.

                Show
                ann.loraine Ann Loraine added a comment - - edited The PR is merged and new artifact is built on the team repository. See: https://bitbucket.org/lorainelab/ncbi-primer/downloads/ for the new jar file newly available. Ready for testing.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Tested on Mac
                Added app from https://bitbucket.org/lorainelab/ncbi-primer/downloads/
                Vertical and horizontal scroll bars are working well.
                Text appears correct, spacing looks good.
                App appears as 0.0.2

                Closing ticket.

                Show
                nfreese Nowlan Freese added a comment - Tested on Mac Added app from https://bitbucket.org/lorainelab/ncbi-primer/downloads/ Vertical and horizontal scroll bars are working well. Text appears correct, spacing looks good. App appears as 0.0.2 Closing ticket.

                  People

                  • Assignee:
                    jsirigin Jaya Sravani Sirigineedi
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    3 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: