Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2329

Create GraphSyms from bai file directly

    Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May

      Description

      Currently, the BAI file reader is converting the BAI file to a temporary graph file, which is then getting read.

      It would be far more efficient to simply read the file directly and create a GraphSym out of it.

      For this task, modify the code to create a GraphSym instead of a BedGraph intermediate file. To do this, make a new SymLoader class that will be returned by the FileLoader class.

        Attachments

          Issue Links

            Activity

            Hide
            ann.loraine Ann Loraine added a comment - - edited

            As of today, Pawan is working on this branch:
            https://bitbucket.org/pawanbole/integrated-genome-browser-pawan/branch/IGBF-2221

            Review:

            • com.affymetrix.genometry.symloader

            esp. Wiggle.java which capture graph loading logic

            Show
            ann.loraine Ann Loraine added a comment - - edited As of today, Pawan is working on this branch: https://bitbucket.org/pawanbole/integrated-genome-browser-pawan/branch/IGBF-2221 Review: com.affymetrix.genometry.symloader esp. Wiggle.java which capture graph loading logic
            Show
            nfreese Nowlan Freese added a comment - Example bedgraph: http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/BedGraph/BedGraph_HomoSapien.bedGraph Example bai: http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/Bam/Bam_HomoSapien.bai
            Hide
            nfreese Nowlan Freese added a comment -

            Some example bai/bam files that Pawan and I have been using for testing: https://drive.google.com/drive/folders/1Y9krI6VX3vBzTKEcneGy1McnMJEK739m

            Show
            nfreese Nowlan Freese added a comment - Some example bai/bam files that Pawan and I have been using for testing: https://drive.google.com/drive/folders/1Y9krI6VX3vBzTKEcneGy1McnMJEK739m
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -

            I have converted the Output after bin comparison of chromosomes to and input stream instead of temp file and then parsing the data to create syms.
            Please review the changes :
            https://bitbucket.org/pnikhare/integrated-genome-browser/branch/IGBF-2329#diff

            Testing Steps:

            • View the local files under the data access tab
            • Verify the track name has .bai extension
            • Click on load data. The parsed data is loaded.

            cc : [~aloraine] , Nowlan Freese - I have not yet added changes from pawan's branch. I can do that once tested.

            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - I have converted the Output after bin comparison of chromosomes to and input stream instead of temp file and then parsing the data to create syms. Please review the changes : https://bitbucket.org/pnikhare/integrated-genome-browser/branch/IGBF-2329#diff Testing Steps: Use bai files given in the above comments Example bai: http://igbquickload.org/smokeTestingQuickload/H_sapiens_Dec_2013/Bam/Bam_HomoSapien.bai Click on Homo Sapien species and click on open file to select bai file View the local files under the data access tab Verify the track name has .bai extension Click on load data. The parsed data is loaded. cc : [~aloraine] , Nowlan Freese - I have not yet added changes from pawan's branch. I can do that once tested.
            Hide
            ann.loraine Ann Loraine added a comment -

            Lets test the basic functionality after the meeting.

            Depending on how that goes, please make a next draft of BaiSymLoader.java which removes unneeded code:

            • The bai format does not have track lines or comments. Remove code for parsing and handling track lines.
            • Check for code that is not called or does not override - and remove it.
            Show
            ann.loraine Ann Loraine added a comment - Lets test the basic functionality after the meeting. Depending on how that goes, please make a next draft of BaiSymLoader.java which removes unneeded code: The bai format does not have track lines or comments. Remove code for parsing and handling track lines. Check for code that is not called or does not override - and remove it.
            Hide
            pooja.nikhare Pooja Nikhare (Inactive) added a comment -
            Show
            pooja.nikhare Pooja Nikhare (Inactive) added a comment - Refactored BaiSymLoader file. Please review: https://bitbucket.org/pnikhare/integrated-genome-browser/branch/IGBF-2329#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            This looks fine to me and ready for PR.
            Pawan Bole and Nowlan Freese - could you also take a look?

            Show
            ann.loraine Ann Loraine added a comment - This looks fine to me and ready for PR. Pawan Bole and Nowlan Freese - could you also take a look?

              People

              • Assignee:
                pooja.nikhare Pooja Nikhare (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: