Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2341

Improve test case - do not contact igbquickload during test phase of build cycle

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Spring 7 : 13 Apr to 24 Apr, Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun, Summer 2: 22 Jun - 3 Jul

      Description

      During testing, there's a test case that contacts igbquickload.org.

      This is bad because if the remote quickload site is unavailable, the test fails. We should actually be testing the code itself and not the network during unit testing of IGB code base.

      Investigate why and how this is happening and fix it.

        Attachments

          Issue Links

            Activity

            Hide
            stiwari8 Srishti Tiwari (Inactive) added a comment -

            Please Review:
            In this, I added a few files in test resources folder to create a quickload and removed the dependency of the actual quickload URL.

            https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/7b87f57564a0c1e20c43fd21121f6caf2b0c6646

            Show
            stiwari8 Srishti Tiwari (Inactive) added a comment - Please Review: In this, I added a few files in test resources folder to create a quickload and removed the dependency of the actual quickload URL. https://bitbucket.org/srishtitiwari/integrated-genome-browser/commits/7b87f57564a0c1e20c43fd21121f6caf2b0c6646
            Hide
            stiwari8 Srishti Tiwari (Inactive) added a comment -

            Hi Dr. Loraine, I have added the suggested changes in the Branch. Please review the same.

            https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2341#diff

            Show
            stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Dr. Loraine, I have added the suggested changes in the Branch. Please review the same. https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2341#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Change request:

            The contents.txt file added to the "test" resources directory should contain only those genomes that are available it its quickly directory. Please delete all lines except the A_thaliana_Jun_2009 ones.

            Show
            ann.loraine Ann Loraine added a comment - Change request: The contents.txt file added to the "test" resources directory should contain only those genomes that are available it its quickly directory. Please delete all lines except the A_thaliana_Jun_2009 ones.
            Hide
            stiwari8 Srishti Tiwari (Inactive) added a comment -

            Hi Dr. Loraine,
            I have removed extra genomes from the quickload directory.
            Thanks,
            Srishti

            Show
            stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Dr. Loraine, I have removed extra genomes from the quickload directory. Thanks, Srishti
            Hide
            ann.loraine Ann Loraine added a comment -

            Is the quickload site supposed to be broken? (not sure)

            • contents.txt lists a genome that is not in the quickload
            • synonyms.txt is an empty file

            To check that the QL site is valid, add it to IGB and try to open the genomes (or genome) it contains.

            Show
            ann.loraine Ann Loraine added a comment - Is the quickload site supposed to be broken? (not sure) contents.txt lists a genome that is not in the quickload synonyms.txt is an empty file To check that the QL site is valid, add it to IGB and try to open the genomes (or genome) it contains.
            Hide
            stiwari8 Srishti Tiwari (Inactive) added a comment -

            Hi Dr. Loraine,
            I only added the values which were required for the existing test cases to work.
            synonyms.txt is empty because in one of the test cases its presence is being checked. It is not necessary for it to have values.
            contents.txt contains those two values because there are test cases around it.

            I will try to add a test case which checks whether there is a genome present for every entry in contents.txt.

            Show
            stiwari8 Srishti Tiwari (Inactive) added a comment - Hi Dr. Loraine, I only added the values which were required for the existing test cases to work. synonyms.txt is empty because in one of the test cases its presence is being checked. It is not necessary for it to have values. contents.txt contains those two values because there are test cases around it. I will try to add a test case which checks whether there is a genome present for every entry in contents.txt.
            Hide
            ann.loraine Ann Loraine added a comment -

            Thanks for the explanation - that sound fine.

            Show
            ann.loraine Ann Loraine added a comment - Thanks for the explanation - that sound fine.
            Show
            stiwari8 Srishti Tiwari (Inactive) added a comment - Please review the above changes here: https://bitbucket.org/srishtitiwari/integrated-genome-browser/branch/IGBF-2341#diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged.

            Show
            ann.loraine Ann Loraine added a comment - Merged.
            Hide
            nfreese Nowlan Freese added a comment -

            QuickloadDataProviderTest and QuickloadUtilsTest tests completed successfully with no internet.

            Closing issue.

            Show
            nfreese Nowlan Freese added a comment - QuickloadDataProviderTest and QuickloadUtilsTest tests completed successfully with no internet. Closing issue.

              People

              • Assignee:
                stiwari8 Srishti Tiwari (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: