Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May
Description
Many of the images in the new genome dashboard application look distorted.
For example, the image for the cow genome looks great when viewed on its own, but in the Dashboard App it looks compressed in the horizontal dimenion.
Compare:
to
The problem is that the images need to be perfectly square to look nice in the Dashboard.
For this task, examine each image and crop it as needed to make it look nice.
Before starting work on this, consult with Sameer Shanbhag (app developer) for advice or tips he may have.
Also, please note that all pull requests should go to master branch on his repository.
Use this repository for branching and submitting PRs: https://bitbucket.org/lorainelab/genome-dashboard
(Once Sameer is back we'll submit PRs to his upstream repo.)
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Rank | Ranked higher |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Ann Loraine [ aloraine ] | Sameer Shanbhag [ sameer ] |
| Sprint | Spring 8 : 24 Apr to 8 May [ 93 ] | Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 93, 94 ] |
| Rank | Ranked higher |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Sameer Shanbhag [ sameer ] |
Update:
Sameer Shanbhag looked into this and ruled out the possibility of doing this remotely. Therefore we need somebody to look carefully at all the images and crop them as needed to make them perfectly square.
| Rank | Ranked higher |
| Description |
Many of the images in the new genome dashboard application look distorted.
For example, the image for the cow genome looks great when viewed on its own, but in the Dashboard App it looks compressed in the horizontal dimenion. Compare: * https://test.bioviz.org/genome-dashboard to * https://test.bioviz.org/public/images/B_taurus.jpg The problem is that the images need to be perfectly square to look nice in the Dashboard. For this task, examine each image and crop it as needed to make it look nice. Before starting work on this, consult with [~sameer] (app developer) for advice or tips he may have. Also, please note that all pull requests should go to master branch on his repository. Use the same fork-and-branch workflow with commits starting with IGBF-2323 as usual, but submit your PR's to his repo: https://bitbucket.org/sshanbh1/genome-dashboard/ |
Many of the images in the new genome dashboard application look distorted.
For example, the image for the cow genome looks great when viewed on its own, but in the Dashboard App it looks compressed in the horizontal dimenion. Compare: * https://test.bioviz.org/genome-dashboard to * https://test.bioviz.org/public/images/B_taurus.jpg The problem is that the images need to be perfectly square to look nice in the Dashboard. For this task, examine each image and crop it as needed to make it look nice. Before starting work on this, consult with [~sameer] (app developer) for advice or tips he may have. Also, please note that all pull requests should go to master branch on his repository. Use this repository for branching and submitting PRs: https://bitbucket.org/lorainelab/genome-dashboard (Once Sameer is back we'll submit PRs to his upstream repo.) |
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Could you check B_taurus image?
Looks like the new image is 3377 × 2847 pixels instead of square.
Also, I noticed that the image for C_sativa is a photo of Cannabis sativa. It should actually be a photo of Camelina sativa. We have a name collision 
This is Camelina sativa (false flax): https://en.wikipedia.org/wiki/Camelina_sativa
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | To-Do [ 10305 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Hi Dr. Loraine, I added the changes. Please have a look:
https://bitbucket.org/srishtitiwari/genome-dashboard/branch/IGBF-2356#commits
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Thanks!
Please submit PR to master branch on lorainelab repository.
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] | Srishti Tiwari [ stiwari8 ] |
Merged. Will deploy shortly to test.bioviz.org.
| Assignee | Srishti Tiwari [ stiwari8 ] |
Changes deployed. Everybody's looking good!
cc: Srishti Tiwari and Sameer Shanbhag
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
This was in the "In Progress" column and assigned to myself.
I'm pretty sure you were working on it, so I'm re-assigning to yourself. Can you let me know if that is the right thing?