Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2399

Avoid colliding image names for species

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      The genome dashboard (see https://bioviz.org/genome-dashboard) displays images of different species that users can click on to trigger loading of the corresponding genome into IGB.

      Currently, our convention is that we use the genius and species name to determine the name of the image to be loaded for a given species.

      For instance, we use

      C_sativa

      in the image name for the plant Camelina sativa, an oilseed plant used since ancient times to make oil for lamps and ointments for the body. In modern times, we use it to make a kind of aviation fuel. It also is a very tasty cooking oil for dishes such as falafel.

      However, the image name used has name collision with another plant species – Cannabis sativa – also used since ancient times to make things like rope and also a mood-enhancing, smokeable product enjoyed by many in Canada, California, Colorado, and many other places.

      This name collision is a problem and affects other species, as well.

      For this task, look into what it would take to modify the current code to support both C. sativa's at the same time.

      Deliverables:

      Add some comments to this ticket explaining how the image selection works currently. Propose a change to the code, if such a change needs to be made.

      Get some feedback on the proposed change from another developer. Proposed a revised code change accordingly. Then, implement the change.

      Also, update the story points as needed to reflect the extent of the changes required.

        Attachments

          Issue Links

            Activity

            Hide
            ann.loraine Ann Loraine added a comment -

            If you happen to see this, do please rebase and submit PR at your earliest convenience. Otherwise no worries.

            If you want to wait

            Show
            ann.loraine Ann Loraine added a comment - If you happen to see this, do please rebase and submit PR at your earliest convenience. Otherwise no worries. If you want to wait
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            If you happen to see this, do please rebase and submit PR at your earliest convenience. Otherwise no worries as we can easily get the changes from your fork and merge in without your needing to do anything. The commit will still be yours.

            cc: Philip Badzuh and Chester Dias

            Show
            ann.loraine Ann Loraine added a comment - - edited If you happen to see this, do please rebase and submit PR at your earliest convenience. Otherwise no worries as we can easily get the changes from your fork and merge in without your needing to do anything. The commit will still be yours. cc: Philip Badzuh and Chester Dias
            Show
            cdias1 Chester Dias (Inactive) added a comment - https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/10/igbf-2399/diff
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged.

            Show
            ann.loraine Ann Loraine added a comment - Merged.
            Hide
            ann.loraine Ann Loraine added a comment -

            Philip Badzuh - IGBF-2399 code changes (from Chester Dias) are now merged to master branch.

            Show
            ann.loraine Ann Loraine added a comment - Philip Badzuh - IGBF-2399 code changes (from Chester Dias ) are now merged to master branch.

              People

              • Assignee:
                cdias1 Chester Dias (Inactive)
                Reporter:
                ann.loraine Ann Loraine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: