Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun
Description
Suddenly one of the genometry test cases is failing:
"java.lang.NullPointerException
at com.affymetrix.genometry.parsers.TwoBitParserTest.testOriginal(TwoBitParserTest.java:67)
at com.affymetrix.genometry.parsers.TwoBitParserTest.testCaseFiles(TwoBitParserTest.java:47)"
We need to investigate why this is occurring and correct the problem.
While fixing the test, improve test coverage to make the code more resilient to bugs and safer to modify.
Attachments
Issue Links
- relates to
-
IGBF-2291 Upgrade JDK version to 1.8.0.241 for loraine lab java repositories
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1531 [ 17617 ] |
| Assignee | Ann Loraine [ aloraine ] |
| Rank | Ranked higher |
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] |
Please submit PR.
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Srishti Tiwari [ stiwari8 ] | Ann Loraine [ aloraine ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Ann Loraine [ aloraine ] |
https://www.baeldung.com/junit-assert-exception
From a quick investigation, I figured out that there are changes in implementation around unit assert exception. This could be a possible reason why this test was not previously failing.
| Sprint | Spring 8 : 24 Apr to 8 May [ 93 ] | Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 93, 94 ] |
| Rank | Ranked higher |
| Sprint | Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May [ 93, 94 ] | Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 93, 94, 95 ] |
| Rank | Ranked higher |
| Sprint | Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 93, 94, 95 ] | Spring 8 : 24 Apr to 8 May, Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun [ 93, 94, 95, 96 ] |
| Rank | Ranked higher |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
The latest version of IGB from the master branch builds successfully and the breaking test now passes. Moving to done.
-------------------------------------------------------------------------------
Test set: com.affymetrix.genometry.parsers.TwoBitParserTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.335 sec - in com.affymetrix.genometry.parsers.TwoBitParserTest
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
Unfortunately there is another failed test. Please take a look and fix the test, ideally also improving the testing coverage and robustness of the tests.