Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2385

Remove "IGB is not currently running..." message from top-right of Genome Dashboard

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Story Points:
      0.25
    • Sprint:
      Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun

      Description

      The new Genome Dashboard shows a message at the top right of the screen that reads:

      "IGB is currently not running. Please start IGB"

      We no longer need this message because the subtitle of the page now shows it. Also, if a user tries to click on an image to open that genome in IGB, a popup dialog appears letting them know they need to start IGB.

      For this task, remove the "IGB is currently not running. Please start IGB" message from the top right since we don't need it anymore.

        Attachments

          Activity

          Show
          noor91zahara Noor Zahara added a comment - Code diff = https://bitbucket.org/noorzahara/genome-dashboard-local/branch/IGBF-2385#diff
          Hide
          aloraine Ann Loraine added a comment -

          Philip Badzuh - Since Noor is not working this summer, can you please submit the PR for her? You can do it by forking the team repository, adding her repository as a remote, fetching her branch, pushing her branch to your fork, and then submitting a PR from your fork to the team repository.

          Also please note that you should submit PRs to the Loraine Lab fork, not the Sameer's fork. Loraine Lab fork is https://bitbucket.org/lorainelab/genome-dashboard

          Show
          aloraine Ann Loraine added a comment - Philip Badzuh - Since Noor is not working this summer, can you please submit the PR for her? You can do it by forking the team repository, adding her repository as a remote, fetching her branch, pushing her branch to your fork, and then submitting a PR from your fork to the team repository. Also please note that you should submit PRs to the Loraine Lab fork, not the Sameer's fork. Loraine Lab fork is https://bitbucket.org/lorainelab/genome-dashboard
          Show
          pbadzuh Philip Badzuh added a comment - Sure, Dr. Loraine. I have submitted the PR here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/5/igbf-2385-remove-igb-is-not-currently/diff
          Hide
          aloraine Ann Loraine added a comment -

          Merged and ready for testing at https://test.bioviz.org/genome-dashboard.

          However it looks like changes introduced with Pooja's recent commit for https://jira.transvar.org/browse/IGBF-2386 were over-written.

          Her commit:

          Philip Badzuh - please take a look.

          If it turns out that her changes did indeed get over-written, I would recommend re-applying Pooja's commit using "git cherry-pick"

          If you want to do this, then you would create a new branch off the latest master. Then, you would use git cherry-pick to essentially copy Pooja's commit onto the new branch. You would then push the new branch to your fork.

          Normally in our workflow, you would then move this ticket to "Needs first level review", but I would say: one you've done the above, submit a PR from the branch. I will take a look and probably merge it right away.

          At that point you could move on to the next couple Genome Dashboard tickets.

          Show
          aloraine Ann Loraine added a comment - Merged and ready for testing at https://test.bioviz.org/genome-dashboard . However it looks like changes introduced with Pooja's recent commit for https://jira.transvar.org/browse/IGBF-2386 were over-written. Her commit: https://bitbucket.org/lorainelab/genome-dashboard/commits/56dfff4221891daab33848ff3c329cd7d64ae08b Philip Badzuh - please take a look. If it turns out that her changes did indeed get over-written, I would recommend re-applying Pooja's commit using "git cherry-pick" If you want to do this, then you would create a new branch off the latest master. Then, you would use git cherry-pick to essentially copy Pooja's commit onto the new branch. You would then push the new branch to your fork. Normally in our workflow, you would then move this ticket to "Needs first level review", but I would say: one you've done the above, submit a PR from the branch. I will take a look and probably merge it right away. At that point you could move on to the next couple Genome Dashboard tickets.
          Hide
          pbadzuh Philip Badzuh added a comment -

          It seems like they were working on the same area of code. There was a merge conflict, and I didn't notice that Pooja's commit was excluded when resolving it. Anyway, her commit should be now present here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/6/igbf-2386-modify-igb-is-not-running-popup/diff

          Please let me know if that looks okay. Thanks.

          Show
          pbadzuh Philip Badzuh added a comment - It seems like they were working on the same area of code. There was a merge conflict, and I didn't notice that Pooja's commit was excluded when resolving it. Anyway, her commit should be now present here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/6/igbf-2386-modify-igb-is-not-running-popup/diff Please let me know if that looks okay. Thanks.
          Hide
          nfreese Nowlan Freese added a comment -

          Testing https://test.bioviz.org/genome-dashboard on mac with chrome.

          The message "IGB is currently not running. Please start IGB" no longer appears.

          Closing issue.

          Show
          nfreese Nowlan Freese added a comment - Testing https://test.bioviz.org/genome-dashboard on mac with chrome. The message "IGB is currently not running. Please start IGB" no longer appears. Closing issue.

            People

            • Assignee:
              noor91zahara Noor Zahara
              Reporter:
              aloraine Ann Loraine
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: