Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2385

Remove "IGB is not currently running..." message from top-right of Genome Dashboard

        Details

        • Type: Task
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None
        • Story Points:
          0.25
        • Epic Link:
        • Sprint:
          Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun

          Description

          The new Genome Dashboard shows a message at the top right of the screen that reads:

          "IGB is currently not running. Please start IGB"

          We no longer need this message because the subtitle of the page now shows it. Also, if a user tries to click on an image to open that genome in IGB, a popup dialog appears letting them know they need to start IGB.

          For this task, remove the "IGB is currently not running. Please start IGB" message from the top right since we don't need it anymore.

            Attachments

              Activity

              Ascending order - Click to sort in descending order
              ann.loraine Ann Loraine created issue -
              ann.loraine Ann Loraine made changes -
              Field Original Value New Value
              Epic Link IGBF-1765 [ 17855 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ]
              Hide
              Permalink
              noor91zahara Noor Zahara (Inactive) added a comment -

              Code diff = https://bitbucket.org/noorzahara/genome-dashboard-local/branch/IGBF-2385#diff

              Show
              noor91zahara Noor Zahara (Inactive) added a comment - Code diff = https://bitbucket.org/noorzahara/genome-dashboard-local/branch/IGBF-2385#diff
              noor91zahara Noor Zahara (Inactive) made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              noor91zahara Noor Zahara (Inactive) made changes -
              Assignee Noor Zahara [ noor91zahara ]
              ann.loraine Ann Loraine made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              ann.loraine Ann Loraine made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              ann.loraine Ann Loraine made changes -
              Assignee Philip Badzuh [ pbadzuh ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Philip Badzuh - Since Noor is not working this summer, can you please submit the PR for her? You can do it by forking the team repository, adding her repository as a remote, fetching her branch, pushing her branch to your fork, and then submitting a PR from your fork to the team repository.

              Also please note that you should submit PRs to the Loraine Lab fork, not the Sameer's fork. Loraine Lab fork is https://bitbucket.org/lorainelab/genome-dashboard

              Show
              ann.loraine Ann Loraine added a comment - Philip Badzuh - Since Noor is not working this summer, can you please submit the PR for her? You can do it by forking the team repository, adding her repository as a remote, fetching her branch, pushing her branch to your fork, and then submitting a PR from your fork to the team repository. Also please note that you should submit PRs to the Loraine Lab fork, not the Sameer's fork. Loraine Lab fork is https://bitbucket.org/lorainelab/genome-dashboard
              ann.loraine Ann Loraine made changes -
              Sprint Spring 8 : 11 May to 25 May [ 94 ] Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 94, 95 ]
              ann.loraine Ann Loraine made changes -
              Rank Ranked higher
              Hide
              Permalink
              pbadzuh Philip Badzuh (Inactive) added a comment -

              Sure, Dr. Loraine. I have submitted the PR here:
              https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/5/igbf-2385-remove-igb-is-not-currently/diff

              Show
              pbadzuh Philip Badzuh (Inactive) added a comment - Sure, Dr. Loraine. I have submitted the PR here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/5/igbf-2385-remove-igb-is-not-currently/diff
              pbadzuh Philip Badzuh (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              ann.loraine Ann Loraine made changes -
              Assignee Philip Badzuh [ pbadzuh ]
              Hide
              Permalink
              ann.loraine Ann Loraine added a comment -

              Merged and ready for testing at https://test.bioviz.org/genome-dashboard.

              However it looks like changes introduced with Pooja's recent commit for https://jira.transvar.org/browse/IGBF-2386 were over-written.

              Her commit:

              Philip Badzuh - please take a look.

              If it turns out that her changes did indeed get over-written, I would recommend re-applying Pooja's commit using "git cherry-pick"

              If you want to do this, then you would create a new branch off the latest master. Then, you would use git cherry-pick to essentially copy Pooja's commit onto the new branch. You would then push the new branch to your fork.

              Normally in our workflow, you would then move this ticket to "Needs first level review", but I would say: one you've done the above, submit a PR from the branch. I will take a look and probably merge it right away.

              At that point you could move on to the next couple Genome Dashboard tickets.

              Show
              ann.loraine Ann Loraine added a comment - Merged and ready for testing at https://test.bioviz.org/genome-dashboard . However it looks like changes introduced with Pooja's recent commit for https://jira.transvar.org/browse/IGBF-2386 were over-written. Her commit: https://bitbucket.org/lorainelab/genome-dashboard/commits/56dfff4221891daab33848ff3c329cd7d64ae08b Philip Badzuh - please take a look. If it turns out that her changes did indeed get over-written, I would recommend re-applying Pooja's commit using "git cherry-pick" If you want to do this, then you would create a new branch off the latest master. Then, you would use git cherry-pick to essentially copy Pooja's commit onto the new branch. You would then push the new branch to your fork. Normally in our workflow, you would then move this ticket to "Needs first level review", but I would say: one you've done the above, submit a PR from the branch. I will take a look and probably merge it right away. At that point you could move on to the next couple Genome Dashboard tickets.
              ann.loraine Ann Loraine made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              ann.loraine Ann Loraine made changes -
              Status Post-merge Testing In Progress [ 10003 ] To-Do [ 10305 ]
              ann.loraine Ann Loraine made changes -
              Assignee Philip Badzuh [ pbadzuh ]
              pbadzuh Philip Badzuh (Inactive) made changes -
              Status To-Do [ 10305 ] In Progress [ 3 ]
              Hide
              Permalink
              pbadzuh Philip Badzuh (Inactive) added a comment -

              It seems like they were working on the same area of code. There was a merge conflict, and I didn't notice that Pooja's commit was excluded when resolving it. Anyway, her commit should be now present here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/6/igbf-2386-modify-igb-is-not-running-popup/diff

              Please let me know if that looks okay. Thanks.

              Show
              pbadzuh Philip Badzuh (Inactive) added a comment - It seems like they were working on the same area of code. There was a merge conflict, and I didn't notice that Pooja's commit was excluded when resolving it. Anyway, her commit should be now present here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/6/igbf-2386-modify-igb-is-not-running-popup/diff Please let me know if that looks okay. Thanks.
              pbadzuh Philip Badzuh (Inactive) made changes -
              Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
              pbadzuh Philip Badzuh (Inactive) made changes -
              Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
              pbadzuh Philip Badzuh (Inactive) made changes -
              Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
              pbadzuh Philip Badzuh (Inactive) made changes -
              Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
              pbadzuh Philip Badzuh (Inactive) made changes -
              Assignee Philip Badzuh [ pbadzuh ]
              ann.loraine Ann Loraine made changes -
              Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
              ann.loraine Ann Loraine made changes -
              Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
              Hide
              Permalink
              nfreese Nowlan Freese added a comment -

              Testing https://test.bioviz.org/genome-dashboard on mac with chrome.

              The message "IGB is currently not running. Please start IGB" no longer appears.

              Closing issue.

              Show
              nfreese Nowlan Freese added a comment - Testing https://test.bioviz.org/genome-dashboard on mac with chrome. The message "IGB is currently not running. Please start IGB" no longer appears. Closing issue.
              nfreese Nowlan Freese made changes -
              Assignee Noor Zahara [ noor91zahara ]
              nfreese Nowlan Freese made changes -
              Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
              nfreese Nowlan Freese made changes -
              Resolution Done [ 10000 ]
              Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]

                People

                • Assignee:
                  noor91zahara Noor Zahara (Inactive)
                  Reporter:
                  ann.loraine Ann Loraine
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: