Details
-
Type:
Task
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun
Description
The new genome dashboard application (https://www.bioviz.org/genome-dashboard) shows images representing different species for which genome sequence data are avaiable.
When users click an image, the latest genome version for the featured species is supposed to load into IGB.
However, this only works if IGB is currently running.
So the Genome Dashboard App has some code that checks to see if IGB is running.
If IGB is not running, then it shows a popup to let them know to start IGB.
The wording of the popup is currently a little confusing for users because it uses programming-focused terminology. See attached for the current designed.
For this task, modify the popup so that it uses language that is more understandable.
In addition, modify the "Download" button on the popup as follows:
- Change the color to perfectly match the appearance of the Download button on the download page https://www.bioviz.org/download.html
- Change the link so that a new Web page window opens on the user's browser https://www.bioviz.org/download.html. Make it a fully-functional browser page not a popup.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1765 [ 17855 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
Ready for pull request - please proceed.
cc: Pooja Nikhare
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Post-merge Testing In Progress [ 10003 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Merged.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
Latest code visible on test.bioviz.org/genome-dashboard
Tested this ticket. The latest code changes are visible on https://test.bioviz.org/genome-dashboard which reflect the message change in Popup window. It now says "IGB Application is not Running". The Download button resembles the one on https://www.bioviz.org/download.html and it redirects to https://www.bioviz.org/download.html by opening a new tab.
Moving to closed.
cc: Prof. [~aloraine]
Thank you for merging it and letting me know.
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] | Pooja Nikhare [ pooja.nikhare ] |
Change request:
- Can this be modified so that a new window and just a new tab opens?
cc: Pooja Nikhare
| Resolution | Done [ 10000 ] | |
| Status | Closed [ 6 ] | To-Do [ 10305 ] |
Similar to onclick of Integrated Genome Browser on title "Start Integrated Genome Browser. Then click a species open its genome" ?
This can be done.
Actually, not exactly.
What I am hoping for is a new browser window to be opened – with URL entry bar and everything. That is, the same thing that would appear in a new tab, but in a separate window.
Maybe it is not possible – it depends on the browser:
https://www.thesitewizard.com/html-tutorial/open-links-in-new-window-or-tab.shtml
Also, Sameer had looked into it as well:
Since it is not possible to open a functionally complete browser window, use the solution that Sameer has implemented for the link labeled "Integrated Genome Browser" shown in the Genome Dashboard page's sub-title heading.
To complete this task:
- Examine the code Sameer has used - see link in sub-title
- Re-use it for the link shown in the "IGB is not running" popup.
Also, change the popup wording a bit:
- Change "IGB Application is Not Running" to "To view a genome, start IGB"
Then change the body of the popup to read:
Don't have IGB? No problem!
then display the current "Download Now" button.
| Attachment | igb-not-running-new.png [ 14734 ] |
| Assignee | Pooja Nikhare [ pooja.nikhare ] | Ann Loraine [ aloraine ] |
| Assignee | Ann Loraine [ aloraine ] |
| Sprint | Spring 8 : 11 May to 25 May [ 94 ] | Spring 8 : 11 May to 25 May, Spring 9 : 25 May to 8 Jun [ 94, 95 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
Merged.
Deployed to https://test.bioviz.org/genome-dashboard.
Latest deployed commit:
- daabc8e
IGBF-2386: Modify IGB-is-not-running popup
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
To complete the ticket, make the changes described above. (See comment added 21/May/20 above)
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Assignee | Philip Badzuh [ pbadzuh ] |
| Status | In Progress [ 3 ] | To-Do [ 10305 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
Please see my changes here:
https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/commits/79227ba1f8f20982196ca7faa2a5b37e8dde14b0
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Deployed to https://test.bioviz.org/genome-dashboard and ready for testing.
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Assignee | Nowlan Freese [ nfreese ] |
Tested https://test.bioviz.org/genome-dashboard on mac.
Popup occurs when IGB is not running with requested text:
To view a genome, start IGB
Don't have IGB? No problem!
Download Now Close
Closing issue.
| Assignee | Nowlan Freese [ nfreese ] | Philip Badzuh [ pbadzuh ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
Please review code changes: https://bitbucket.org/pnikhare/genome-dashboard/branch/IGBF-2386#diff
Prof [~aloraine] , Please let me know if any words to be changed.