Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2408

Allow genome versions names to wrap on _ (underscore) characters

        Details

        • Type: New Feature
        • Status: Closed (View Workflow)
        • Priority: Major
        • Resolution: Done
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
          None

          Description

          Genome Dashboard wraps text contained in the version menu items using "-" (hyphen) characters.

          For example, if a genome version name is too long to fit the available space, Genome Dashboard can split it across two lines if the name contains a hyphen character. See attached for an example.

          Investigate: Is there a setting that would let Genome Dashboard wrap on underscore ("_") characters also?

            Attachments

              Issue Links

              relates to

              Bug - A problem which impairs or prevents the functions of the product. IGBF-2389 Fix "i" not showing in genome dashboard

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see my branch below:
                https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2408#diff

                • Genome names now wrap on underscores
                • The grid is now more uniform - no large card(s) in the last row. In searching, however, a single result will still stretch the card to the left and right edges as before.
                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see my branch below: https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/branch/IGBF-2408#diff Genome names now wrap on underscores The grid is now more uniform - no large card(s) in the last row. In searching, however, a single result will still stretch the card to the left and right edges as before.
                Hide
                Permalink
                nfreese Nowlan Freese added a comment -

                Code looks good, working correctly.

                Recommend pull request.

                Show
                nfreese Nowlan Freese added a comment - Code looks good, working correctly. Recommend pull request.
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see PR here:
                https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/13/igbf-2408-wrap-genome-versions-on/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see PR here: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/13/igbf-2408-wrap-genome-versions-on/diff
                Hide
                Permalink
                gchamma Jay Chamma (Inactive) added a comment -

                Post merge review:
                The following genome versions were long enough to trigger the wrapping around the underscore "_" on Chrome and FireFox

                • T_kodakaraensis_KOD1_May_2004
                • V_corymbosum_scaffold_May_2013
                • M_acuminata_DH_Pahang_Jan_2016

                These long genome names all wrapped around the underscore correctly on Chrome to produce:
                V_corymbosum_scaffold_May_
                2013
                T_kodakaraensis_KOD1_May_
                2004
                M_acuminata_DH_Pahang_Jan_
                2016

                However, the genome names did not wrap correctly on FireFox.
                When shrinking the page down to force the wrapping of the genome names, the following was the result on FireFox:
                https://i.imgur.com/5kwn5x0.png

                Steps taken to confirm this on Chrome and Firefox:
                1. Open the Genome Dashboard on FireFox
                2. Click on "View Genome" for one of the organisms listed above
                3. Shrink the page horizontally as much as possible

                Since a bug is occurring with this ticket, I am moving it back to "To-Do" and re-assigning this to Philip Badzuh

                Show
                gchamma Jay Chamma (Inactive) added a comment - Post merge review: The following genome versions were long enough to trigger the wrapping around the underscore "_" on Chrome and FireFox T_kodakaraensis_KOD1_May_2004 V_corymbosum_scaffold_May_2013 M_acuminata_DH_Pahang_Jan_2016 These long genome names all wrapped around the underscore correctly on Chrome to produce: V_corymbosum_scaffold_May_ 2013 T_kodakaraensis_KOD1_May_ 2004 M_acuminata_DH_Pahang_Jan_ 2016 However, the genome names did not wrap correctly on FireFox. When shrinking the page down to force the wrapping of the genome names, the following was the result on FireFox: https://i.imgur.com/5kwn5x0.png Steps taken to confirm this on Chrome and Firefox: 1. Open the Genome Dashboard on FireFox 2. Click on "View Genome" for one of the organisms listed above 3. Shrink the page horizontally as much as possible Since a bug is occurring with this ticket, I am moving it back to "To-Do" and re-assigning this to Philip Badzuh
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Please see the proposed changes here:
                https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/commits/38d705354617d005d2efb876892aae2be6fdbd1f?at=IGBF-2408

                I have not been able to find a way to fix this issue in firefox, but a simple solution would be to rid the genome version names in the UI of underscores altogether, which is what the above commit accomplishes. This allows for correct wrapping on chrome, firefox, and safari and looks more user friendly, in my opinion. This doesn't modify any backend quickload data, but simply styles it for the front end for this specific use case. Please let me know what you think.

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Please see the proposed changes here: https://bitbucket.org/pbadzuh/genome-dashboard_pbdev/commits/38d705354617d005d2efb876892aae2be6fdbd1f?at=IGBF-2408 I have not been able to find a way to fix this issue in firefox, but a simple solution would be to rid the genome version names in the UI of underscores altogether, which is what the above commit accomplishes. This allows for correct wrapping on chrome, firefox, and safari and looks more user friendly, in my opinion. This doesn't modify any backend quickload data, but simply styles it for the front end for this specific use case. Please let me know what you think.
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Let's try it. Recommend PR.

                Show
                ann.loraine Ann Loraine added a comment - Let's try it. Recommend PR.
                Hide
                Permalink
                pbadzuh Philip Badzuh (Inactive) added a comment -

                Great, please see PR below:
                https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/20/igbf-2408-make-genome-version-names-space/diff

                Show
                pbadzuh Philip Badzuh (Inactive) added a comment - Great, please see PR below: https://bitbucket.org/lorainelab/genome-dashboard/pull-requests/20/igbf-2408-make-genome-version-names-space/diff
                Hide
                Permalink
                ann.loraine Ann Loraine added a comment -

                Merged.

                Show
                ann.loraine Ann Loraine added a comment - Merged.

                  People

                  • Assignee:
                    pbadzuh Philip Badzuh (Inactive)
                    Reporter:
                    ann.loraine Ann Loraine
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    4 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: