Uploaded image for project: 'IGB'
  1. IGB
  2. IGBF-2412

CLONE - On-boarding: Step 4 - add your name to Credits

    Details

    • Type: Task
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Story Points:
      2
    • Sprint:
      Fall 2018 Sprint 5, Winter 2018 Sprint 1, Winter 2018 Sprint 3, Spring 2019 Sprint 1, Spring 2019 Sprint 2, Summer 2019 Sprint 7, Summer 2019 Sprint 8, Summer 2019 Sprint 9, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun

      Description

      Review:

      https://canvas.instructure.com/courses/1164217

      Focus on sections:

      • Introduction
      • NetBeans IDE.

      Start IGB and Select Help > About IGB

      Note there is a list of contributors. For this task, add your name to the list.

      Note: The main goal of this ticket/issue is for you to practice the IGB workflow using Jira.

      • Assign this issue to yourself, and move it into the current spring to the "In Progress" lane. (If someone is already working on it, make a copy of it and link the copy to IGBF-1464.)
      • Read and review the comments and previous work done by others. Review the comments and history for the linked issues, as well.
      • Work on adding your name to the credits. Use the IGB fork-and-branch workflow.
      • Once you've moved it to the "Needs first level review" column.

      Reminders and tips:

      • Make sure your installer has built. Whoever does the functional review will download and run your installer.
      • Make sure you add a link to your fork and branch as a comment to the issue. Whoever does code review will need the link to find your fork and view your code.
      • Use correct voice and format for commit messages.

        Attachments

          Issue Links

            Activity

            gchamma Jay Chamma (Inactive) created issue -
            gchamma Jay Chamma (Inactive) made changes -
            Field Original Value New Value
            Epic Link IGBF-1762 [ 17852 ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue clones IGBF-1464 [ IGBF-1464 ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue relates to IGBF-1347 [ IGBF-1347 ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue is blocked by IGBF-1764 [ IGBF-1764 ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue is blocked by IGBF-1573 [ IGBF-1573 ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue relates to IGBF-1572 [ IGBF-1572 ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue relates to IGBF-1738 [ IGBF-1738 ]
            gchamma Jay Chamma (Inactive) made changes -
            Assignee Rachel Weidenhammer [ rweidenh ] Jay Chamma [ gchamma ]
            gchamma Jay Chamma (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            gchamma Jay Chamma (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            Hide
            gchamma Jay Chamma (Inactive) added a comment -

            [~aloraine]
            I have accidentally added the commit to the master branch and was unable to revert the change. Please tell me if I need to do anything to fix it.
            Because of earlier mistakes regarding the commit message, I have two commits which are doing the same thing.
            I apologize for any inconvenience
            https://bitbucket.org/Gchamma/integrated-genome-browser/commits/

            Show
            gchamma Jay Chamma (Inactive) added a comment - [~aloraine] I have accidentally added the commit to the master branch and was unable to revert the change. Please tell me if I need to do anything to fix it. Because of earlier mistakes regarding the commit message, I have two commits which are doing the same thing. I apologize for any inconvenience https://bitbucket.org/Gchamma/integrated-genome-browser/commits/
            Hide
            ann.loraine Ann Loraine added a comment -

            I would do some research into how to undo a commit after it's been pushed to "origin" or another remote repository.

            I think you can undo it maybe using git reset.

            Enroll the Canvas class and do the "git" module. I'm pretty sure it covers git reset. Do the learn git branching tutorial a couple times until it sinks in. It is the best thing there is for learning git. Git is brilliant and powerful, but it takes time to understand it in a deep way.

            Also: Google "how to undo a commit to master branch after I pushed to my fork"

            Show
            ann.loraine Ann Loraine added a comment - I would do some research into how to undo a commit after it's been pushed to "origin" or another remote repository. I think you can undo it maybe using git reset. Enroll the Canvas class and do the "git" module. I'm pretty sure it covers git reset. Do the learn git branching tutorial a couple times until it sinks in. It is the best thing there is for learning git. Git is brilliant and powerful, but it takes time to understand it in a deep way. Also: Google "how to undo a commit to master branch after I pushed to my fork"
            gchamma Jay Chamma (Inactive) made changes -
            Comment [ [~aloraine]
            Fixed all issues and issued a new commit in a new branch.
            Ready for 1st-level review.
            https://bitbucket.org/Gchamma/integrated-genome-browser/commits/edfe0dfcba3d72499b80db8686d97b4c087aac9e ]
            Hide
            gchamma Jay Chamma (Inactive) added a comment - - edited

            Commit and branch created, and the installer was downloaded and tested.
            Ready for 1st-level review.
            https://bitbucket.org/Gchamma/integrated-genome-browser/commits/edfe0dfcba3d72499b80db8686d97b4c087aac9e

            Show
            gchamma Jay Chamma (Inactive) added a comment - - edited Commit and branch created, and the installer was downloaded and tested. Ready for 1st-level review. https://bitbucket.org/Gchamma/integrated-genome-browser/commits/edfe0dfcba3d72499b80db8686d97b4c087aac9e
            gchamma Jay Chamma (Inactive) made changes -
            gchamma Jay Chamma (Inactive) made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            gchamma Jay Chamma (Inactive) made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            gchamma Jay Chamma (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            gchamma Jay Chamma (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            nfreese Nowlan Freese made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            nfreese Nowlan Freese made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Jay Chamma please note:

            Ticket is in "Ready for Pull Request" column. No notes have been added explaining what testing was done by the reviewer (Nowlan Freese) which is not ideal, but for very lightweight changes such as this, it's OK.

            Show
            ann.loraine Ann Loraine added a comment - Jay Chamma please note: Ticket is in "Ready for Pull Request" column. No notes have been added explaining what testing was done by the reviewer ( Nowlan Freese ) which is not ideal, but for very lightweight changes such as this, it's OK.
            Hide
            ann.loraine Ann Loraine added a comment -

            I have merged PR submitted by Logan Weidenhammer which touches the same line of code.

            Jay Chamma: Please rebase your branch onto master. Note there will be a conflict during the rebase, which is fine – you'll just need to manually edit the line to ensure your change and Rachel's change are both present.

            Show
            ann.loraine Ann Loraine added a comment - I have merged PR submitted by Logan Weidenhammer which touches the same line of code. Jay Chamma : Please rebase your branch onto master. Note there will be a conflict during the rebase, which is fine – you'll just need to manually edit the line to ensure your change and Rachel's change are both present.
            ann.loraine Ann Loraine made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] To-Do [ 10305 ]
            gchamma Jay Chamma (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            Hide
            gchamma Jay Chamma (Inactive) added a comment -

            [~aloraine]
            Rebased and resolved the conflict successfully, please review the following commit:
            https://bitbucket.org/Gchamma/integrated-genome-browser/commits/0cce23ae0983f44d49d983aafa4a782da07ce309

            Show
            gchamma Jay Chamma (Inactive) added a comment - [~aloraine] Rebased and resolved the conflict successfully, please review the following commit: https://bitbucket.org/Gchamma/integrated-genome-browser/commits/0cce23ae0983f44d49d983aafa4a782da07ce309
            gchamma Jay Chamma (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            ann.loraine Ann Loraine made changes -
            Sprint Fall 2018 Sprint 5, Winter 2018 Sprint 1, Winter 2018 Sprint 3, Spring 2019 Sprint 1, Spring 2019 Sprint 2, Summer 2019 Sprint 7, Summer 2019 Sprint 8, Summer 2019 Sprint 9, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Spring 9 : 25 May to 8 Jun [ 55, 56, 58, 59, 60, 66, 67, 68, 76, 77, 78, 79, 95 ] Fall 2018 Sprint 5, Winter 2018 Sprint 1, Winter 2018 Sprint 3, Spring 2019 Sprint 1, Spring 2019 Sprint 2, Summer 2019 Sprint 7, Summer 2019 Sprint 8, Summer 2019 Sprint 9, Fall 5 : 14 Oct to 25 Oct, Fall 6 : 28 Oct to 8 Nov, Fall 7 : 11 Nov to 22 Nov, Fall 8 : 25 Nov to 6 Dec, Spring 9 : 25 May to 8 Jun, Summer 1: 8 Jun - 19 Jun [ 55, 56, 58, 59, 60, 66, 67, 68, 76, 77, 78, 79, 95, 96 ]
            ann.loraine Ann Loraine made changes -
            Rank Ranked higher
            Hide
            ann.loraine Ann Loraine added a comment - - edited

            Please re-read https://canvas.instructure.com/courses/1164217/pages/understand-igb-development-workflow?module_item_id=12709540.

            When done, the developer pushes their commits changes to the topic branch to their fork, which should be configured to automatically build a branch-specific installers. (Instructions on for configuration are covered elsewhere.)

            Once the installer is built, developer adds a link to their topic branch to the Jira issue as a Comment. They then move the issue into the next column - "Needs 1st Level Review" - and un-assigns the issue. This signals to everyone else that the issue is now ready for review, and anyone with time and expertise can pick it up.

            You need to include a link to your branch and also you need to un-assign the ticket when you move it to "Needs 1st Level Review"

            Show
            ann.loraine Ann Loraine added a comment - - edited Please re-read https://canvas.instructure.com/courses/1164217/pages/understand-igb-development-workflow?module_item_id=12709540 . When done, the developer pushes their commits changes to the topic branch to their fork, which should be configured to automatically build a branch-specific installers. (Instructions on for configuration are covered elsewhere.) Once the installer is built, developer adds a link to their topic branch to the Jira issue as a Comment. They then move the issue into the next column - "Needs 1st Level Review" - and un-assigns the issue. This signals to everyone else that the issue is now ready for review, and anyone with time and expertise can pick it up. You need to include a link to your branch and also you need to un-assign the ticket when you move it to "Needs 1st Level Review"
            Hide
            gchamma Jay Chamma (Inactive) added a comment - - edited

            [~aloraine]
            Moved to need first level review column, unassigned the ticket, and the Installer is working successfully.
            Branch link: https://bitbucket.org/Gchamma/integrated-genome-browser/branch/IGBF-2412

            Show
            gchamma Jay Chamma (Inactive) added a comment - - edited [~aloraine] Moved to need first level review column, unassigned the ticket, and the Installer is working successfully. Branch link: https://bitbucket.org/Gchamma/integrated-genome-browser/branch/IGBF-2412
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] To-Do [ 10305 ]
            gchamma Jay Chamma (Inactive) made changes -
            Assignee Jay Chamma [ gchamma ]
            gchamma Jay Chamma (Inactive) made changes -
            Assignee Jay Chamma [ gchamma ]
            gchamma Jay Chamma (Inactive) made changes -
            Status To-Do [ 10305 ] In Progress [ 3 ]
            gchamma Jay Chamma (Inactive) made changes -
            Status In Progress [ 3 ] Needs 1st Level Review [ 10005 ]
            gchamma Jay Chamma (Inactive) made changes -
            Assignee Jay Chamma [ gchamma ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ]
            ann.loraine Ann Loraine made changes -
            Status Needs 1st Level Review [ 10005 ] First Level Review in Progress [ 10301 ]
            ann.loraine Ann Loraine made changes -
            Status First Level Review in Progress [ 10301 ] Ready for Pull Request [ 10304 ]
            ann.loraine Ann Loraine made changes -
            Assignee Ann Loraine [ aloraine ] Jay Chamma [ gchamma ]
            Hide
            ann.loraine Ann Loraine added a comment -

            I looked at the commit and the branch. It includes the latest code (from Rachel) and adheres to coding standards. I did not download or run the code, but I am confident it works. Recommending pull request.
            cc: Jay Chamma

            Show
            ann.loraine Ann Loraine added a comment - I looked at the commit and the branch. It includes the latest code (from Rachel) and adheres to coding standards. I did not download or run the code, but I am confident it works. Recommending pull request. cc: Jay Chamma
            gchamma Jay Chamma (Inactive) made changes -
            Status Ready for Pull Request [ 10304 ] Pull Request Submitted [ 10101 ]
            Show
            gchamma Jay Chamma (Inactive) added a comment - [~aloraine] Pull request submitted Link: https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/800/igbf-2412-add-name-to-credits/diff
            gchamma Jay Chamma (Inactive) made changes -
            Assignee Jay Chamma [ gchamma ]
            ann.loraine Ann Loraine made changes -
            Status Pull Request Submitted [ 10101 ] Reviewing Pull Request [ 10303 ]
            ann.loraine Ann Loraine made changes -
            Status Reviewing Pull Request [ 10303 ] Merged Needs Testing [ 10002 ]
            Hide
            ann.loraine Ann Loraine added a comment -

            Merged.

            Show
            ann.loraine Ann Loraine added a comment - Merged.
            nfreese Nowlan Freese made changes -
            Status Merged Needs Testing [ 10002 ] Post-merge Testing In Progress [ 10003 ]
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ]
            Hide
            nfreese Nowlan Freese added a comment -

            Tested on master branch.

            Galal Chamma shows up in credits.

            Show
            nfreese Nowlan Freese added a comment - Tested on master branch. Galal Chamma shows up in credits.
            nfreese Nowlan Freese made changes -
            Resolution Done [ 10000 ]
            Status Post-merge Testing In Progress [ 10003 ] Closed [ 6 ]
            nfreese Nowlan Freese made changes -
            Assignee Nowlan Freese [ nfreese ] Jay Chamma [ gchamma ]
            gchamma Jay Chamma (Inactive) made changes -
            Link This issue is blocked by IGBF-2483 [ IGBF-2483 ]
            ann.loraine Ann Loraine made changes -
            Assignee Jay Chamma [ gchamma ]

              People

              • Assignee:
                Unassigned
                Reporter:
                gchamma Jay Chamma (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: