Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Done
-
Affects Version/s: None
-
Fix Version/s: None
-
Labels:None
-
Story Points:0.5
-
Epic Link:
-
Sprint:Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 3 Aug - 14 Aug
Description
We no longer support DAS v2. Let's remove the code from the project.
Note: This will affect many places in the code, notably:
- Places where default data sources are configured - see IGB Preferences JSON file
- DAS v2 module itself: "Core - DAS 2 (data source) module"
- POM files that declare dependencies on the DAS2 module within IGB
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | IGBF-1531 [ 17617 ] |
| Rank | Ranked higher |
| Assignee | Ann Loraine [ aloraine ] |
| Description | We no longer support DAS2. Let's remove the code from the project. |
We no longer support DAS2. Let's remove the code from the project.
Note: This will affect many places in the code, notably: * Places where default data sources are configured - see IGB Preferences JSON file * DAS2 module itself: "Core - DAS 2 (data source) module" * POM files that declare dependencies on the DAS2 module within IGB |
| Description |
We no longer support DAS2. Let's remove the code from the project.
Note: This will affect many places in the code, notably: * Places where default data sources are configured - see IGB Preferences JSON file * DAS2 module itself: "Core - DAS 2 (data source) module" * POM files that declare dependencies on the DAS2 module within IGB |
We no longer support DAS v2. Let's remove the code from the project.
Note: This will affect many places in the code, notably: * Places where default data sources are configured - see IGB Preferences JSON file * DAS v2 module itself: "Core - DAS 2 (data source) module" * POM files that declare dependencies on the DAS2 module within IGB |
| Summary | Remove DAS2 code | Remove DAS v2 code |
| Sprint | Summer 4: 14 Jul - 28 Jul [ 99 ] |
| Rank | Ranked lower |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Sprint | Summer 4: 14 Jul - 28 Jul [ 99 ] | Summer 3: 6 Jul - 17 Jul [ 98 ] |
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Sprint | Summer 3: 6 Jul - 17 Jul [ 98 ] | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] |
| Rank | Ranked higher |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
Shamika Gajanan Kulkarni, i have followed the steps that are mentioned above to test if the IGB is functioning properly even after the removal of DASv2 dependency. Everything is working as expected and removing the DASv2 support hasn't affected IGB in any way.
You can submit a PR for the same.
| Assignee | Prutha Kulkarni [ prutha ] | Shamika Gajanan Kulkarni [ shamika ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Sprint | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul [ 98, 99 ] | Summer 3: 6 Jul - 17 Jul, Summer 4: 14 Jul - 28 Jul, Summer 5: 29 Jul - 12 Aug [ 98, 99, 100 ] |
| Rank | Ranked higher |
PR submitted. Kindly review.
https://bitbucket.org/lorainelab/integrated-genome-browser/pull-requests/814/igbf-2473-remove-das-v2-code/diff
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
Merged. Please test using master branch installer from team repository.
Request for Shamika Gajanan Kulkarni:
Could you provide guidance on how to test - what things to check for in the application?
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
| Status | Post-merge Testing In Progress [ 10003 ] | To-Do [ 10305 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
For testing:
Download the master branch installer and install IGB. Check if IGB functions properly after removing DAS V2 support from the codebase. Genomes should load properly. Check if the name and url for DAS v2 has been removed from 'Data Sources' in IGB Preferences.
| Status | To-Do [ 10305 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | Needs 1st Level Review [ 10005 ] |
| Status | Needs 1st Level Review [ 10005 ] | First Level Review in Progress [ 10301 ] |
| Status | First Level Review in Progress [ 10301 ] | Ready for Pull Request [ 10304 ] |
| Status | Ready for Pull Request [ 10304 ] | Pull Request Submitted [ 10101 ] |
| Status | Pull Request Submitted [ 10101 ] | Reviewing Pull Request [ 10303 ] |
| Status | Reviewing Pull Request [ 10303 ] | Merged Needs Testing [ 10002 ] |
| Assignee | Shamika Gajanan Kulkarni [ shamika ] |
| Assignee | Prutha Kulkarni [ prutha ] |
| Status | Merged Needs Testing [ 10002 ] | Post-merge Testing In Progress [ 10003 ] |
I have downloaded the master branch installer and opened the "IGB preferences" to check if it still has DAS V2. Since the DAS v2 support is now removed from IGB, the DAS v2 wasn't there. Rest of the IGB functionality is working fine even after the removal of DAS v2 support.
Shamika Gajanan Kulkarni moving the ticket to done.
| Assignee | Prutha Kulkarni [ prutha ] | Shamika Gajanan Kulkarni [ shamika ] |
| Resolution | Done [ 10000 ] | |
| Status | Post-merge Testing In Progress [ 10003 ] | Closed [ 6 ] |
The code changes are present here:
https://bitbucket.org/skulka2710/shamika_igb/branch/IGBF-2473#diff
Moving to First Level Review. Kindly review.
For testing:
Go to the "Downloads" section of my fork and download
IGBF-2473branch installer.Check if the IGB is functioning properly after removing the DAS v2 support from the codebase.